Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2651 bytes --]

On Fri, Aug 28, 2026 at 06:05:17PM +0200, Marek Vasut wrote:
> On 8/28/26 5:57 PM, Conor Dooley wrote:
> 
> [...]
> 
> > > +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> > > @@ -39,6 +39,17 @@ properties:
> > >     "#clock-cells":
> > >       const: 0
> > > +  "#address-cells":
> > > +    const: 1
> > > +
> > > +  "#size-cells":
> > > +    const: 1
> > > +
> > > +patternProperties:
> > > +  "^phy@[0-9a-f]+$":
> > > +    type: object
> > > +    $ref: /schemas/phy/st,stm32-usb2phy.yaml
> > > +
> > >   required:
> > >     - compatible
> > >     - reg
> > > @@ -57,10 +68,14 @@ allOf:
> > >     - if:
> > >         properties:
> > >           compatible:
> > > -          const: st,stm32mp25-syscfg
> > > +          enum:
> > > +            - st,stm32mp23-syscfg
> > > +            - st,stm32mp25-syscfg
> > 
> > Sashiko comment here I believe is valid, the syntax here only works if
> > there's only the listed compatible present. It doesn't work with
> > fallbacks.
> 
> This syntax is used all over the place ?
> 
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-allOf:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - $ref:
> ahci-common.yaml#
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - if:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-      properties:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-        compatible:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml:          contains:

                                                                     ^^^^^^^^
This is the key difference, you need "contains" for partial matches.

> Documentation/devicetree/bindings/ata/ahci-platform.yaml-            enum:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> qcom,apq8064-ahci
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> qcom,ipq806x-ahci
> 
> > pw-bot: changes-requested
> > 
> > >       then:
> > >         required:
> > >           - "#clock-cells"
> > > +        - "#address-cells"
> > > +        - "#size-cells"
> > 
> > else, false? But I'm also not sure what the benefit is of requiring
> > addr/size cells when the child node is not?
> The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
> arm64: dts: st: Add STM32MP2 USB support .

Right, but I was questioning why the properties describing the reg
property in children is required when the children (and thus the reg
property in them) were not made required.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]