Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@nabladev.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Christophe Roullier <christophe.roullier@foss.st.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>,
	Rob Herring <robh@kernel.org>,
	Yannick Fertre <yannick.fertre@foss.st.com>,
	devicetree@vger.kernel.org, kernel@dh-electronics.com,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells
Date: Tue, 1 Sep 2026 13:53:49 +0200	[thread overview]
Message-ID: <6d9d37d1-1f9e-4533-bfab-5a070c444a4a@nabladev.com> (raw)
In-Reply-To: <20260831-attentive-headpiece-c14d7d4086cb@spud>

On 8/31/26 9:56 PM, Conor Dooley wrote:
> On Mon, Aug 31, 2026 at 07:38:21PM +0200, Marek Vasut wrote:
>> On 8/31/26 7:13 PM, Conor Dooley wrote:
>>
>> Hello Conor,
>>
>>>>>>>>          then:
>>>>>>>>            required:
>>>>>>>>              - "#clock-cells"
>>>>>>>> +        - "#address-cells"
>>>>>>>> +        - "#size-cells"
>>>>>>>
>>>>>>> else, false? But I'm also not sure what the benefit is of requiring
>>>>>>> addr/size cells when the child node is not?
>>>>>> The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
>>>>>> arm64: dts: st: Add STM32MP2 USB support .
>>>>>
>>>>> Right, but I was questioning why the properties describing the reg
>>>>> property in children is required when the children (and thus the reg
>>>>> property in them) were not made required.
>>>>
>>>> Do you mean this patternProperties should be made required in here ?
>>>>
>>>> "
>>>> +patternProperties:
>>>> +  "^phy@[0-9a-f]+$":
>>>> "
>>>>
>>>> Could you please give me a hint how to do that ? git grep gives me nothing.
>>>
>>> I mean, if the phys aren't going to be required I would not make the
>>> cells properties required. I seem to recall a warning that dtbs_check
>>> can emit when there are size/addr cells properties in a node where there
>>> are no children, which is why I questioned this in the first place.
>>>
>>> Otherwise, if the phys are to be made required (no idea if they should
>>> be), I can only recall this being done with the non-pattern variant. IOW
>>> required:
>>>     - phy@0
>>>     - phy@1
>> The PHYs are part of the hardware and are (going to be) described in the SoC
>> DT, so I would argue they should be described as required ?
> 
> Yeah, and there's almost certainly no chance of them being required
> being problematic is there, since they don't impact existing code, but
> have a new (or at least a previously unused on this platform) driver.

I fixed that in V5, which I already sent yesterday.

Thank you for your help with this topic.


      reply	other threads:[~2026-09-01 11:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 15:11 [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells Marek Vasut
2026-08-28 15:11 ` [PATCH v4 2/2] soc: st: Add STM32MP2 SYSCFG driver Marek Vasut
2026-08-28 15:57 ` [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells Conor Dooley
2026-08-28 16:05   ` Marek Vasut
2026-08-31 15:05     ` Conor Dooley
2026-08-31 16:27       ` Marek Vasut
2026-08-31 17:13         ` Conor Dooley
2026-08-31 17:38           ` Marek Vasut
2026-08-31 19:56             ` Conor Dooley
2026-09-01 11:53               ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d9d37d1-1f9e-4533-bfab-5a070c444a4a@nabladev.com \
    --to=marex@nabladev.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=christophe.roullier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@dh-electronics.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=raphael.gallais-pou@foss.st.com \
    --cc=robh@kernel.org \
    --cc=yannick.fertre@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox