[PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Marek Vasut]

The st,stm32mp23-syscfg and st,stm32mp25-syscfg can have subnodes, which
represent the USB 2.0 FEMTO-PHY. Document subnodes pattern properties and
address/size cells.

Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Christophe Roullier <christophe.roullier@foss.st.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Marek Vasut <marex@nabladev.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Yannick Fertre <yannick.fertre@foss.st.com>
Cc: devicetree@vger.kernel.org
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
---
V2: New patch
V3: Fix the bindings
V4: - Undo simple-mfd in favor of dedicated SYSCFG SoC driver
    - Update commit message to match, this used to be patch
      dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd
    - Split this from series arm64: dts: phy: st: usb: Add STM32MP2 USB support
      https://lore.kernel.org/all/20260822074816.548662-1-marex@nabladev.com/
---
 .../bindings/arm/stm32/st,stm32-syscon.yaml     | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
index 95d2319afe235..d82afa39960b9 100644
--- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
@@ -39,6 +39,17 @@ properties:
   "#clock-cells":
     const: 0
 
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+patternProperties:
+  "^phy@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/phy/st,stm32-usb2phy.yaml
+
 required:
   - compatible
   - reg
@@ -57,10 +68,14 @@ allOf:
   - if:
       properties:
         compatible:
-          const: st,stm32mp25-syscfg
+          enum:
+            - st,stm32mp23-syscfg
+            - st,stm32mp25-syscfg
     then:
       required:
         - "#clock-cells"
+        - "#address-cells"
+        - "#size-cells"
 
 additionalProperties: false
 
-- 
2.53.0

[PATCH v4 2/2] soc: st: Add STM32MP2 SYSCFG driver

[Marek Vasut]

Add trivial SYSCFG driver for ST STM32MP25xx, which binds drivers
to its subnodes. This is currently used to bind USB PHY drivers to
subnodes described in the SYSCFG DT node.

Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Christophe Roullier <christophe.roullier@foss.st.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Marek Vasut <marex@nabladev.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Yannick Fertre <yannick.fertre@foss.st.com>
Cc: devicetree@vger.kernel.org
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
---
V4: New patch
---
 drivers/soc/Kconfig              |  1 +
 drivers/soc/Makefile             |  1 +
 drivers/soc/st/Kconfig           | 12 ++++++++++++
 drivers/soc/st/Makefile          |  1 +
 drivers/soc/st/stm32mp2-syscfg.c | 33 ++++++++++++++++++++++++++++++++
 5 files changed, 48 insertions(+)
 create mode 100644 drivers/soc/st/Kconfig
 create mode 100644 drivers/soc/st/Makefile
 create mode 100644 drivers/soc/st/stm32mp2-syscfg.c

diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
index a2d65adffb805..dfe5cec592626 100644
--- a/drivers/soc/Kconfig
+++ b/drivers/soc/Kconfig
@@ -24,6 +24,7 @@ source "drivers/soc/renesas/Kconfig"
 source "drivers/soc/rockchip/Kconfig"
 source "drivers/soc/samsung/Kconfig"
 source "drivers/soc/sophgo/Kconfig"
+source "drivers/soc/st/Kconfig"
 source "drivers/soc/sunxi/Kconfig"
 source "drivers/soc/tegra/Kconfig"
 source "drivers/soc/ti/Kconfig"
diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
index c9e689080ceb7..894bd6ebaaa4d 100644
--- a/drivers/soc/Makefile
+++ b/drivers/soc/Makefile
@@ -30,6 +30,7 @@ obj-y				+= renesas/
 obj-y				+= rockchip/
 obj-$(CONFIG_SOC_SAMSUNG)	+= samsung/
 obj-y				+= sophgo/
+obj-y				+= st/
 obj-y				+= sunxi/
 obj-$(CONFIG_ARCH_TEGRA)	+= tegra/
 obj-y				+= ti/
diff --git a/drivers/soc/st/Kconfig b/drivers/soc/st/Kconfig
new file mode 100644
index 0000000000000..2a9d6a77be450
--- /dev/null
+++ b/drivers/soc/st/Kconfig
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0-only
+menu "ST SoC drivers"
+
+config SOC_STM32MP2
+	tristate "STM32MP2 SoC family support"
+	depends on ARCH_STM32 || COMPILE_TEST
+	default ARCH_STM32 && ARM64
+	select SOC_BUS
+	help
+	  If you say yes here, you get support for the ST STM32MP2 family
+
+endmenu
diff --git a/drivers/soc/st/Makefile b/drivers/soc/st/Makefile
new file mode 100644
index 0000000000000..5ca313476ca93
--- /dev/null
+++ b/drivers/soc/st/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_SOC_STM32MP2) += stm32mp2-syscfg.o
diff --git a/drivers/soc/st/stm32mp2-syscfg.c b/drivers/soc/st/stm32mp2-syscfg.c
new file mode 100644
index 0000000000000..102430f258606
--- /dev/null
+++ b/drivers/soc/st/stm32mp2-syscfg.c
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2026 Marek Vasut
+ */
+
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+
+static int stm32mp2_syscfg_probe(struct platform_device *pdev)
+{
+	return devm_of_platform_populate(&pdev->dev);
+}
+
+static const struct of_device_id stm32mp2_syscfg_ids[] = {
+	{ .compatible = "st,stm32mp23-syscfg" },
+	{ .compatible = "st,stm32mp25-syscfg" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, stm32mp2_syscfg_ids);
+
+static struct platform_driver stm32mp2_syscfg_driver = {
+	.driver = {
+		.name	= "stm32mp2_syscfg",
+		.of_match_table = stm32mp2_syscfg_ids,
+	},
+	.probe = stm32mp2_syscfg_probe,
+};
+module_platform_driver(stm32mp2_syscfg_driver);
+
+MODULE_AUTHOR("Marek Vasut <marex@nabladev.com>");
+MODULE_DESCRIPTION("ST STM32MP2 SYSCFG driver");
+MODULE_LICENSE("GPL");
-- 
2.53.0

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2905 bytes --]

On Fri, Aug 28, 2026 at 05:11:14PM +0200, Marek Vasut wrote:
> The st,stm32mp23-syscfg and st,stm32mp25-syscfg can have subnodes, which
> represent the USB 2.0 FEMTO-PHY. Document subnodes pattern properties and
> address/size cells.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Christophe Roullier <christophe.roullier@foss.st.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Marek Vasut <marex@nabladev.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Yannick Fertre <yannick.fertre@foss.st.com>
> Cc: devicetree@vger.kernel.org
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> ---
> V2: New patch
> V3: Fix the bindings
> V4: - Undo simple-mfd in favor of dedicated SYSCFG SoC driver
>     - Update commit message to match, this used to be patch
>       dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd
>     - Split this from series arm64: dts: phy: st: usb: Add STM32MP2 USB support
>       https://lore.kernel.org/all/20260822074816.548662-1-marex@nabladev.com/
> ---
>  .../bindings/arm/stm32/st,stm32-syscon.yaml     | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> index 95d2319afe235..d82afa39960b9 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> @@ -39,6 +39,17 @@ properties:
>    "#clock-cells":
>      const: 0
>  
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +patternProperties:
> +  "^phy@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/phy/st,stm32-usb2phy.yaml
> +
>  required:
>    - compatible
>    - reg
> @@ -57,10 +68,14 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          const: st,stm32mp25-syscfg
> +          enum:
> +            - st,stm32mp23-syscfg
> +            - st,stm32mp25-syscfg

Sashiko comment here I believe is valid, the syntax here only works if
there's only the listed compatible present. It doesn't work with
fallbacks.

pw-bot: changes-requested

>      then:
>        required:
>          - "#clock-cells"
> +        - "#address-cells"
> +        - "#size-cells"

else, false? But I'm also not sure what the benefit is of requiring
addr/size cells when the child node is not?

Cheers,
Conor.

>  
>  additionalProperties: false
>  
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Marek Vasut]

On 8/28/26 5:57 PM, Conor Dooley wrote:

[...]

>> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> @@ -39,6 +39,17 @@ properties:
>>     "#clock-cells":
>>       const: 0
>>   
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    const: 1
>> +
>> +patternProperties:
>> +  "^phy@[0-9a-f]+$":
>> +    type: object
>> +    $ref: /schemas/phy/st,stm32-usb2phy.yaml
>> +
>>   required:
>>     - compatible
>>     - reg
>> @@ -57,10 +68,14 @@ allOf:
>>     - if:
>>         properties:
>>           compatible:
>> -          const: st,stm32mp25-syscfg
>> +          enum:
>> +            - st,stm32mp23-syscfg
>> +            - st,stm32mp25-syscfg
> 
> Sashiko comment here I believe is valid, the syntax here only works if
> there's only the listed compatible present. It doesn't work with
> fallbacks.

This syntax is used all over the place ?

Documentation/devicetree/bindings/ata/ahci-platform.yaml-allOf:
Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - $ref: 
ahci-common.yaml#
Documentation/devicetree/bindings/ata/ahci-platform.yaml-
Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - if:
Documentation/devicetree/bindings/ata/ahci-platform.yaml-      properties:
Documentation/devicetree/bindings/ata/ahci-platform.yaml-        compatible:
Documentation/devicetree/bindings/ata/ahci-platform.yaml:          contains:
Documentation/devicetree/bindings/ata/ahci-platform.yaml-            enum:
Documentation/devicetree/bindings/ata/ahci-platform.yaml-              - 
qcom,apq8064-ahci
Documentation/devicetree/bindings/ata/ahci-platform.yaml-              - 
qcom,ipq806x-ahci

> pw-bot: changes-requested
> 
>>       then:
>>         required:
>>           - "#clock-cells"
>> +        - "#address-cells"
>> +        - "#size-cells"
> 
> else, false? But I'm also not sure what the benefit is of requiring
> addr/size cells when the child node is not?
The subnodes of this syscfg node have reg property , see [PATCH v4 0/4] 
arm64: dts: st: Add STM32MP2 USB support .

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2651 bytes --]

On Fri, Aug 28, 2026 at 06:05:17PM +0200, Marek Vasut wrote:
> On 8/28/26 5:57 PM, Conor Dooley wrote:
> 
> [...]
> 
> > > +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> > > @@ -39,6 +39,17 @@ properties:
> > >     "#clock-cells":
> > >       const: 0
> > > +  "#address-cells":
> > > +    const: 1
> > > +
> > > +  "#size-cells":
> > > +    const: 1
> > > +
> > > +patternProperties:
> > > +  "^phy@[0-9a-f]+$":
> > > +    type: object
> > > +    $ref: /schemas/phy/st,stm32-usb2phy.yaml
> > > +
> > >   required:
> > >     - compatible
> > >     - reg
> > > @@ -57,10 +68,14 @@ allOf:
> > >     - if:
> > >         properties:
> > >           compatible:
> > > -          const: st,stm32mp25-syscfg
> > > +          enum:
> > > +            - st,stm32mp23-syscfg
> > > +            - st,stm32mp25-syscfg
> > 
> > Sashiko comment here I believe is valid, the syntax here only works if
> > there's only the listed compatible present. It doesn't work with
> > fallbacks.
> 
> This syntax is used all over the place ?
> 
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-allOf:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - $ref:
> ahci-common.yaml#
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - if:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-      properties:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-        compatible:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml:          contains:

                                                                     ^^^^^^^^
This is the key difference, you need "contains" for partial matches.

> Documentation/devicetree/bindings/ata/ahci-platform.yaml-            enum:
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> qcom,apq8064-ahci
> Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> qcom,ipq806x-ahci
> 
> > pw-bot: changes-requested
> > 
> > >       then:
> > >         required:
> > >           - "#clock-cells"
> > > +        - "#address-cells"
> > > +        - "#size-cells"
> > 
> > else, false? But I'm also not sure what the benefit is of requiring
> > addr/size cells when the child node is not?
> The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
> arm64: dts: st: Add STM32MP2 USB support .

Right, but I was questioning why the properties describing the reg
property in children is required when the children (and thus the reg
property in them) were not made required.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Marek Vasut]

On 8/31/26 5:05 PM, Conor Dooley wrote:

Hello Conor,

>>> Sashiko comment here I believe is valid, the syntax here only works if
>>> there's only the listed compatible present. It doesn't work with
>>> fallbacks.
>>
>> This syntax is used all over the place ?
>>
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-allOf:
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - $ref:
>> ahci-common.yaml#
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - if:
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-      properties:
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-        compatible:
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml:          contains:
> 
>                                                                       ^^^^^^^^
> This is the key difference, you need "contains" for partial matches.

Uh ... right ... fixed in V5. Thank you.

>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-            enum:
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
>> qcom,apq8064-ahci
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
>> qcom,ipq806x-ahci
>>
>>> pw-bot: changes-requested
>>>
>>>>        then:
>>>>          required:
>>>>            - "#clock-cells"
>>>> +        - "#address-cells"
>>>> +        - "#size-cells"
>>>
>>> else, false? But I'm also not sure what the benefit is of requiring
>>> addr/size cells when the child node is not?
>> The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
>> arm64: dts: st: Add STM32MP2 USB support .
> 
> Right, but I was questioning why the properties describing the reg
> property in children is required when the children (and thus the reg
> property in them) were not made required.

Do you mean this patternProperties should be made required in here ?

"
+patternProperties:
+  "^phy@[0-9a-f]+$":
"

Could you please give me a hint how to do that ? git grep gives me nothing.

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2828 bytes --]

On Mon, Aug 31, 2026 at 06:27:21PM +0200, Marek Vasut wrote:
> On 8/31/26 5:05 PM, Conor Dooley wrote:
> 
> Hello Conor,
> 
> > > > Sashiko comment here I believe is valid, the syntax here only works if
> > > > there's only the listed compatible present. It doesn't work with
> > > > fallbacks.
> > > 
> > > This syntax is used all over the place ?
> > > 
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-allOf:
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - $ref:
> > > ahci-common.yaml#
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-  - if:
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-      properties:
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-        compatible:
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml:          contains:
> > 
> >                                                                       ^^^^^^^^
> > This is the key difference, you need "contains" for partial matches.
> 
> Uh ... right ... fixed in V5. Thank you.
> 
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-            enum:
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> > > qcom,apq8064-ahci
> > > Documentation/devicetree/bindings/ata/ahci-platform.yaml-              -
> > > qcom,ipq806x-ahci
> > > 
> > > > pw-bot: changes-requested
> > > > 
> > > > >        then:
> > > > >          required:
> > > > >            - "#clock-cells"
> > > > > +        - "#address-cells"
> > > > > +        - "#size-cells"
> > > > 
> > > > else, false? But I'm also not sure what the benefit is of requiring
> > > > addr/size cells when the child node is not?
> > > The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
> > > arm64: dts: st: Add STM32MP2 USB support .
> > 
> > Right, but I was questioning why the properties describing the reg
> > property in children is required when the children (and thus the reg
> > property in them) were not made required.
> 
> Do you mean this patternProperties should be made required in here ?
> 
> "
> +patternProperties:
> +  "^phy@[0-9a-f]+$":
> "
> 
> Could you please give me a hint how to do that ? git grep gives me nothing.

I mean, if the phys aren't going to be required I would not make the
cells properties required. I seem to recall a warning that dtbs_check
can emit when there are size/addr cells properties in a node where there
are no children, which is why I questioned this in the first place.

Otherwise, if the phys are to be made required (no idea if they should
be), I can only recall this being done with the non-pattern variant. IOW
required:
  - phy@0
  - phy@1

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Marek Vasut]

On 8/31/26 7:13 PM, Conor Dooley wrote:

Hello Conor,

>>>>>>         then:
>>>>>>           required:
>>>>>>             - "#clock-cells"
>>>>>> +        - "#address-cells"
>>>>>> +        - "#size-cells"
>>>>>
>>>>> else, false? But I'm also not sure what the benefit is of requiring
>>>>> addr/size cells when the child node is not?
>>>> The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
>>>> arm64: dts: st: Add STM32MP2 USB support .
>>>
>>> Right, but I was questioning why the properties describing the reg
>>> property in children is required when the children (and thus the reg
>>> property in them) were not made required.
>>
>> Do you mean this patternProperties should be made required in here ?
>>
>> "
>> +patternProperties:
>> +  "^phy@[0-9a-f]+$":
>> "
>>
>> Could you please give me a hint how to do that ? git grep gives me nothing.
> 
> I mean, if the phys aren't going to be required I would not make the
> cells properties required. I seem to recall a warning that dtbs_check
> can emit when there are size/addr cells properties in a node where there
> are no children, which is why I questioned this in the first place.
> 
> Otherwise, if the phys are to be made required (no idea if they should
> be), I can only recall this being done with the non-pattern variant. IOW
> required:
>    - phy@0
>    - phy@1
The PHYs are part of the hardware and are (going to be) described in the 
SoC DT, so I would argue they should be described as required ?

Thank you for your help with this !

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1951 bytes --]

On Mon, Aug 31, 2026 at 07:38:21PM +0200, Marek Vasut wrote:
> On 8/31/26 7:13 PM, Conor Dooley wrote:
> 
> Hello Conor,
> 
> > > > > > >         then:
> > > > > > >           required:
> > > > > > >             - "#clock-cells"
> > > > > > > +        - "#address-cells"
> > > > > > > +        - "#size-cells"
> > > > > > 
> > > > > > else, false? But I'm also not sure what the benefit is of requiring
> > > > > > addr/size cells when the child node is not?
> > > > > The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
> > > > > arm64: dts: st: Add STM32MP2 USB support .
> > > > 
> > > > Right, but I was questioning why the properties describing the reg
> > > > property in children is required when the children (and thus the reg
> > > > property in them) were not made required.
> > > 
> > > Do you mean this patternProperties should be made required in here ?
> > > 
> > > "
> > > +patternProperties:
> > > +  "^phy@[0-9a-f]+$":
> > > "
> > > 
> > > Could you please give me a hint how to do that ? git grep gives me nothing.
> > 
> > I mean, if the phys aren't going to be required I would not make the
> > cells properties required. I seem to recall a warning that dtbs_check
> > can emit when there are size/addr cells properties in a node where there
> > are no children, which is why I questioned this in the first place.
> > 
> > Otherwise, if the phys are to be made required (no idea if they should
> > be), I can only recall this being done with the non-pattern variant. IOW
> > required:
> >    - phy@0
> >    - phy@1
> The PHYs are part of the hardware and are (going to be) described in the SoC
> DT, so I would argue they should be described as required ?

Yeah, and there's almost certainly no chance of them being required
being problematic is there, since they don't impact existing code, but
have a new (or at least a previously unused on this platform) driver.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Marek Vasut]

On 8/31/26 9:56 PM, Conor Dooley wrote:
> On Mon, Aug 31, 2026 at 07:38:21PM +0200, Marek Vasut wrote:
>> On 8/31/26 7:13 PM, Conor Dooley wrote:
>>
>> Hello Conor,
>>
>>>>>>>>          then:
>>>>>>>>            required:
>>>>>>>>              - "#clock-cells"
>>>>>>>> +        - "#address-cells"
>>>>>>>> +        - "#size-cells"
>>>>>>>
>>>>>>> else, false? But I'm also not sure what the benefit is of requiring
>>>>>>> addr/size cells when the child node is not?
>>>>>> The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
>>>>>> arm64: dts: st: Add STM32MP2 USB support .
>>>>>
>>>>> Right, but I was questioning why the properties describing the reg
>>>>> property in children is required when the children (and thus the reg
>>>>> property in them) were not made required.
>>>>
>>>> Do you mean this patternProperties should be made required in here ?
>>>>
>>>> "
>>>> +patternProperties:
>>>> +  "^phy@[0-9a-f]+$":
>>>> "
>>>>
>>>> Could you please give me a hint how to do that ? git grep gives me nothing.
>>>
>>> I mean, if the phys aren't going to be required I would not make the
>>> cells properties required. I seem to recall a warning that dtbs_check
>>> can emit when there are size/addr cells properties in a node where there
>>> are no children, which is why I questioned this in the first place.
>>>
>>> Otherwise, if the phys are to be made required (no idea if they should
>>> be), I can only recall this being done with the non-pattern variant. IOW
>>> required:
>>>     - phy@0
>>>     - phy@1
>> The PHYs are part of the hardware and are (going to be) described in the SoC
>> DT, so I would argue they should be described as required ?
> 
> Yeah, and there's almost certainly no chance of them being required
> being problematic is there, since they don't impact existing code, but
> have a new (or at least a previously unused on this platform) driver.

I fixed that in V5, which I already sent yesterday.

Thank you for your help with this topic.