[PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[Alexander Stein]

'ahci:' is an invalid prefix, preventing the module from autoloading.
Fix this by using the 'platform:' prefix and DRV_NAME.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/ata/ahci_imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
index b734e069034d..632caa301458 100644
--- a/drivers/ata/ahci_imx.c
+++ b/drivers/ata/ahci_imx.c
@@ -1235,4 +1235,4 @@ module_platform_driver(imx_ahci_driver);
 MODULE_DESCRIPTION("Freescale i.MX AHCI SATA platform driver");
 MODULE_AUTHOR("Richard Zhu <Hong-Xing.Zhu@freescale.com>");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("ahci:imx");
+MODULE_ALIAS("platform:" DRV_NAME);
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[Fabio Estevam]

Hi Alexander,

On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> 'ahci:' is an invalid prefix, preventing the module from autoloading.
> Fix this by using the 'platform:' prefix and DRV_NAME.

What about adding a Fixes tag?

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[Alexander Stein]

Hello Fabio,

Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
> Hi Alexander,
> 
> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
> 
> <alexander.stein@ew.tq-group.com> wrote:
> > 'ahci:' is an invalid prefix, preventing the module from autoloading.
> > Fix this by using the 'platform:' prefix and DRV_NAME.
> 
> What about adding a Fixes tag?
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at 
which point auto loading stopped working (if it did at all).

Best regards,
Alexander




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[Damien Le Moal]

On 10/12/22 22:30, Alexander Stein wrote:
> Hello Fabio,
> 
> Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
>> Hi Alexander,
>>
>> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
>>
>> <alexander.stein@ew.tq-group.com> wrote:
>>> 'ahci:' is an invalid prefix, preventing the module from autoloading.
>>> Fix this by using the 'platform:' prefix and DRV_NAME.
>>
>> What about adding a Fixes tag?
>>
>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 
> Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at 
> which point auto loading stopped working (if it did at all).

Given that the alias was wrong in the first place when added for a
platform driver, this I think should be a fix for:

9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms")

I can add the Fixes tag when applying.

> 
> Best regards,
> Alexander
> 
> 
> 

-- 
Damien Le Moal
Western Digital Research


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[Alexander Stein]

Hello Damien,

Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal:
> On 10/12/22 22:30, Alexander Stein wrote:
> > Hello Fabio,
> > 
> > Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
> >> Hi Alexander,
> >> 
> >> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
> >> 
> >> <alexander.stein@ew.tq-group.com> wrote:
> >>> 'ahci:' is an invalid prefix, preventing the module from autoloading.
> >>> Fix this by using the 'platform:' prefix and DRV_NAME.
> >> 
> >> What about adding a Fixes tag?
> >> 
> >> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > 
> > Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at
> > which point auto loading stopped working (if it did at all).
> 
> Given that the alias was wrong in the first place when added for a
> platform driver, this I think should be a fix for:
> 
> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms")

I was hesitating tagging the very first commit, not knowing if it did work at 
that time. But it seems reasonable.

> I can add the Fixes tag when applying.

Thanks!

Best regards,
Alexander



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[Damien Le Moal]

On 10/13/22 14:55, Alexander Stein wrote:
> Hello Damien,
> 
> Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal:
>> On 10/12/22 22:30, Alexander Stein wrote:
>>> Hello Fabio,
>>>
>>> Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam:
>>>> Hi Alexander,
>>>>
>>>> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein
>>>>
>>>> <alexander.stein@ew.tq-group.com> wrote:
>>>>> 'ahci:' is an invalid prefix, preventing the module from autoloading.
>>>>> Fix this by using the 'platform:' prefix and DRV_NAME.
>>>>
>>>> What about adding a Fixes tag?
>>>>
>>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>>
>>> Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at
>>> which point auto loading stopped working (if it did at all).
>>
>> Given that the alias was wrong in the first place when added for a
>> platform driver, this I think should be a fix for:
>>
>> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms")
> 
> I was hesitating tagging the very first commit, not knowing if it did work at 
> that time. But it seems reasonable.

Yep, I do not think this will hurt...
If someone think I am wrong, please scream !

> 
>> I can add the Fixes tag when applying.
> 
> Thanks!
> 
> Best regards,
> Alexander
> 
> 

-- 
Damien Le Moal
Western Digital Research


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS

[Damien Le Moal]

On 10/12/22 22:11, Alexander Stein wrote:
> 'ahci:' is an invalid prefix, preventing the module from autoloading.
> Fix this by using the 'platform:' prefix and DRV_NAME.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/ata/ahci_imx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
> index b734e069034d..632caa301458 100644
> --- a/drivers/ata/ahci_imx.c
> +++ b/drivers/ata/ahci_imx.c
> @@ -1235,4 +1235,4 @@ module_platform_driver(imx_ahci_driver);
>  MODULE_DESCRIPTION("Freescale i.MX AHCI SATA platform driver");
>  MODULE_AUTHOR("Richard Zhu <Hong-Xing.Zhu@freescale.com>");
>  MODULE_LICENSE("GPL");
> -MODULE_ALIAS("ahci:imx");
> +MODULE_ALIAS("platform:" DRV_NAME);

Applied to for-6.1-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel