* arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6)
@ 2020-03-17 23:15 kernelci.org bot
2020-03-18 8:28 ` Will Deacon
0 siblings, 1 reply; 6+ messages in thread
From: kernelci.org bot @ 2020-03-17 23:15 UTC (permalink / raw)
To: will, catalin.marinas, linux-arm-kernel, kernel-build-reports
arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6)
Full Build Summary: https://kernelci.org/build/arm64/branch/for-kernelci/kernel/v5.6-rc6-67-gcf89e8c383a6/
Tree: arm64
Branch: for-kernelci
Git Describe: v5.6-rc6-67-gcf89e8c383a6
Git Commit: cf89e8c383a6447a635400f669d0cd97e89770d9
Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
Built: 1 unique architecture
Build Failure Detected:
arm64:
allnoconfig: (gcc-8) FAIL
Errors Detected:
arm64:
allnoconfig (gcc-8): 1 error
Errors summary:
1 include/linux/elf.h:79:19: error: redefinition of ‘arch_parse_elf_property’
================================================================================
Detailed per-defconfig build reports:
--------------------------------------------------------------------------------
allmodconfig (arm64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches
--------------------------------------------------------------------------------
allnoconfig (arm64, gcc-8) — FAIL, 1 error, 0 warnings, 0 section mismatches
Errors:
include/linux/elf.h:79:19: error: redefinition of ‘arch_parse_elf_property’
--------------------------------------------------------------------------------
defconfig (arm64, gcc-8) — PASS, 0 errors, 0 warnings, 0 section mismatches
---
For more info write to <info@kernelci.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) 2020-03-17 23:15 arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) kernelci.org bot @ 2020-03-18 8:28 ` Will Deacon 2020-03-18 12:06 ` Catalin Marinas 0 siblings, 1 reply; 6+ messages in thread From: Will Deacon @ 2020-03-18 8:28 UTC (permalink / raw) To: kernelci.org bot; +Cc: catalin.marinas, linux-arm-kernel, kernel-build-reports On Tue, Mar 17, 2020 at 04:15:44PM -0700, kernelci.org bot wrote: > arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) > > Full Build Summary: https://kernelci.org/build/arm64/branch/for-kernelci/kernel/v5.6-rc6-67-gcf89e8c383a6/ > > Tree: arm64 > Branch: for-kernelci > Git Describe: v5.6-rc6-67-gcf89e8c383a6 > Git Commit: cf89e8c383a6447a635400f669d0cd97e89770d9 > Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > Built: 1 unique architecture > > Build Failure Detected: > > arm64: > allnoconfig: (gcc-8) FAIL > > Errors Detected: > > arm64: > allnoconfig (gcc-8): 1 error Looks like this is easily fixed as per below. Will --->8 diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index d65d226a77ec..53c77711f752 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -64,7 +64,7 @@ config ARM64 select ARCH_INLINE_SPIN_UNLOCK_IRQRESTORE if !PREEMPTION select ARCH_KEEP_MEMBLOCK select ARCH_USE_CMPXCHG_LOCKREF - select ARCH_USE_GNU_PROPERTY if BINFMT_ELF + select ARCH_USE_GNU_PROPERTY select ARCH_USE_QUEUED_RWLOCKS select ARCH_USE_QUEUED_SPINLOCKS select ARCH_SUPPORTS_MEMORY_FAILURE _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) 2020-03-18 8:28 ` Will Deacon @ 2020-03-18 12:06 ` Catalin Marinas 2020-03-18 12:16 ` Mark Brown 0 siblings, 1 reply; 6+ messages in thread From: Catalin Marinas @ 2020-03-18 12:06 UTC (permalink / raw) To: Will Deacon Cc: Mark Brown, linux-arm-kernel, kernelci.org bot, kernel-build-reports On Wed, Mar 18, 2020 at 08:28:31AM +0000, Will Deacon wrote: > On Tue, Mar 17, 2020 at 04:15:44PM -0700, kernelci.org bot wrote: > > arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) > > > > Full Build Summary: https://kernelci.org/build/arm64/branch/for-kernelci/kernel/v5.6-rc6-67-gcf89e8c383a6/ > > > > Tree: arm64 > > Branch: for-kernelci > > Git Describe: v5.6-rc6-67-gcf89e8c383a6 > > Git Commit: cf89e8c383a6447a635400f669d0cd97e89770d9 > > Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > > Built: 1 unique architecture > > > > Build Failure Detected: > > > > arm64: > > allnoconfig: (gcc-8) FAIL > > > > Errors Detected: > > > > arm64: > > allnoconfig (gcc-8): 1 error > > Looks like this is easily fixed as per below. > > Will > > --->8 > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index d65d226a77ec..53c77711f752 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -64,7 +64,7 @@ config ARM64 > select ARCH_INLINE_SPIN_UNLOCK_IRQRESTORE if !PREEMPTION > select ARCH_KEEP_MEMBLOCK > select ARCH_USE_CMPXCHG_LOCKREF > - select ARCH_USE_GNU_PROPERTY if BINFMT_ELF > + select ARCH_USE_GNU_PROPERTY > select ARCH_USE_QUEUED_RWLOCKS > select ARCH_USE_QUEUED_SPINLOCKS > select ARCH_SUPPORTS_MEMORY_FAILURE If ARCH_USE_GNU_PROPERTY is specific to ELF only, I'd rather not select it unconditionally (and the option should probably depend on BINFMT_ELF). Following the pattern of ARCH_HAVE_EXTRA_ELF_NOTES, we could fix it up as below: diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h index 4f00d50585a4..2eef3672de50 100644 --- a/arch/arm64/include/asm/elf.h +++ b/arch/arm64/include/asm/elf.h @@ -238,6 +238,7 @@ struct arch_elf_state { .flags = 0, \ } +#ifdef CONFIG_ARCH_USE_GNU_PROPERTY static inline int arch_parse_elf_property(u32 type, const void *data, size_t datasz, bool compat, struct arch_elf_state *arch) @@ -259,6 +260,7 @@ static inline int arch_parse_elf_property(u32 type, const void *data, return 0; } +#endif static inline int arch_elf_pt_proc(void *ehdr, void *phdr, struct file *f, bool is_interp, -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) 2020-03-18 12:06 ` Catalin Marinas @ 2020-03-18 12:16 ` Mark Brown 2020-03-18 12:23 ` Catalin Marinas 0 siblings, 1 reply; 6+ messages in thread From: Mark Brown @ 2020-03-18 12:16 UTC (permalink / raw) To: Catalin Marinas Cc: Will Deacon, linux-arm-kernel, kernelci.org bot, kernel-build-reports [-- Attachment #1.1: Type: text/plain, Size: 836 bytes --] On Wed, Mar 18, 2020 at 12:06:14PM +0000, Catalin Marinas wrote: > If ARCH_USE_GNU_PROPERTY is specific to ELF only, I'd rather not select > it unconditionally (and the option should probably depend on > BINFMT_ELF). Following the pattern of ARCH_HAVE_EXTRA_ELF_NOTES, we > could fix it up as below: > > diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h > index 4f00d50585a4..2eef3672de50 100644 > --- a/arch/arm64/include/asm/elf.h > +++ b/arch/arm64/include/asm/elf.h > @@ -238,6 +238,7 @@ struct arch_elf_state { > .flags = 0, \ > } > > +#ifdef CONFIG_ARCH_USE_GNU_PROPERTY That makes sense to me. > +#endif > > static inline int arch_elf_pt_proc(void *ehdr, void *phdr, > struct file *f, bool is_interp, Though presumably this is all eventually dead code too? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) 2020-03-18 12:16 ` Mark Brown @ 2020-03-18 12:23 ` Catalin Marinas 2020-03-18 12:26 ` Mark Brown 0 siblings, 1 reply; 6+ messages in thread From: Catalin Marinas @ 2020-03-18 12:23 UTC (permalink / raw) To: Mark Brown Cc: Will Deacon, linux-arm-kernel, kernelci.org bot, kernel-build-reports On Wed, Mar 18, 2020 at 12:16:27PM +0000, Mark Brown wrote: > On Wed, Mar 18, 2020 at 12:06:14PM +0000, Catalin Marinas wrote: > > > If ARCH_USE_GNU_PROPERTY is specific to ELF only, I'd rather not select > > it unconditionally (and the option should probably depend on > > BINFMT_ELF). Following the pattern of ARCH_HAVE_EXTRA_ELF_NOTES, we > > could fix it up as below: > > > > diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h > > index 4f00d50585a4..2eef3672de50 100644 > > --- a/arch/arm64/include/asm/elf.h > > +++ b/arch/arm64/include/asm/elf.h > > @@ -238,6 +238,7 @@ struct arch_elf_state { > > .flags = 0, \ > > } > > > > +#ifdef CONFIG_ARCH_USE_GNU_PROPERTY > > That makes sense to me. > > > +#endif > > > > static inline int arch_elf_pt_proc(void *ehdr, void *phdr, > > struct file *f, bool is_interp, > > Though presumably this is all eventually dead code too? I'll let you pick one ;), I don't have a strong preference either way. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) 2020-03-18 12:23 ` Catalin Marinas @ 2020-03-18 12:26 ` Mark Brown 0 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2020-03-18 12:26 UTC (permalink / raw) To: Catalin Marinas Cc: Will Deacon, linux-arm-kernel, kernelci.org bot, kernel-build-reports [-- Attachment #1.1: Type: text/plain, Size: 179 bytes --] On Wed, Mar 18, 2020 at 12:23:04PM +0000, Catalin Marinas wrote: > I'll let you pick one ;), I don't have a strong preference either way. I don't really care either way either. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-18 12:26 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-17 23:15 arm64/for-kernelci build: 3 builds: 1 failed, 2 passed, 1 error (v5.6-rc6-67-gcf89e8c383a6) kernelci.org bot 2020-03-18 8:28 ` Will Deacon 2020-03-18 12:06 ` Catalin Marinas 2020-03-18 12:16 ` Mark Brown 2020-03-18 12:23 ` Catalin Marinas 2020-03-18 12:26 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox