Re: [RFC PATCH v2 00/45] arm64: Add support for FEAT_NMI

[Ashok Raj <ashok.raj@oss.qualcomm.com>]

On Fri, Aug 21, 2026 at 02:03:07PM +0100, Vladimir Murzin wrote:
> On 8/14/26 02:52, Jinjie Ruan wrote:
> > 
> >> With this restructuring in place, wiring FEAT_NMI into the new
> >> framework becomes much more manageable.
> >>
> >> This work would not have been possible without the contributions of
> >> Ada Couprie Diaz, Mark Brown, and Lorenzo Pieralisi - please credit
> >> them for everything that works well. Any remaining bugs or issues are
> >> entirely my own.

Spoken like a true leader :-)

> >>
> >> I'd especially appreciate feedback on the overall approach. Please
> >> don't hesitate to bikeshed the naming or other details - improving
> >> clarity is one of the main goals of this series. Of course, technical
> >> review is more than welcome as well.

I started reviewing the series as well, and apart from some minor things
nothing major stands out at this time. But I'll do more with my testing
and if anything pops up you will hear.

> >>
> >> The series would also benefit from extensive testing on real hardware
> >> (without NMI, with pseudo-NMI, and with FEAT_NMI), as most of the
> >> testing so far has been done on QEMU and Fast Model.
> 

I'm also starting with QEMU!. just doing virt I suppose, do we have
sbsa-ref model as well working? just wanted to check, I was thinking
about it for another use case.


-- 
/ashok.raj
ashok.raj@oss.qualcomm.com
Qualcomm Inc