Re: [RFC PATCH v7 11/28] KVM: arm64: Add a new VCPU device control group for SPE

["Lorenzo Stoakes (ARM)" <ljs@kernel.org>]

On Thu, Sep 03, 2026 at 05:06:06PM +0100, Alexandru Elisei wrote:
> From: Sudeep Holla <sudeep.holla@arm.com>
>
> Add a new VCPU device control group to control various aspects of KVM's SPE
> emulation. Functionality will be added in later patches.

Again fairly thin commit message, be useful to provide more details.

I'd also explicitly say you're adding stubs and the foundations for this but the
actual implementation isn't in place yet.

>
> [ Alexandru E: Major rework ]

Generally [] stuff is for small fixups done to a patch, so a major rework isn't
really suited to this form.

The done thing for this kind of thing I think is something like:

Co-developed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>

Note that you require Sudeep's explicit permission to do this though! :)

>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>

Overall this looks obviously correct (TM), so with the commit message +
authorship stuff addressed:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

--
Cheers, Lorenzo