Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: maz@kernel.org, oupton@kernel.org, fuad.tabba@linux.dev,
	 joey.gouly@arm.com, seiden@linux.ibm.com,
	suzuki.poulose@arm.com,  yuzenghui@huawei.com,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	 will@kernel.org, mark.rutland@arm.com,
	linux-perf-users@vger.kernel.org,  catalin.marinas@arm.com,
	james.clark@linaro.org
Subject: Re: [RFC PATCH v7 05/28] perf: arm_spe_pmu: Add PMBIDR_EL1 and PMSIDR_EL1 to struct arm_spe_pmu
Date: Mon, 16 Nov 2026 17:56:28 +0000	[thread overview]
Message-ID: <avtDK5rtD38jnhqR@gremlin> (raw)
In-Reply-To: <avSjyLhFsYjI7tG_@raptor>

On Wed, Nov 11, 2026 at 05:20:08PM +0000, Alexandru Elisei wrote:
> Hi,
>
> On Thu, Oct 15, 2026 at 04:12:27PM +0100, Lorenzo Stoakes (ARM) wrote:
> > I think probably some kind of commit message would be good even for a
> > trivial change :)
>
> Of course, I'll add something here.
>
> >
> > On Thu, Sep 03, 2026 at 05:06:00PM +0100, Alexandru Elisei wrote:
> > > Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
> > > ---
> > >  drivers/perf/arm_spe_pmu.c       | 3 +++
> > >  include/linux/perf/arm_spe_pmu.h | 2 ++
> > >  2 files changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
> > > index 79c571a649d5..42ba0924bd02 100644
> > > --- a/drivers/perf/arm_spe_pmu.c
> > > +++ b/drivers/perf/arm_spe_pmu.c
> > > @@ -1095,6 +1095,7 @@ static void __arm_spe_pmu_dev_probe(void *info)
> > >  			"profiling buffer owned by higher exception level\n");
> > >  		return;
> > >  	}
> > > +	spe_pmu->pmbidr_el1 = reg;
> >
> > This doesn't seem to be used anywhere in the series?
>
> Indeed, that's a leftover from the previous iterations, will remove.
>
> >
> > >
> > >  	/* Minimum alignment. If it's out-of-range, then fail the probe */
> > >  	fld = FIELD_GET(PMBIDR_EL1_ALIGN, reg);
> > > @@ -1107,6 +1108,8 @@ static void __arm_spe_pmu_dev_probe(void *info)
> > >
> > >  	/* It's now safe to read PMSIDR and figure out what we've got */
> > >  	reg = read_sysreg_s(SYS_PMSIDR_EL1);
> > > +	spe_pmu->pmsidr_el1 = reg;
> > > +
> > >  	if (FIELD_GET(PMSIDR_EL1_FE, reg))
> > >  		spe_pmu->features |= SPE_PMU_FEAT_FILT_EVT;
> > >
> > > diff --git a/include/linux/perf/arm_spe_pmu.h b/include/linux/perf/arm_spe_pmu.h
> > > index af86fd184050..97b14e236fcd 100644
> > > --- a/include/linux/perf/arm_spe_pmu.h
> > > +++ b/include/linux/perf/arm_spe_pmu.h
> > > @@ -21,6 +21,8 @@ struct arm_spe_pmu {
> > >  	cpumask_t				supported_cpus;
> > >  	struct hlist_node			hotplug_node;
> > >
> > > +	u64					pmbidr_el1;
> >
> > Equally, this doesn't seem to be used anywhere in the series, maybe drop?
>
> Fixed.
>
> >
> > > +	u64					pmsidr_el1;
> >
> > This field is used in kvm_spe_has_feat_spe_fds() and
> > kvm_spe_has_feat_spe_fne():
> >
> > bool kvm_spe_has_feat_spe_fds(struct kvm *kvm)
> > {
> > 	...
> > 	return kvm_has_feat(kvm, ID_AA64DFR0_EL1, PMSVer, V1P4) &&
> > 	       FIELD_GET(PMSIDR_EL1_FDS, spe_pmu->pmsidr_el1);
> > }
> >
> > bool kvm_spe_has_feat_spe_fne(struct kvm *kvm)
> > {
> > 	...
> > 	return kvm_has_feat(kvm, ID_AA64DFR0_EL1, PMSVer, V1P2) &&
> > 	       FIELD_GET(PMSIDR_EL1_FnE, spe_pmu->pmsidr_el1);
> > }
> >
> > So checking for FDS and FnE, but these are available as feature flags as
> > __arm_spe_pmu_dev_probe() gets these:
> >
> > static void __arm_spe_pmu_dev_probe(void *info)
> > {
> > 	...
> > 	if (FIELD_GET(PMSIDR_EL1_FnE, reg))
> > 		spe_pmu->features |= SPE_PMU_FEAT_INV_FILT_EVT;
> > 	...
> > 	if (FIELD_GET(PMSIDR_EL1_FDS, reg))
> > 		spe_pmu->features |= SPE_PMU_FEAT_FDS;
> > 	...
> > }
> >
> > And then kvm_spe_has_feat_spe_fds() and kvm_spe_has_feat_spe_fne() can be:
> >
> > bool kvm_spe_has_feat_spe_fds(struct kvm *kvm)
> > {
> > 	...
> > 	return kvm_has_feat(kvm, ID_AA64DFR0_EL1, PMSVer, V1P4) &&
> > 	       (spe_pmu->features & SPE_PMU_FEAT_FDS);
> > }
> >
> > bool kvm_spe_has_feat_spe_fne(struct kvm *kvm)
> > {
> > 	...
> > 	return kvm_has_feat(kvm, ID_AA64DFR0_EL1, PMSVer, V1P2) &&
> > 	       (spe_pmu->features & SPE_PMU_FEAT_INV_FILT_EVT);
> > }
> >
> > Right?
>
> In this use case they are functionally the same, yes, but conceptually, they are
> not the same thing. spe_pmu->features advertises the features that the SPE
> *driver* supports, PMSIDR_EL1 advertises the features that the *hardware*
> implements. The two are not always equal.  For example, KVM added handling for
> the PMSNEVFR_EL1 register (added by FEAT_SPE_FnE), a few years before the SPE
> driver supported FEAT_SPE_FnE.
>
> I can see KVM, in the future, having to virtualize hardware features not
> supported by the host driver yet, so unless you have a strong objection, I would
> rather keep the use of the architectural register instead of relying on the
> driver.

Ack OK, sounds sensible, no strong objection but could you add a sentence to the
commit msg about that? Thanks! :)

>
> >
> > So it seems you could drop this patch from the series in general? Is there
> > another reason to get these fields?
> >
> > Also - there seems to be a divergence in the naming there between FnE and
> > INV_FILT_EVT, is that intentional?
>
> I think that's a question for the person who added FEAT_PMU_FEAT_INV_FILT_EVT?

Haha true I suppose so.

>
> Thanks,
> Alex

--
Cheers, Lorenzo


  reply	other threads:[~2026-11-16 17:56 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 16:05 [RFC PATCH v7 00/28] KVM: arm64: Add Statistical Profiling Extension (SPE) support Alexandru Elisei
2026-09-03 16:05 ` [RFC PATCH v7 01/28] arm64/sysreg: Add the nVM field to PMBLIMITR_EL1 Alexandru Elisei
2026-10-15 13:23   ` Lorenzo Stoakes (ARM)
2026-09-03 16:05 ` [RFC PATCH v7 02/28] arm64/sysreg: Define MDCR_EL2.E2PB values Alexandru Elisei
2026-10-15 13:52   ` Lorenzo Stoakes (ARM)
2026-11-11 17:14     ` Alexandru Elisei
2026-11-16 18:00       ` Lorenzo Stoakes (ARM)
2026-09-03 16:05 ` [RFC PATCH v7 03/28] KVM: arm64: Add CONFIG_KVM_ARM_SPE Kconfig option Alexandru Elisei
2026-10-15 14:15   ` Lorenzo Stoakes (ARM)
2026-11-11 17:16     ` Alexandru Elisei
2026-11-16 18:00       ` Lorenzo Stoakes (ARM)
2026-09-03 16:05 ` [RFC PATCH v7 04/28] perf: arm_spe_pmu: Move struct arm_spe_pmu to a separate header file Alexandru Elisei
2026-10-15 14:40   ` Lorenzo Stoakes (ARM)
2026-11-11 17:17     ` Alexandru Elisei
2026-11-16 18:03       ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 05/28] perf: arm_spe_pmu: Add PMBIDR_EL1 and PMSIDR_EL1 to struct arm_spe_pmu Alexandru Elisei
2026-10-15 15:12   ` Lorenzo Stoakes (ARM)
2026-11-11 17:20     ` Alexandru Elisei
2026-11-16 17:56       ` Lorenzo Stoakes (ARM) [this message]
2026-09-03 16:06 ` [RFC PATCH v7 06/28] KVM: arm64: Add KVM_CAP_ARM_SPE capability Alexandru Elisei
2026-10-15 16:51   ` Lorenzo Stoakes (ARM)
2026-11-12 15:34     ` Alexandru Elisei
2026-11-12 16:13       ` Alexandru Elisei
2026-09-03 16:06 ` [RFC PATCH v7 07/28] KVM: arm64: Add KVM_ARM_VCPU_SPE VCPU feature Alexandru Elisei
2026-10-16 14:23   ` Lorenzo Stoakes (ARM)
2026-11-12 17:18     ` Alexandru Elisei
2026-11-16 17:59       ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 08/28] HACK! KVM: arm64: Disable SPE virtualization if protected KVM is enabled Alexandru Elisei
2026-10-16 14:30   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 09/28] HACK! KVM: arm64: Enable SPE virtualization only in VHE mode Alexandru Elisei
2026-09-03 16:06 ` [RFC PATCH v7 10/28] HACK! KVM: arm64: Disable SPE virtualization if nested virt is enabled Alexandru Elisei
2026-09-03 16:06 ` [RFC PATCH v7 11/28] KVM: arm64: Add a new VCPU device control group for SPE Alexandru Elisei
2026-10-16 14:44   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 12/28] KVM: arm64: Add SPE VCPU device attribute to set the interrupt number Alexandru Elisei
2026-10-20 17:20   ` Lorenzo Stoakes (ARM)
2026-10-28 16:52   ` Suzuki K Poulose
2026-09-03 16:06 ` [RFC PATCH v7 13/28] KVM: arm64: Add SPE VCPU device attribute to set the SPE device Alexandru Elisei
2026-10-28 13:11   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 14/28] KVM: arm64: Add SPE VCPU device attribute to initialize SPE Alexandru Elisei
2026-10-28 13:45   ` Lorenzo Stoakes (ARM)
2026-10-29 18:03   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 15/28] KVM: arm64: Use PMSVer from the assigned SPE instance Alexandru Elisei
2026-10-28 16:41   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 16/28] KVM: arm64: Add SPE system registers to VCPU context Alexandru Elisei
2026-10-29 15:42   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 17/28] KVM: arm64: Apply a RES0 mask to PMBLIMITR_EL1 writes Alexandru Elisei
2026-10-29 17:23   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 18/28] KVM: arm64: config: Use functions from spe.c to test FEAT_SPE_{FnE,FDS} Alexandru Elisei
2026-10-29 17:47   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 19/28] KVM: arm64: VHE: Context switch SPE state Alexandru Elisei
2026-11-03 16:00   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 20/28] KVM: arm64: Allow guest SPE physical timestamps only if kernel allows it Alexandru Elisei
2026-11-03 17:04   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 21/28] KVM: arm64: Handle SPE maintenance interrupts Alexandru Elisei
2026-11-05 16:05   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 22/28] arm64: errata: Disable SPE in KVM Alexandru Elisei
2026-11-03 20:12   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 23/28] KVM: arm64: Add kvm-arm.ignore_spe_errata kernel parameter Alexandru Elisei
2026-11-03 19:37   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 24/28] arm64: errata: Don't enable guest buffer if misprogrammed Alexandru Elisei
2026-11-05 16:51   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 25/28] KVM: arm64: at: Use callback for reading descriptor Alexandru Elisei
2026-11-03 19:55   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 26/28] KVM: arm64: Map memory on a SPE stage 2 fault Alexandru Elisei
2026-11-05 17:10   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 27/28] KVM: arm64: Handle dirty page logging when SPE feature is set Alexandru Elisei
2026-11-05 17:35   ` Lorenzo Stoakes (ARM)
2026-09-03 16:06 ` [RFC PATCH v7 28/28] KVM: arm64: Allow the creation of a SPE enabled VM Alexandru Elisei
2026-11-03 19:49   ` Lorenzo Stoakes (ARM)
2026-10-15 10:25 ` [RFC PATCH v7 00/28] KVM: arm64: Add Statistical Profiling Extension (SPE) support Alexandru Elisei
2026-10-15 12:50   ` Lorenzo Stoakes (ARM)
2026-10-15 13:22     ` Alexandru Elisei
2026-11-05 17:47 ` Lorenzo Stoakes (ARM)
2026-11-05 19:28   ` Lorenzo Stoakes (ARM)
2026-11-06 11:41   ` Alexandru Elisei
2026-11-16 17:51     ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avtDK5rtD38jnhqR@gremlin \
    --to=ljs@kernel.org \
    --cc=alexandru.elisei@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=james.clark@linaro.org \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=seiden@linux.ibm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox