* [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer
@ 2025-08-11 8:25 Liao Yuanhong
2025-08-11 9:30 ` Cristian Marussi
2025-08-11 11:01 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Liao Yuanhong @ 2025-08-11 8:25 UTC (permalink / raw)
To: Sudeep Holla, Cristian Marussi, Jassi Brar,
open list:MAILBOX ARM MHUv3, moderated list:MAILBOX ARM MHUv3
Cc: Liao Yuanhong
Remove no_free_ptr() to ensure PTR_ERR() consistently retrieves the correct
error code.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/mailbox/arm_mhuv3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mailbox/arm_mhuv3.c b/drivers/mailbox/arm_mhuv3.c
index b97e79a5870f..0910da67f8a1 100644
--- a/drivers/mailbox/arm_mhuv3.c
+++ b/drivers/mailbox/arm_mhuv3.c
@@ -945,7 +945,7 @@ static irqreturn_t mhuv3_mbx_comb_interrupt(int irq, void *arg)
if (IS_ERR(data)) {
dev_err(dev,
"Failed to read in-band data. err:%ld\n",
- PTR_ERR(no_free_ptr(data)));
+ PTR_ERR(data));
goto rx_ack;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer
2025-08-11 8:25 [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer Liao Yuanhong
@ 2025-08-11 9:30 ` Cristian Marussi
2025-08-11 11:01 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Cristian Marussi @ 2025-08-11 9:30 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Sudeep Holla, Cristian Marussi, Jassi Brar,
open list:MAILBOX ARM MHUv3, moderated list:MAILBOX ARM MHUv3
On Mon, Aug 11, 2025 at 04:25:36PM +0800, Liao Yuanhong wrote:
> Remove no_free_ptr() to ensure PTR_ERR() consistently retrieves the correct
> error code.
>
Hi,
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> drivers/mailbox/arm_mhuv3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/arm_mhuv3.c b/drivers/mailbox/arm_mhuv3.c
> index b97e79a5870f..0910da67f8a1 100644
> --- a/drivers/mailbox/arm_mhuv3.c
> +++ b/drivers/mailbox/arm_mhuv3.c
> @@ -945,7 +945,7 @@ static irqreturn_t mhuv3_mbx_comb_interrupt(int irq, void *arg)
> if (IS_ERR(data)) {
> dev_err(dev,
> "Failed to read in-band data. err:%ld\n",
> - PTR_ERR(no_free_ptr(data)));
> + PTR_ERR(data));
> goto rx_ack;
Yes indeed the cleanup kfree helper takes care to skip any ERR_OR_NULL
by itself...good catch, thanks for this.
Acked-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer
2025-08-11 8:25 [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer Liao Yuanhong
2025-08-11 9:30 ` Cristian Marussi
@ 2025-08-11 11:01 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-11 11:01 UTC (permalink / raw)
To: Liao Yuanhong, Sudeep Holla, Cristian Marussi, Jassi Brar,
open list:MAILBOX ARM MHUv3, moderated list:MAILBOX ARM MHUv3
On 11/08/2025 10:25, Liao Yuanhong wrote:
> Remove no_free_ptr() to ensure PTR_ERR() consistently retrieves the correct
> error code.
Fixes tag?
Also, your commit msg does not look like wrapped according to submitting
rules.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-11 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-11 8:25 [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer Liao Yuanhong
2025-08-11 9:30 ` Cristian Marussi
2025-08-11 11:01 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox