From: Krzysztof Kozlowski <krzk@kernel.org>
To: MANNURU VENKATESWARLU <v-mannuru@ti.com>,
robh@kernel.org, conor+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
n-francis@ti.com, s-k6@ti.com, bb@ti.com
Subject: Re: [RFC PATCH 03/22] dt-bindings: memory: ti,j721s2-msmc: Add TI K3 MSMC binding
Date: Wed, 15 Jul 2026 06:57:06 +0200 [thread overview]
Message-ID: <f45a8496-b003-4cc0-bb4d-a94c9ac6b911@kernel.org> (raw)
In-Reply-To: <20260714125537.3304217-3-v-mannuru@ti.com>
On 14/07/2026 14:55, MANNURU VENKATESWARLU wrote:
> +required:
> + - compatible
> + - '#address-cells'
> + - '#size-cells'
> + - ranges
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
> +
> + msmc0: msmc {
> + compatible = "ti,j721s2-msmc", "simple-bus";
NAK
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> + intrlv-gran = <0>;
> + intrlv-size = <0>;
> + ecc-enable = <0>;
> + emif-config = <0>;
> + emif-active = <0>;
I do not accept downstream code sent to review.
Start doing proper internal reviews. This binding and DTS is absolutely
unacceptable, you just repeat all known mistakes ignoring any guidelines.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-15 4:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 12:55 [RFC PATCH 01/22] dt-bindings: memory: cdns,k3-ddr: Add Cadence K3 DDR controller binding MANNURU VENKATESWARLU
2026-07-14 12:55 ` [RFC PATCH 02/22] dt-bindings: memory: ti,j7-ddrss: Add TI K3 DDRSS wrapper binding MANNURU VENKATESWARLU
2026-07-14 12:55 ` [RFC PATCH 03/22] dt-bindings: memory: ti,j721s2-msmc: Add TI K3 MSMC binding MANNURU VENKATESWARLU
2026-07-15 4:57 ` Krzysztof Kozlowski [this message]
2026-07-15 8:34 ` MANNURU VENKATESWARLU
2026-07-15 4:55 ` [RFC PATCH 01/22] dt-bindings: memory: cdns,k3-ddr: Add Cadence K3 DDR controller binding Krzysztof Kozlowski
2026-07-15 9:03 ` MANNURU VENKATESWARLU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f45a8496-b003-4cc0-bb4d-a94c9ac6b911@kernel.org \
--to=krzk@kernel.org \
--cc=bb@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n-francis@ti.com \
--cc=robh@kernel.org \
--cc=s-k6@ti.com \
--cc=v-mannuru@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox