[PATCH v3 0/2] Adds SPMI bus, PMIC and peripherals for qcs615

[PATCH v3 0/2] Adds SPMI bus, PMIC and peripherals for qcs615

[Tingguo Cheng]

This patch series depends on the patch series:
- https://lore.kernel.org/all/20241022-add_initial_support_for_qcs615-v4-0-0a551c6dd342@quicinc.com/

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
Changes in v3:
- Fixed comments from the community in V2.
- Split the patch into 2 patches(SoC:qcs615.dtsi; Board:qcs615-ride.dts). 
- Link to v2: https://lore.kernel.org/r/20241024-adds-spmi-pmic-peripherals-for-qcs615-v2-1-f262ba243b63@quicinc.com

Changes in v2:
- Include "pm8150.dtsi" for QCS615 PMIC instead of creating a new
  qcs615-pmic.dtsi in the case that pmm6155au is a variant of pm8150.
- Fixed comments from community in V1.
- Link to v1: https://lore.kernel.org/r/20241014-adds-spmi-pmic-peripherals-for-qcs615-v1-1-8a3c67d894d8@quicinc.com

---
Tingguo Cheng (2):
      arm64: dts: qcom: qcs615: Adds SPMI support
      arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

 arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
 arch/arm64/boot/dts/qcom/qcs615.dtsi     | 23 +++++++++++++++++++++++
 2 files changed, 38 insertions(+)
---
base-commit: de938618db2bafbe1a70c8fc43f06ccdd60364b2
change-id: 20240929-adds-spmi-pmic-peripherals-for-qcs615-16ee53179a7d
prerequisite-change-id: 20241022-add_initial_support_for_qcs615-2256f64a9c24:v4
prerequisite-patch-id: 09782474af7eecf1013425fd34f9d2f082fb3616
prerequisite-patch-id: 624720e543d7857e46d3ee49b8cea413772deb4c
prerequisite-patch-id: 04ca722967256efddc402b7bab94136a5174b0b9
prerequisite-patch-id: ab88a42ec69ad90e8509c9c5b7c6bdd595a7f783
prerequisite-patch-id: 918724fafe43acaa4c4b980bfabe36e9c3212cd1
prerequisite-patch-id: 3bd8edd83297815fcb1b81fcd891d3c14908442f
prerequisite-patch-id: fc1cfec4ecd56e669c161c4d2c3797fc0abff0ae

Best regards,
-- 
Tingguo Cheng <quic_tingguoc@quicinc.com>

[PATCH v3 1/2] arm64: dts: qcom: qcs615: Adds SPMI support

[Tingguo Cheng]

Add the SPMI bus Arbiter node for the PMIC on QCS615 platforms.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs615.dtsi | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
index ac4c4c751da1fbb28865877555ba317677bc6bd2..3fc928913239cfc61c24d1b16c183b96f38e589d 100644
--- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
@@ -517,6 +517,29 @@ sram@c3f0000 {
 			reg = <0x0 0x0c3f0000 0x0 0x400>;
 		};
 
+		spmi_bus: spmi@c440000 {
+			compatible = "qcom,spmi-pmic-arb";
+			reg = <0x0 0x0c440000 0x0 0x1100>,
+			      <0x0 0x0c600000 0x0 0x2000000>,
+			      <0x0 0x0e600000 0x0 0x100000>,
+			      <0x0 0x0e700000 0x0 0xa0000>,
+			      <0x0 0x0c40a000 0x0 0x26000>;
+			reg-names = "core",
+				    "chnls",
+				    "obsrvr",
+				    "intr",
+				    "cnfg";
+			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "periph_irq";
+			interrupt-controller;
+			#interrupt-cells = <4>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+			cell-index = <0>;
+			qcom,channel = <0>;
+			qcom,ee = <0>;
+		};
+
 		intc: interrupt-controller@17a00000 {
 			compatible = "arm,gic-v3";
 			reg = <0x0 0x17a00000 0x0 0x10000>,     /* GICD */

-- 
2.34.1

Re: [PATCH v3 1/2] arm64: dts: qcom: qcs615: Adds SPMI support

[Konrad Dybcio]

On 28.10.2024 9:03 AM, Tingguo Cheng wrote:
> Add the SPMI bus Arbiter node for the PMIC on QCS615 platforms.
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Tingguo Cheng]

Enable PMIC and PMIC peripherals for qcs615-ride board.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -6,6 +6,7 @@
 
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include "qcs615.dtsi"
+#include "pm8150.dtsi"
 / {
 	model = "Qualcomm Technologies, Inc. QCS615 Ride";
 	compatible = "qcom,qcs615-ride", "qcom,qcs615";
@@ -210,6 +211,20 @@ &rpmhcc {
 	clocks = <&xo_board_clk>;
 };
 
+&pon {
+	/delete-property/ mode-bootloader;
+	/delete-property/ mode-recovery;
+};
+
+&pon_pwrkey {
+	status = "okay";
+};
+
+&pon_resin {
+	linux,code = <KEY_VOLUMEDOWN>;
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };

-- 
2.34.1

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Dmitry Baryshkov]

On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
> Enable PMIC and PMIC peripherals for qcs615-ride board.
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -6,6 +6,7 @@
>  
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include "qcs615.dtsi"
> +#include "pm8150.dtsi"
>  / {
>  	model = "Qualcomm Technologies, Inc. QCS615 Ride";
>  	compatible = "qcom,qcs615-ride", "qcom,qcs615";
> @@ -210,6 +211,20 @@ &rpmhcc {
>  	clocks = <&xo_board_clk>;
>  };
>  
> +&pon {
> +	/delete-property/ mode-bootloader;
> +	/delete-property/ mode-recovery;

Why?

> +};
> +
> +&pon_pwrkey {
> +	status = "okay";
> +};
> +
> +&pon_resin {
> +	linux,code = <KEY_VOLUMEDOWN>;
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	status = "okay";
>  };
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Tingguo Cheng]

On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
>> Enable PMIC and PMIC peripherals for qcs615-ride board.
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -6,6 +6,7 @@
>>   
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>   #include "qcs615.dtsi"
>> +#include "pm8150.dtsi"
>>   / {
>>   	model = "Qualcomm Technologies, Inc. QCS615 Ride";
>>   	compatible = "qcom,qcs615-ride", "qcom,qcs615";
>> @@ -210,6 +211,20 @@ &rpmhcc {
>>   	clocks = <&xo_board_clk>;
>>   };
>>   
>> +&pon {
>> +	/delete-property/ mode-bootloader;
>> +	/delete-property/ mode-recovery;
> 
> Why?
Because boot modes will be supported on PSCI module from another patch, 
reboot-modes are required to remove from PMIC side.
> 
>> +};
>> +
>> +&pon_pwrkey {
>> +	status = "okay";
>> +};
>> +
>> +&pon_resin {
>> +	linux,code = <KEY_VOLUMEDOWN>;
>> +	status = "okay";
>> +};
>> +
>>   &uart0 {
>>   	status = "okay";
>>   };
>>
>> -- 
>> 2.34.1
>>
> 

-- 
Thank you & BRs
Tingguo

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Dmitry Baryshkov]

On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
>
>
>
> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
> > On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
> >> Enable PMIC and PMIC peripherals for qcs615-ride board.
> >>
> >> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> >> ---
> >>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
> >>   1 file changed, 15 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> >> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
> >> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> >> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> >> @@ -6,6 +6,7 @@
> >>
> >>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >>   #include "qcs615.dtsi"
> >> +#include "pm8150.dtsi"
> >>   / {
> >>      model = "Qualcomm Technologies, Inc. QCS615 Ride";
> >>      compatible = "qcom,qcs615-ride", "qcom,qcs615";
> >> @@ -210,6 +211,20 @@ &rpmhcc {
> >>      clocks = <&xo_board_clk>;
> >>   };
> >>
> >> +&pon {
> >> +    /delete-property/ mode-bootloader;
> >> +    /delete-property/ mode-recovery;
> >
> > Why?
> Because boot modes will be supported on PSCI module from another patch,
> reboot-modes are required to remove from PMIC side.

=> commit message, please.

> >
> >> +};
> >> +
> >> +&pon_pwrkey {
> >> +    status = "okay";
> >> +};
> >> +
> >> +&pon_resin {
> >> +    linux,code = <KEY_VOLUMEDOWN>;
> >> +    status = "okay";
> >> +};
> >> +
> >>   &uart0 {
> >>      status = "okay";
> >>   };
> >>
> >> --
> >> 2.34.1
> >>
> >
>
> --
> Thank you & BRs
> Tingguo
>


-- 
With best wishes
Dmitry

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Konrad Dybcio]

On 28.10.2024 10:41 AM, Dmitry Baryshkov wrote:
> On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
>>
>>
>>
>> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
>>> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
>>>> Enable PMIC and PMIC peripherals for qcs615-ride board.
>>>>
>>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>>>> ---
>>>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>>>>   1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> @@ -6,6 +6,7 @@
>>>>
>>>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>>   #include "qcs615.dtsi"
>>>> +#include "pm8150.dtsi"
>>>>   / {
>>>>      model = "Qualcomm Technologies, Inc. QCS615 Ride";
>>>>      compatible = "qcom,qcs615-ride", "qcom,qcs615";
>>>> @@ -210,6 +211,20 @@ &rpmhcc {
>>>>      clocks = <&xo_board_clk>;
>>>>   };
>>>>
>>>> +&pon {
>>>> +    /delete-property/ mode-bootloader;
>>>> +    /delete-property/ mode-recovery;
>>>
>>> Why?
>> Because boot modes will be supported on PSCI module from another patch,
>> reboot-modes are required to remove from PMIC side.

Do we know whether the PSCI call does the same thing under the hood?

Konrad

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Dmitry Baryshkov]

On Mon, Oct 28, 2024 at 02:09:45PM +0100, Konrad Dybcio wrote:
> On 28.10.2024 10:41 AM, Dmitry Baryshkov wrote:
> > On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
> >>
> >>
> >>
> >> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
> >>> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
> >>>> Enable PMIC and PMIC peripherals for qcs615-ride board.
> >>>>
> >>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> >>>> ---
> >>>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
> >>>>   1 file changed, 15 insertions(+)
> >>>>
> >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> >>>> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
> >>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> >>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> >>>> @@ -6,6 +6,7 @@
> >>>>
> >>>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >>>>   #include "qcs615.dtsi"
> >>>> +#include "pm8150.dtsi"
> >>>>   / {
> >>>>      model = "Qualcomm Technologies, Inc. QCS615 Ride";
> >>>>      compatible = "qcom,qcs615-ride", "qcom,qcs615";
> >>>> @@ -210,6 +211,20 @@ &rpmhcc {
> >>>>      clocks = <&xo_board_clk>;
> >>>>   };
> >>>>
> >>>> +&pon {
> >>>> +    /delete-property/ mode-bootloader;
> >>>> +    /delete-property/ mode-recovery;
> >>>
> >>> Why?
> >> Because boot modes will be supported on PSCI module from another patch,
> >> reboot-modes are required to remove from PMIC side.
> 
> Do we know whether the PSCI call does the same thing under the hood?

It might be writing to the SDAM. For example, SAR2130P also uses PM8150
and, if I'm not mistaken, SDAM for reboot mode.

-- 
With best wishes
Dmitry

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Elliot Berman]

On Mon, Oct 28, 2024 at 03:14:49PM +0200, Dmitry Baryshkov wrote:
> On Mon, Oct 28, 2024 at 02:09:45PM +0100, Konrad Dybcio wrote:
> > On 28.10.2024 10:41 AM, Dmitry Baryshkov wrote:
> > > On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
> > >> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
> > >>> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
> > >>>> Enable PMIC and PMIC peripherals for qcs615-ride board.
> > >>>>
> > >>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> > >>>> ---
> > >>>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
> > >>>>   1 file changed, 15 insertions(+)
> > >>>>
> > >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > >>>> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
> > >>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > >>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > >>>> @@ -6,6 +6,7 @@
> > >>>>
> > >>>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > >>>>   #include "qcs615.dtsi"
> > >>>> +#include "pm8150.dtsi"
> > >>>>   / {
> > >>>>      model = "Qualcomm Technologies, Inc. QCS615 Ride";
> > >>>>      compatible = "qcom,qcs615-ride", "qcom,qcs615";
> > >>>> @@ -210,6 +211,20 @@ &rpmhcc {
> > >>>>      clocks = <&xo_board_clk>;
> > >>>>   };
> > >>>>
> > >>>> +&pon {
> > >>>> +    /delete-property/ mode-bootloader;
> > >>>> +    /delete-property/ mode-recovery;
> > >>>
> > >>> Why?
> > >> Because boot modes will be supported on PSCI module from another patch,
> > >> reboot-modes are required to remove from PMIC side.

I don't know why "required to remove" is here. We *could* continue to
program the SDAM from Linux.

That being said, I don't know that the firmware/bootloader from the
QCS615 Ride has the concept of "reboot to recovery" since it's not an
Android ecosystem. I'd let Tingguo comment on it.

> > 
> > Do we know whether the PSCI call does the same thing under the hood?
> 
> It might be writing to the SDAM. For example, SAR2130P also uses PM8150
> and, if I'm not mistaken, SDAM for reboot mode.
> 

Yes, PSCI does the same thing under the hood.

What is going here is that we have introduced the SYSTEM_RESET2 vendor
resets in some firmwares which run on boards that use PM8150. Based on
context here (IOW: I might be a little wrong on the details), I guess
QCS615 Ride is being added to Qualcomm Linux stack, which has newer
firmware that supports using the SYSTEM_RESET2 vendor resets.

IMO, we should move the mode-bootloader/mode-recovery properties out of
pm8150.dtsi and into the applicable board.dts. As Bjorn mentioned, the
interpretation of the cookie values is specific to the board's firmware,
not the the pmic*. Tingguo, can you submit patches to do that?

Regards,
Elliot

*: In general, the cookie values are consistent. Some values are only
applicable on automotive board or mobile board though (or IOT).

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Tingguo Cheng]

On 11/1/2024 4:28 AM, Elliot Berman wrote:
> On Mon, Oct 28, 2024 at 03:14:49PM +0200, Dmitry Baryshkov wrote:
>> On Mon, Oct 28, 2024 at 02:09:45PM +0100, Konrad Dybcio wrote:
>>> On 28.10.2024 10:41 AM, Dmitry Baryshkov wrote:
>>>> On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
>>>>> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
>>>>>> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
>>>>>>> Enable PMIC and PMIC peripherals for qcs615-ride board.
>>>>>>>
>>>>>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>>>>>>> ---
>>>>>>>    arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>>>>>>>    1 file changed, 15 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>>> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
>>>>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>>> @@ -6,6 +6,7 @@
>>>>>>>
>>>>>>>    #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>>>>>    #include "qcs615.dtsi"
>>>>>>> +#include "pm8150.dtsi"
>>>>>>>    / {
>>>>>>>       model = "Qualcomm Technologies, Inc. QCS615 Ride";
>>>>>>>       compatible = "qcom,qcs615-ride", "qcom,qcs615";
>>>>>>> @@ -210,6 +211,20 @@ &rpmhcc {
>>>>>>>       clocks = <&xo_board_clk>;
>>>>>>>    };
>>>>>>>
>>>>>>> +&pon {
>>>>>>> +    /delete-property/ mode-bootloader;
>>>>>>> +    /delete-property/ mode-recovery;
>>>>>>
>>>>>> Why?
>>>>> Because boot modes will be supported on PSCI module from another patch,
>>>>> reboot-modes are required to remove from PMIC side.
> 
> I don't know why "required to remove" is here. We *could* continue to
> program the SDAM from Linux.
Sure, we could continue to program the SDAM from Linux. Regarding PSCI 
and PMIC both are dealing with reboot-modes, we need to consider more.
> 
> That being said, I don't know that the firmware/bootloader from the
> QCS615 Ride has the concept of "reboot to recovery" since it's not an
> Android ecosystem. I'd let Tingguo comment on it.
> 
About mode-recovery:
pm8150.dtsi is originally designed for mobile/android devices in which 
reboot modes are managed by PMIC driver, that's why I think the modes 
are there in pm8150.dtsi.

About QCS615 Ride:
QCS615 Ride use a pmm6155au(that's a variant of pm8150) and it's a Linux 
system. But we involved pm8150.dtsi for "the meaning of variant". That's 
why the "recovery-mode" is there. Maybe we can treat this as a change 
for "the variant" as well(Only for QCS615 ride as Dmitry said).
>>>
>>> Do we know whether the PSCI call does the same thing under the hood?
>>
>> It might be writing to the SDAM. For example, SAR2130P also uses PM8150
>> and, if I'm not mistaken, SDAM for reboot mode.
>>
> 
> Yes, PSCI does the same thing under the hood.
> 
> What is going here is that we have introduced the SYSTEM_RESET2 vendor
> resets in some firmwares which run on boards that use PM8150. Based on
> context here (IOW: I might be a little wrong on the details), I guess
> QCS615 Ride is being added to Qualcomm Linux stack, which has newer
> firmware that supports using the SYSTEM_RESET2 vendor resets.
> 
> IMO, we should move the mode-bootloader/mode-recovery properties out of
> pm8150.dtsi and into the applicable board.dts. As Bjorn mentioned, the
> interpretation of the cookie values is specific to the board's firmware,
> not the the pmic*. Tingguo, can you submit patches to do that?
> 
Of course, Should we split the "moving modes out of pm8150.dtsi" into 
another patch series? Because there are some boards need to change and 
this patch series is for "Adds SPMI bus, PMIC and peripherals for qcs615".
> Regards,
> Elliot
> 
> *: In general, the cookie values are consistent. Some values are only
> applicable on automotive board or mobile board though (or IOT).
> 

-- 
Thank you & BRs
Tingguo

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Tingguo Cheng]

On 11/5/2024 3:47 PM, Tingguo Cheng wrote:
> 
> 
> On 11/1/2024 4:28 AM, Elliot Berman wrote:
>> On Mon, Oct 28, 2024 at 03:14:49PM +0200, Dmitry Baryshkov wrote:
>>> On Mon, Oct 28, 2024 at 02:09:45PM +0100, Konrad Dybcio wrote:
>>>> On 28.10.2024 10:41 AM, Dmitry Baryshkov wrote:
>>>>> On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng 
>>>>> <quic_tingguoc@quicinc.com> wrote:
>>>>>> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
>>>>>>> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
>>>>>>>> Enable PMIC and PMIC peripherals for qcs615-ride board.
>>>>>>>>
>>>>>>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>>>>>>>> ---
>>>>>>>>    arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>>>>>>>>    1 file changed, 15 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/ 
>>>>>>>> arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>>>> index 
>>>>>>>> ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
>>>>>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>>>> @@ -6,6 +6,7 @@
>>>>>>>>
>>>>>>>>    #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>>>>>>    #include "qcs615.dtsi"
>>>>>>>> +#include "pm8150.dtsi"
>>>>>>>>    / {
>>>>>>>>       model = "Qualcomm Technologies, Inc. QCS615 Ride";
>>>>>>>>       compatible = "qcom,qcs615-ride", "qcom,qcs615";
>>>>>>>> @@ -210,6 +211,20 @@ &rpmhcc {
>>>>>>>>       clocks = <&xo_board_clk>;
>>>>>>>>    };
>>>>>>>>
>>>>>>>> +&pon {
>>>>>>>> +    /delete-property/ mode-bootloader;
>>>>>>>> +    /delete-property/ mode-recovery;
>>>>>>>
>>>>>>> Why?
>>>>>> Because boot modes will be supported on PSCI module from another 
>>>>>> patch,
>>>>>> reboot-modes are required to remove from PMIC side.
>>
>> I don't know why "required to remove" is here. We *could* continue to
>> program the SDAM from Linux.
> Sure, we could continue to program the SDAM from Linux. Regarding PSCI 
> and PMIC both are dealing with reboot-modes, we need to consider more.
>>
>> That being said, I don't know that the firmware/bootloader from the
>> QCS615 Ride has the concept of "reboot to recovery" since it's not an
>> Android ecosystem. I'd let Tingguo comment on it.
>>
> About mode-recovery:
> pm8150.dtsi is originally designed for mobile/android devices in which 
> reboot modes are managed by PMIC driver, that's why I think the modes 
> are there in pm8150.dtsi.
> 
> About QCS615 Ride:
> QCS615 Ride use a pmm6155au(that's a variant of pm8150) and it's a Linux 
> system. But we involved pm8150.dtsi for "the meaning of variant". That's 
> why the "recovery-mode" is there. Maybe we can treat this as a change 
> for "the variant" as well(Only for QCS615 ride as Dmitry said).
>>>>
>>>> Do we know whether the PSCI call does the same thing under the hood?
>>>
>>> It might be writing to the SDAM. For example, SAR2130P also uses PM8150
>>> and, if I'm not mistaken, SDAM for reboot mode.
>>>
>>
>> Yes, PSCI does the same thing under the hood.
>>
>> What is going here is that we have introduced the SYSTEM_RESET2 vendor
>> resets in some firmwares which run on boards that use PM8150. Based on
>> context here (IOW: I might be a little wrong on the details), I guess
>> QCS615 Ride is being added to Qualcomm Linux stack, which has newer
>> firmware that supports using the SYSTEM_RESET2 vendor resets.
>>
>> IMO, we should move the mode-bootloader/mode-recovery properties out of
>> pm8150.dtsi and into the applicable board.dts. As Bjorn mentioned, the
>> interpretation of the cookie values is specific to the board's firmware,
>> not the the pmic*. Tingguo, can you submit patches to do that?
>>
> Of course, Should we split the "moving modes out of pm8150.dtsi" into 
> another patch series? Because there are some boards need to change and 
> this patch series is for "Adds SPMI bus, PMIC and peripherals for qcs615".
>> Regards,
>> Elliot
>>
>> *: In general, the cookie values are consistent. Some values are only
>> applicable on automotive board or mobile board though (or IOT).
>>
> 
update v4: 
https://lore.kernel.org/lkml/20241112-adds-spmi-pmic-peripherals-for-qcs615-v4-0-f0e54d8b6516@quicinc.com/

-- 
Thank you & BRs
Tingguo

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Tingguo Cheng]

On 10/28/2024 5:41 PM, Dmitry Baryshkov wrote:
> On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
>>
>>
>>
>> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
>>> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
>>>> Enable PMIC and PMIC peripherals for qcs615-ride board.
>>>>
>>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>>>>    1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> @@ -6,6 +6,7 @@
>>>>
>>>>    #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>>    #include "qcs615.dtsi"
>>>> +#include "pm8150.dtsi"
>>>>    / {
>>>>       model = "Qualcomm Technologies, Inc. QCS615 Ride";
>>>>       compatible = "qcom,qcs615-ride", "qcom,qcs615";
>>>> @@ -210,6 +211,20 @@ &rpmhcc {
>>>>       clocks = <&xo_board_clk>;
>>>>    };
>>>>
>>>> +&pon {
>>>> +    /delete-property/ mode-bootloader;
>>>> +    /delete-property/ mode-recovery;
>>>
>>> Why?
>> Because boot modes will be supported on PSCI module from another patch,
>> reboot-modes are required to remove from PMIC side.
> 
> => commit message, please.
> 
okay, will upload v4 with other comments fixing together.
>>>
>>>> +};
>>>> +
>>>> +&pon_pwrkey {
>>>> +    status = "okay";
>>>> +};
>>>> +
>>>> +&pon_resin {
>>>> +    linux,code = <KEY_VOLUMEDOWN>;
>>>> +    status = "okay";
>>>> +};
>>>> +
>>>>    &uart0 {
>>>>       status = "okay";
>>>>    };
>>>>
>>>> --
>>>> 2.34.1
>>>>
>>>
>>
>> --
>> Thank you & BRs
>> Tingguo
>>
> 
> 

-- 
Thank you & BRs
Tingguo

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Bjorn Andersson]

On Mon, Oct 28, 2024 at 04:40:36PM +0800, Tingguo Cheng wrote:
> 
> 
> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
> > On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
> > > Enable PMIC and PMIC peripherals for qcs615-ride board.
> > > 
> > > Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
> > >   1 file changed, 15 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > @@ -6,6 +6,7 @@
> > >   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > >   #include "qcs615.dtsi"
> > > +#include "pm8150.dtsi"
> > >   / {
> > >   	model = "Qualcomm Technologies, Inc. QCS615 Ride";
> > >   	compatible = "qcom,qcs615-ride", "qcom,qcs615";
> > > @@ -210,6 +211,20 @@ &rpmhcc {
> > >   	clocks = <&xo_board_clk>;
> > >   };
> > > +&pon {
> > > +	/delete-property/ mode-bootloader;
> > > +	/delete-property/ mode-recovery;
> > 
> > Why?
> Because boot modes will be supported on PSCI module from another patch,
> reboot-modes are required to remove from PMIC side.

That implies that the reboot mode implementation is device-specific, if
so we should probably not define them in the shared file.

Regards,
Bjorn

> > 
> > > +};
> > > +
> > > +&pon_pwrkey {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&pon_resin {
> > > +	linux,code = <KEY_VOLUMEDOWN>;
> > > +	status = "okay";
> > > +};
> > > +
> > >   &uart0 {
> > >   	status = "okay";
> > >   };
> > > 
> > > -- 
> > > 2.34.1
> > > 
> > 
> 
> -- 
> Thank you & BRs
> Tingguo
> 

Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Dmitry Baryshkov]

On Tue, 29 Oct 2024 at 04:18, Bjorn Andersson
<bjorn.andersson@oss.qualcomm.com> wrote:
>
> On Mon, Oct 28, 2024 at 04:40:36PM +0800, Tingguo Cheng wrote:
> >
> >
> > On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
> > > On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
> > > > Enable PMIC and PMIC peripherals for qcs615-ride board.
> > > >
> > > > Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> > > > ---
> > > >   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
> > > >   1 file changed, 15 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
> > > > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > @@ -6,6 +6,7 @@
> > > >   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > > >   #include "qcs615.dtsi"
> > > > +#include "pm8150.dtsi"
> > > >   / {
> > > >           model = "Qualcomm Technologies, Inc. QCS615 Ride";
> > > >           compatible = "qcom,qcs615-ride", "qcom,qcs615";
> > > > @@ -210,6 +211,20 @@ &rpmhcc {
> > > >           clocks = <&xo_board_clk>;
> > > >   };
> > > > +&pon {
> > > > + /delete-property/ mode-bootloader;
> > > > + /delete-property/ mode-recovery;
> > >
> > > Why?
> > Because boot modes will be supported on PSCI module from another patch,
> > reboot-modes are required to remove from PMIC side.
>
> That implies that the reboot mode implementation is device-specific, if
> so we should probably not define them in the shared file.

Most likely. Let's collect some more data points first. It's probably
not worth doing that just for qcs615-ride, I'd like to check how it is
really handled on the SAR platform.

-- 
With best wishes
Dmitry