* [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller
@ 2025-10-02 17:29 Krishna Kurapati
2025-10-03 13:07 ` Rob Herring (Arm)
2025-10-03 13:27 ` Konrad Dybcio
0 siblings, 2 replies; 4+ messages in thread
From: Krishna Kurapati @ 2025-10-02 17:29 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati
Enable OTG support for primary USB controller on EVK Platform. Add
HD3SS3220 Type-C port controller present between Type-C port and SoC
that provides role switch notifications to controller.
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
Link to driver and binding changes:
https://lore.kernel.org/all/20251002172539.586538-1-krishna.kurapati@oss.qualcomm.com/
arch/arm64/boot/dts/qcom/lemans-evk.dts | 122 +++++++++++++++++++++++-
1 file changed, 121 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
index c7dc9b8f4457..0b6d8d2d19d6 100644
--- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
+++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
@@ -37,6 +37,32 @@ chosen {
stdout-path = "serial0:115200n8";
};
+ connector0 {
+ compatible = "usb-c-connector";
+ label = "USB0-Type-C";
+ data-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ usb0_con_hs_ep: endpoint {
+ remote-endpoint = <&usb3_hs_ep>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+
+ usb0_con_ss_ep: endpoint {
+ remote-endpoint = <&hd3ss3220_in_ep>;
+ };
+ };
+ };
+ };
+
edp0-connector {
compatible = "dp-connector";
label = "EDP0";
@@ -101,6 +127,15 @@ platform {
};
};
+ vbus_supply_regulator_0: vbus-supply-regulator-0 {
+ compatible = "regulator-fixed";
+ regulator-name = "vbus_supply_0";
+ gpio = <&expander1 2 GPIO_ACTIVE_HIGH>;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ };
+
vmmc_sdc: regulator-vmmc-sdc {
compatible = "regulator-fixed";
@@ -453,6 +488,55 @@ &gpi_dma2 {
status = "okay";
};
+&pmm8654au_2_gpios {
+ usb0_intr_state: usb0-intr-state {
+ pins = "gpio5";
+ function = "normal";
+ input-enable;
+ bias-pull-up;
+ power-source = <0>;
+ };
+};
+
+&i2c11 {
+ status = "okay";
+
+ hd3ss3220@67 {
+ compatible = "ti,hd3ss3220";
+ reg = <0x67>;
+
+ interrupts-extended = <&pmm8654au_2_gpios 5 IRQ_TYPE_EDGE_FALLING>;
+
+ id-gpios = <&tlmm 50 GPIO_ACTIVE_HIGH>;
+
+ pinctrl-0 = <&usb_id>, <&usb0_intr_state>;
+ pinctrl-names = "default";
+
+ vbus-supply = <&vbus_supply_regulator_0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ hd3ss3220_in_ep: endpoint {
+ remote-endpoint = <&usb0_con_ss_ep>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ hd3ss3220_out_ep: endpoint {
+ remote-endpoint = <&usb3_role_switch>;
+ };
+ };
+ };
+ };
+};
+
&i2c18 {
status = "okay";
@@ -718,11 +802,24 @@ wake-pins {
};
};
+ qup_i2c11_default: qup-i2c11-state {
+ pins = "gpio48", "gpio49";
+ function = "qup1_se4";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
sd_cd: sd-cd-state {
pins = "gpio36";
function = "gpio";
bias-pull-up;
};
+
+ usb_id: usb-id-state {
+ pins = "gpio50";
+ function = "gpio";
+ bias-pull-up;
+ };
};
&uart10 {
@@ -751,9 +848,32 @@ &ufs_mem_phy {
};
&usb_0 {
- dr_mode = "peripheral";
+ dr_mode = "otg";
+ usb-role-switch;
status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ usb3_hs_ep: endpoint {
+ remote-endpoint = <&usb0_con_hs_ep>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ usb3_role_switch: endpoint {
+ remote-endpoint = <&hd3ss3220_out_ep>;
+ };
+ };
+
+ };
};
&usb_0_hsphy {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller
2025-10-02 17:29 [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller Krishna Kurapati
@ 2025-10-03 13:07 ` Rob Herring (Arm)
2025-10-03 13:27 ` Konrad Dybcio
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-10-03 13:07 UTC (permalink / raw)
To: Krishna Kurapati
Cc: Konrad Dybcio, devicetree, Conor Dooley, Krzysztof Kozlowski,
linux-kernel, Bjorn Andersson, linux-arm-msm
On Thu, 02 Oct 2025 22:59:46 +0530, Krishna Kurapati wrote:
> Enable OTG support for primary USB controller on EVK Platform. Add
> HD3SS3220 Type-C port controller present between Type-C port and SoC
> that provides role switch notifications to controller.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> Link to driver and binding changes:
> https://lore.kernel.org/all/20251002172539.586538-1-krishna.kurapati@oss.qualcomm.com/
>
> arch/arm64/boot/dts/qcom/lemans-evk.dts | 122 +++++++++++++++++++++++-
> 1 file changed, 121 insertions(+), 1 deletion(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: remotes/next/fs-next-6496-g155abb6f8812 (exact match)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251002172946.589061-1-krishna.kurapati@oss.qualcomm.com:
arch/arm64/boot/dts/qcom/lemans-evk.dtb: hd3ss3220@67 (ti,hd3ss3220): 'id-gpios', 'vbus-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/usb/ti,hd3ss3220.yaml#
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller
2025-10-02 17:29 [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller Krishna Kurapati
2025-10-03 13:07 ` Rob Herring (Arm)
@ 2025-10-03 13:27 ` Konrad Dybcio
2025-10-03 16:36 ` Krishna Kurapati PSSNV
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2025-10-03 13:27 UTC (permalink / raw)
To: Krishna Kurapati, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 10/2/25 7:29 PM, Krishna Kurapati wrote:
> Enable OTG support for primary USB controller on EVK Platform. Add
> HD3SS3220 Type-C port controller present between Type-C port and SoC
> that provides role switch notifications to controller.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> Link to driver and binding changes:
> https://lore.kernel.org/all/20251002172539.586538-1-krishna.kurapati@oss.qualcomm.com/
>
> arch/arm64/boot/dts/qcom/lemans-evk.dts | 122 +++++++++++++++++++++++-
> 1 file changed, 121 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> index c7dc9b8f4457..0b6d8d2d19d6 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> @@ -37,6 +37,32 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + connector0 {
> + compatible = "usb-c-connector";
> + label = "USB0-Type-C";
Are there other, non-type-C ports labeled USB0 onboard?
> + data-role = "dual";
power-role = "xxx"
[...]
> + vbus_supply_regulator_0: vbus-supply-regulator-0 {
the suffix suggests there are going to be more - is that the case?
[...]
> &usb_0 {
> - dr_mode = "peripheral";
> + dr_mode = "otg";
otg is default, you can probably drop it
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller
2025-10-03 13:27 ` Konrad Dybcio
@ 2025-10-03 16:36 ` Krishna Kurapati PSSNV
0 siblings, 0 replies; 4+ messages in thread
From: Krishna Kurapati PSSNV @ 2025-10-03 16:36 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
Krzysztof Kozlowski, Rob Herring, Conor Dooley
On 10/3/2025 6:57 PM, Konrad Dybcio wrote:
> On 10/2/25 7:29 PM, Krishna Kurapati wrote:
>> Enable OTG support for primary USB controller on EVK Platform. Add
>> HD3SS3220 Type-C port controller present between Type-C port and SoC
>> that provides role switch notifications to controller.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>> Link to driver and binding changes:
>> https://lore.kernel.org/all/20251002172539.586538-1-krishna.kurapati@oss.qualcomm.com/
>>
>> arch/arm64/boot/dts/qcom/lemans-evk.dts | 122 +++++++++++++++++++++++-
>> 1 file changed, 121 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> index c7dc9b8f4457..0b6d8d2d19d6 100644
>> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> @@ -37,6 +37,32 @@ chosen {
>> stdout-path = "serial0:115200n8";
>> };
>>
>> + connector0 {
>> + compatible = "usb-c-connector";
>> + label = "USB0-Type-C";
>
> Are there other, non-type-C ports labeled USB0 onboard?
>
There is another Type-C port connected to secondary controller.
There is one Micro USB Port connected to tertiary controller.
>> + data-role = "dual";
>
> power-role = "xxx"
>
ACK. Will add it.
> [...]
>
>> + vbus_supply_regulator_0: vbus-supply-regulator-0 {
>
> the suffix suggests there are going to be more - is that the case?
>
The second Typec port would have another connector added. So another
vbus node would be added.
> [...]
>
>> &usb_0 {
>> - dr_mode = "peripheral";
>> + dr_mode = "otg";
>
> otg is default, you can probably drop it
>
ACK.
Regards,
Krishna,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-03 16:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-02 17:29 [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller Krishna Kurapati
2025-10-03 13:07 ` Rob Herring (Arm)
2025-10-03 13:27 ` Konrad Dybcio
2025-10-03 16:36 ` Krishna Kurapati PSSNV
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox