[PATCH v4 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts

[PATCH v4 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts

[Paul Sajna]

Rollup of improved hardware support via devicetree for LG G7 ThinQ 
(judyln) from sdm845-mainline kernel fork

Notably, this patch-series enables full DRM acceleration and wifi,
among other small improvements in individual commits

after this patch-series the main things that remain to be worked
on include touchscreen, audio, and modem.

Depends upon panel driver patch-series https://lore.kernel.org/all/20250910-judyln-panel-v1-1-825c74403bbb@postmarketos.org/T/#r9a976ca01e309b6c03100e984a26a0ffc2fe2002

Depends upon qcom,snoc-host-cap-skip-quirk https://lore.kernel.org/all/20251110-skip-host-cam-qmi-req-v2-0-0daf485a987a@ixit.cz/T/

Co-developed-by: Amir Dahan <system64fumo@protonmail.com>
Co-developed-by: Christopher Brown <crispybrown@gmail.com>
Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
Signed-off-by: Christopher Brown <crispybrown@gmail.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
Changes in v4:
- add panel identifier in addition to ddic
- make sde_te pull-down
- fixup flash current
- remove framebuffer reserved-mem 
- remove manual lower guard
- depend upon https://lore.kernel.org/all/20251110-skip-host-cam-qmi-req-v2-0-0daf485a987a@ixit.cz/T
- reword commits
- Link to v3: https://lore.kernel.org/r/20250928-judyln-dts-v3-0-b14cf9e9a928@postmarketos.org

Changes in v3:
- change firmware paths to lowercase 'lg' (matching dt-bindings)
- fix signoffs
- add wifi dmesg to commit message
- remove regulator-always-on from ibb
- remove framebuffer
- remove msm ids
- don't continue commit subject into commit messages
- split bluetooth node
- add sbu uart details to commit message
- change ipa gsi-loader to self
- Link to v2: https://lore.kernel.org/r/20250916-judyln-dts-v2-0-5e16e60263af@postmarketos.org

Changes in v2:
- sort at the start
- drop unnecessary labels
- drop unnecessary gmu
- multi-led
- split fb-panel changes
- expand upon firmware commit message
- use qcom,calibration-variant instead of
  qcom,ath10k-calibration-variant
- change firmware paths to include "LG"
- remove framebuffer reservation
- add lab/ibb

- Link to v1: https://lore.kernel.org/r/20250913-judyln-dts-v1-0-23b4b7790dce@postmarketos.org

---
Amir Dahan (1):
      arm64: dts: qcom: sdm845-lg-common: Add LEDs

Christopher Brown (1):
      arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger

Paul Sajna (10):
      arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties
      arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
      arm64: dts: qcom: sdm845-lg-judyln: Add display panel
      arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
      arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node
      arm64: dts: qcom: sdm845-lg-common: Add chassis-type
      arm64: dts: qcom: sdm845-lg-common: Add camera flash
      arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
      arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self'
      arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 238 ++++++++++++++++++-------
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 138 ++++++++++++--
 2 files changed, 296 insertions(+), 80 deletions(-)
---
base-commit: 3d53f9ca24dd7492fe88fd0f1a418e3dc8b03515
change-id: 20250911-judyln-dts-17c41e59dc0f
prerequisite-message-id: <20250910-judyln-panel-v1-1-825c74403bbb@postmarketos.org>
prerequisite-patch-id: e51151ea7f8fdad6ad7d90713febc5c6b6fc4f9c
prerequisite-patch-id: b3dd44250da9cd12bc5b2d0d7e865dbe19ceed92
prerequisite-patch-id: fd6c8077806cb03fcf37d0e0d730314c2760e334
prerequisite-message-id: <20251110-skip-host-cam-qmi-req-v2-0-0daf485a987a@ixit.cz>
prerequisite-patch-id: 32934e043aa82e7dccdcb962037e78663eae24a6
prerequisite-patch-id: 9c69ab29256c15a0e8ac1c3b9ef64b27661c7815
prerequisite-patch-id: 8fce59716f5d0d873c3407937e4f852eb18c75f0

Best regards,
-- 
Paul Sajna <sajattack@postmarketos.org>

[PATCH v4 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties

[Paul Sajna]

Improve adherance to style guidelines below:
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 144 ++++++++++++++-----------
 1 file changed, 82 insertions(+), 62 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 0ee2f4b99fbd..b8ab64a8de1c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -38,11 +38,6 @@ reserved-memory {
 		#size-cells = <2>;
 		ranges;
 
-		qseecom_mem: memory@b2000000 {
-			reg = <0 0xb2000000 0 0x1800000>;
-			no-map;
-		};
-
 		gpu_mem: memory@8c415000 {
 			reg = <0 0x8c415000 0 0x2000>;
 			no-map;
@@ -99,7 +94,12 @@ memory@9d400000 {
 			no-map;
 		};
 
-		rmtfs_mem: rmtfs-region@f0800000 {
+		qseecom_mem: memory@b2000000 {
+			reg = <0 0xb2000000 0 0x1800000>;
+			no-map;
+		};
+
+		rmtfs_mem: memory@f0801000 {
 			compatible = "qcom,rmtfs-mem";
 			reg = <0 0xf0800000 0 0x202000>;
 			qcom,use-guard-pages;
@@ -467,14 +467,22 @@ &mss_pil {
 	status = "okay";
 };
 
+&pm8998_gpios {
+	vol_up_pin_a: vol-up-active-state {
+		pins = "gpio6";
+		function = "normal";
+		input-enable;
+		bias-pull-up;
+		qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
+	};
+};
+
 &pm8998_resin {
 	linux,code = <KEY_VOLUMEDOWN>;
 	status = "okay";
 };
 
 &sdhc_2 {
-	status = "okay";
-
 	cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
 
 	pinctrl-names = "default";
@@ -482,26 +490,70 @@ &sdhc_2 {
 
 	vmmc-supply = <&vreg_l21a_2p95>;
 	vqmmc-supply = <&vddpx_2>;
+
+	status = "okay";
 };
 
-/*
- * UFS works partially and only with clk_ignore_unused.
- * Sometimes it crashes with I/O errors.
- */
-&ufs_mem_hc {
+/* PINCTRL - additions to nodes defined in sdm845.dtsi */
+
+&tlmm {
+	gpio-reserved-ranges = <28 4>, <81 4>;
+
+	sdc2_clk: sdc2-clk-state {
+		pins = "sdc2_clk";
+		bias-disable;
+
+		/*
+		 * It seems that mmc_test reports errors if drive
+		 * strength is not 16 on clk, cmd, and data pins.
+		 *
+		 * TODO: copy-pasted from mtp, try other values
+		 * on these devices.
+		 */
+		drive-strength = <16>;
+	};
+
+	sdc2_cmd: sdc2-cmd-state {
+		pins = "sdc2_cmd";
+		bias-pull-up;
+		drive-strength = <16>;
+	};
+
+	sdc2_data: sdc2-data-state {
+		pins = "sdc2_data";
+		bias-pull-up;
+		drive-strength = <16>;
+	};
+
+	sd_card_det_n: sd-card-det-n-state {
+		pins = "gpio126";
+		function = "gpio";
+		bias-pull-up;
+	};
+};
+
+&qupv3_id_0 {
 	status = "okay";
+};
 
+&qupv3_id_1 {
+	status = "okay";
+};
+
+&ufs_mem_hc {
 	reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
 
 	vcc-supply = <&vreg_l20a_2p95>;
 	vcc-max-microamp = <600000>;
-};
 
-&ufs_mem_phy {
 	status = "okay";
+};
 
+&ufs_mem_phy {
 	vdda-phy-supply = <&vdda_ufs1_core>;
 	vdda-pll-supply = <&vdda_ufs1_1p2>;
+
+	status = "okay";
 };
 
 &usb_1 {
@@ -514,8 +566,6 @@ &usb_1_dwc3 {
 };
 
 &usb_1_hsphy {
-	status = "okay";
-
 	vdd-supply = <&vdda_usb1_ss_core>;
 	vdda-pll-supply = <&vdda_qusb_hs0_1p8>;
 	vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>;
@@ -524,59 +574,29 @@ &usb_1_hsphy {
 	qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>;
 	qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>;
 	qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>;
-};
 
-&usb_1_qmpphy {
 	status = "okay";
+};
 
+&usb_1_qmpphy {
 	vdda-phy-supply = <&vdda_usb1_ss_1p2>;
 	vdda-pll-supply = <&vdda_usb1_ss_core>;
-};
-
-/* PINCTRL - additions to nodes defined in sdm845.dtsi */
-
-&tlmm {
-	gpio-reserved-ranges = <28 4>, <81 4>;
-
-	sdc2_clk: sdc2-clk-state {
-		pins = "sdc2_clk";
-		bias-disable;
 
-		/*
-		 * It seems that mmc_test reports errors if drive
-		 * strength is not 16 on clk, cmd, and data pins.
-		 *
-		 * TODO: copy-pasted from mtp, try other values
-		 * on these devices.
-		 */
-		drive-strength = <16>;
-	};
+	status = "okay";
+};
 
-	sdc2_cmd: sdc2-cmd-state {
-		pins = "sdc2_cmd";
-		bias-pull-up;
-		drive-strength = <16>;
-	};
+&venus {
+	status = "okay";
+};
 
-	sdc2_data: sdc2-data-state {
-		pins = "sdc2_data";
-		bias-pull-up;
-		drive-strength = <16>;
-	};
+&wifi {
+	vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 
-	sd_card_det_n: sd-card-det-n-state {
-		pins = "gpio126";
-		function = "gpio";
-		bias-pull-up;
-	};
-};
+	qcom,snoc-host-cap-skip-quirk;
 
-&pm8998_gpios {
-	vol_up_pin_a: vol-up-active-state {
-		pins = "gpio6";
-		function = "normal";
-		input-enable;
-		bias-pull-up;
-		qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
-	};
+	status = "okay";
 };

-- 
2.52.0

[PATCH v4 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth

[Paul Sajna]

uart9 is debug serial on USB SBU1/2

UART RX is SBU1 and UART TX is SBU2 of the USB-C port).
1.8V Logic Level
Tested using pololu usb07a https://www.pololu.com/product/2585
and CH340 USB-UART

uart6 is bluetooth

Bluetooth: hci0: setting up wcn399x
Bluetooth: hci0: QCA Product ID   :0x0000000a
Bluetooth: hci0: QCA SOC Version  :0x40010214
Bluetooth: hci0: QCA ROM Version  :0x00000201
Bluetooth: hci0: QCA Patch Version:0x00000001
Bluetooth: hci0: QCA controller version 0x02140201
Bluetooth: hci0: QCA Downloading qca/crbtfw21.tlv
Bluetooth: hci0: QCA Downloading qca/judyln/crnv21.bin
Bluetooth: hci0: QCA setup on UART is completed

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 39 ++++++++++++++++++++++++--
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  |  8 ++++++
 2 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index b8ab64a8de1c..cbd57eee6ffc 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -27,10 +27,17 @@
 /delete-node/ &wlan_msa_mem;
 
 / {
+	aliases {
+		serial0 = &uart9;
+		serial1 = &uart6;
+	};
+
 	chosen {
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
+
+		stdout-path = "serial0:115200n8";
 	};
 
 	reserved-memory {
@@ -540,6 +547,36 @@ &qupv3_id_1 {
 	status = "okay";
 };
 
+&qup_uart9_rx {
+	drive-strength = <2>;
+	bias-pull-up;
+};
+
+&qup_uart9_tx {
+	drive-strength = <2>;
+	bias-disable;
+};
+
+&uart6 {
+	pinctrl-0 = <&qup_uart6_4pin>;
+
+	status = "okay";
+
+	bluetooth: bluetooth {
+		compatible = "qcom,wcn3990-bt";
+
+		vddio-supply = <&vreg_s4a_1p8>;
+		vddxo-supply = <&vreg_l7a_1p8>;
+		vddrf-supply = <&vreg_l17a_1p3>;
+		vddch0-supply = <&vreg_l25a_3p3>;
+		max-speed = <3200000>;
+	};
+};
+
+&uart9 {
+	status = "okay";
+};
+
 &ufs_mem_hc {
 	reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
 
@@ -597,6 +634,4 @@ &wifi {
 	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 
 	qcom,snoc-host-cap-skip-quirk;
-
-	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 09bfcef42402..e530a08f5e27 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -43,6 +43,14 @@ &adsp_pas {
 	firmware-name = "qcom/sdm845/judyln/adsp.mbn";
 };
 
+&bluetooth {
+	/*
+	 * This path is relative to the qca/
+	 * subdir under lib/firmware.
+	 */
+	firmware-name = "judyln/crnv21.bin";
+};
+
 &cdsp_pas {
 	firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
 };

-- 
2.52.0

[PATCH v4 03/12] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger

[Paul Sajna]

From: Christopher Brown <crispybrown@gmail.com>

Values based on lineageos kernel

https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/arch/arm64/boot/dts/lge/sdm845-battery/LGE_BLT39_LGC_3000mAh.dtsi

Signed-off-by: Christopher Brown <crispybrown@gmail.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index e530a08f5e27..fa048937e396 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -37,6 +37,14 @@ key-thinq {
 			interrupts = <89 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
+
+	battery: battery {
+		compatible = "simple-battery";
+
+		charge-full-design-microamp-hours = <3000000>;
+		voltage-min-design-microvolt = <3200000>;
+		voltage-max-design-microvolt = <4400000>;
+	};
 };
 
 &adsp_pas {
@@ -63,6 +71,12 @@ &mss_pil {
 	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
 };
 
+&pmi8998_charger {
+	status = "okay";
+
+	monitored-battery = <&battery>;
+};
+
 &tlmm {
 	thinq_key_default: thinq-key-default-state {
 		pins = "gpio89";

-- 
2.52.0

[PATCH v4 04/12] arm64: dts: qcom: sdm845-lg-common: Add LEDs

[Paul Sajna]

From: Amir Dahan <system64fumo@protonmail.com>

Add the multicolor status LED in the phone's notch.

Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 28 ++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index cbd57eee6ffc..165523db4d49 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -6,6 +6,7 @@
  */
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 
@@ -489,6 +490,33 @@ &pm8998_resin {
 	status = "okay";
 };
 
+&pmi8998_lpg {
+	status = "okay";
+
+	multi-led {
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@3 {
+			reg = <3>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+
+		led@4 {
+			reg = <4>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@5 {
+			reg = <5>;
+			color = <LED_COLOR_ID_RED>;
+		};
+	};
+};
+
 &sdhc_2 {
 	cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
 

-- 
2.52.0

[PATCH v4 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel

[Paul Sajna]

Also include other supporting msm drm nodes, including backlight

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
Co-developed-by: Amir Dahan <system64fumo@protonmail.com>
Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi |  8 +--
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 75 +++++++++++++++++++++-----
 2 files changed, 66 insertions(+), 17 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 165523db4d49..50921af83a51 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -450,10 +450,6 @@ &cdsp_pas {
 	status = "okay";
 };
 
-&dispcc {
-	status = "disabled";
-};
-
 &gcc {
 	protected-clocks = <GCC_QSPI_CORE_CLK>,
 			   <GCC_QSPI_CORE_CLK_SRC>,
@@ -517,6 +513,10 @@ led@5 {
 	};
 };
 
+&pmi8998_wled {
+	status = "okay";
+};
+
 &sdhc_2 {
 	cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
 
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index fa048937e396..8e4214b83bf1 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -13,19 +13,6 @@ / {
 	model = "LG G7 ThinQ";
 	compatible = "lg,judyln", "qcom,sdm845";
 
-	chosen {
-		framebuffer@9d400000 {
-			compatible = "simple-framebuffer";
-			reg = <0x0 0x9d400000 0x0 (1440 * 3120 * 4)>;
-			width = <1440>;
-			height = <3120>;
-			stride = <(1440 * 4)>;
-			format = "a8r8g8b8";
-			lab-supply = <&lab>;
-			ibb-supply = <&ibb>;
-		};
-	};
-
 	/* Additional ThinQ key */
 	gpio-keys {
 		pinctrl-0 = <&vol_up_pin_a &thinq_key_default>;
@@ -67,6 +54,47 @@ &gpu_zap_shader {
 	firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dsi0 {
+	vdda-supply = <&vdda_mipi_dsi0_1p2>;
+
+	status = "okay";
+
+	display_panel: panel@0 {
+		reg = <0>;
+		compatible = "lg,sw49410-lh609qh1", "lg,sw49410";
+
+		backlight = <&pmi8998_wled>;
+		reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+		width-mm = <65>;
+		height-mm = <140>;
+
+		pinctrl-0 = <&sde_dsi_active &sde_te_active_sleep>;
+		pinctrl-1 = <&sde_dsi_sleep &sde_te_active_sleep>;
+		pinctrl-names = "default", "sleep";
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&mdss_dsi0_out>;
+			};
+		};
+	};
+};
+
+&mdss_dsi0_phy {
+	vdds-supply = <&vdda_mipi_dsi0_pll>;
+
+	status = "okay";
+};
+
+&mdss_dsi0_out {
+	remote-endpoint = <&panel_in>;
+	data-lanes = <0 1 2 3>;
+};
+
 &mss_pil {
 	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
 };
@@ -85,4 +113,25 @@ thinq_key_default: thinq-key-default-state {
 		drive-strength = <2>;
 		bias-pull-up;
 	};
+
+	sde_dsi_active: sde-dsi-active-state {
+		pins = "gpio6";
+		function = "gpio";
+		drive-strength = <8>;
+		bias-disable;
+	};
+
+	sde_dsi_sleep: sde-dsi-sleep-state {
+		pins = "gpio6";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	sde_te_active_sleep: sde-te-active-sleep-state {
+		pins = "gpio10";
+		function = "mdp_vsync";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
 };

-- 
2.52.0

[PATCH v4 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path

[Paul Sajna]

Add paths for Qualcomm firmware, including:
ipa, modem, bluetooth, venus, gpu

Enable adsp and cdsp nodes since their firmware is present

GPU and bluetooth are confirmed working, others may need more
testing/fixes

But regardless they will need the firmware paths specified here
and firmware added upstream before they will work, so might as well
get started on it now.

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 23 ++++++++++++++++++-----
 2 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 50921af83a51..315fdc5dc392 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -162,6 +162,10 @@ &adsp_pas {
 	status = "okay";
 };
 
+&cdsp_pas {
+	status = "okay";
+};
+
 &apps_rsc {
 	regulators-0 {
 		compatible = "qcom,pm8998-rpmh-regulators";
@@ -464,6 +468,8 @@ &gpu {
 
 &ipa {
 	qcom,gsi-loader = "modem";
+	memory-region = <&ipa_fw_mem>;
+
 	status = "okay";
 };
 
@@ -663,3 +669,7 @@ &wifi {
 
 	qcom,snoc-host-cap-skip-quirk;
 };
+
+&venus {
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 8e4214b83bf1..9ec2edf6134c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -35,7 +35,7 @@ battery: battery {
 };
 
 &adsp_pas {
-	firmware-name = "qcom/sdm845/judyln/adsp.mbn";
+	firmware-name = "qcom/sdm845/lg/judyln/adsp.mbn";
 };
 
 &bluetooth {
@@ -47,11 +47,17 @@ &bluetooth {
 };
 
 &cdsp_pas {
-	firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
+	firmware-name = "qcom/sdm845/lg/judyln/cdsp.mbn";
 };
 
-&gpu_zap_shader {
-	firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
+&gpu {
+	zap-shader {
+		firmware-name = "qcom/sdm845/lg/judyln/a630_zap.mbn";
+	};
+};
+
+&ipa {
+	firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
 };
 
 &mdss {
@@ -96,7 +102,7 @@ &mdss_dsi0_out {
 };
 
 &mss_pil {
-	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
+	firmware-name = "qcom/sdm845/lg/judyln/mba.mbn", "qcom/sdm845/lg/judyln/modem.mbn";
 };
 
 &pmi8998_charger {
@@ -135,3 +141,10 @@ sde_te_active_sleep: sde-te-active-sleep-state {
 		bias-pull-down;
 	};
 };
+<<<<<<< HEAD
+=======
+
+&venus {
+	firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
+};
+>>>>>>> d58184825fa5 (arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path)

-- 
2.52.0

[PATCH v4 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node

[Paul Sajna]

Wi-Fi now works with this patch and relevant firmware

ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001
ath10k_snoc 18800000.wifi: qmi fw_version 0x20060285 fw_build_timestamp 2020-10-12 23:35 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c4-00645-QCAHLSWMTPLZ-1.336037.2
ath10k_snoc 18800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
ath10k_snoc 18800000.wifi: kconfig debug 1 debugfs 1 tracing 0 dfs 0 testmode 0
ath10k_snoc 18800000.wifi: firmware ver  api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790
ath10k_snoc 18800000.wifi: htt-ver 3.83 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
ath10k_snoc 18800000.wifi: invalid MAC address; choosing random

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 12 ++++++++++++
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  |  7 ++++---
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 315fdc5dc392..f12e785db893 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -673,3 +673,15 @@ &wifi {
 &venus {
 	status = "okay";
 };
+
+&wifi {
+	vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
+
+	qcom,snoc-host-cap-skip-quirk;
+
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 9ec2edf6134c..a61f7bd65a7a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -141,10 +141,11 @@ sde_te_active_sleep: sde-te-active-sleep-state {
 		bias-pull-down;
 	};
 };
-<<<<<<< HEAD
-=======
 
 &venus {
 	firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
 };
->>>>>>> d58184825fa5 (arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path)
+
+&wifi {
+	qcom,calibration-variant = "lg_judyln";
+};

-- 
2.52.0

[PATCH v4 08/12] arm64: dts: qcom: sdm845-lg-common: Add chassis-type

[Paul Sajna]

The sdm845-lg devices are all phones, therefore handset chassis

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index f12e785db893..93b9a0246510 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -28,6 +28,8 @@
 /delete-node/ &wlan_msa_mem;
 
 / {
+	chassis-type = "handset";
+
 	aliases {
 		serial0 = &uart9;
 		serial1 = &uart6;

-- 
2.52.0

[PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

[Paul Sajna]

Camera doesn't work yet (imx351), but we can use the flash as a flashlight.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 93b9a0246510..fa664b5120d2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -494,6 +494,19 @@ &pm8998_resin {
 	status = "okay";
 };
 
+&pmi8998_flash {
+	status = "okay";
+
+	led-0 {
+		function = LED_FUNCTION_FLASH;
+		color = <LED_COLOR_ID_WHITE>;
+		led-sources = <1>;
+		led-max-microamp = <100000>;
+		flash-max-microamp = <500000>;
+		flash-max-timeout-us = <500000>;
+	};
+};
+
 &pmi8998_lpg {
 	status = "okay";
 

-- 
2.52.0

[PATCH v4 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb

[Paul Sajna]

These regulators are required for the LCD

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index a61f7bd65a7a..3188334d269b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -56,10 +56,27 @@ zap-shader {
 	};
 };
 
+&ibb {
+	regulator-min-microvolt = <4600000>;
+	regulator-max-microvolt = <6000000>;
+	regulator-over-current-protection;
+	regulator-pull-down;
+	regulator-soft-start;
+	qcom,discharge-resistor-kohms = <300>;
+};
+
 &ipa {
 	firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
 };
 
+&lab {
+	regulator-min-microvolt = <4600000>;
+	regulator-max-microvolt = <6000000>;
+	regulator-over-current-protection;
+	regulator-pull-down;
+	regulator-soft-start;
+};
+
 &mdss {
 	status = "okay";
 };

-- 
2.52.0

[PATCH v4 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self'

[Paul Sajna]

This lets modem get a bit closer to working

ipa 1e40000.ipa: channel 4 limited to 256 TREs
ipa 1e40000.ipa: IPA driver initialized
ipa 1e40000.ipa: received modem starting event
ipa 1e40000.ipa: received modem running event

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index fa664b5120d2..0ba4a2b42028 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -469,7 +469,7 @@ &gpu {
 };
 
 &ipa {
-	qcom,gsi-loader = "modem";
+	qcom,gsi-loader = "self";
 	memory-region = <&ipa_fw_mem>;
 
 	status = "okay";

-- 
2.52.0

[PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[Paul Sajna]

It causes this warning

[ 0.000000] OF: reserved mem: OVERLAP DETECTED!
framebuffer@9d400000
(0x000000009d400000--0x000000009f800000) overlaps with
memory@9d400000 (0x000000009d400000--0x000000009f800000)

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 0ba4a2b42028..472a0519c690 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -98,12 +98,6 @@ spss_mem: memory@99000000 {
 			no-map;
 		};
 
-		/* Framebuffer region */
-		memory@9d400000 {
-			reg = <0x0 0x9d400000 0x0 0x2400000>;
-			no-map;
-		};
-
 		qseecom_mem: memory@b2000000 {
 			reg = <0 0xb2000000 0 0x1800000>;
 			no-map;

-- 
2.52.0

Re: [PATCH v4 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path

[David Heidelberg]

On 25/11/2025 09:12, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, bluetooth, venus, gpu
> 
> Enable adsp and cdsp nodes since their firmware is present
> 
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
> 
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.
> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
>   arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 23 ++++++++++++++++++-----
>   2 files changed, 28 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 50921af83a51..315fdc5dc392 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -162,6 +162,10 @@ &adsp_pas {
>   	status = "okay";
>   };
>   
> +&cdsp_pas {
> +	status = "okay";
> +};
> +
>   &apps_rsc {
>   	regulators-0 {
>   		compatible = "qcom,pm8998-rpmh-regulators";
> @@ -464,6 +468,8 @@ &gpu {
>   
>   &ipa {
>   	qcom,gsi-loader = "modem";
> +	memory-region = <&ipa_fw_mem>;
> +
>   	status = "okay";
>   };
>   
> @@ -663,3 +669,7 @@ &wifi {
>   
>   	qcom,snoc-host-cap-skip-quirk;
>   };
> +
> +&venus {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 8e4214b83bf1..9ec2edf6134c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -35,7 +35,7 @@ battery: battery {
>   };
>   
>   &adsp_pas {
> -	firmware-name = "qcom/sdm845/judyln/adsp.mbn";
> +	firmware-name = "qcom/sdm845/lg/judyln/adsp.mbn";
>   };
>   
>   &bluetooth {
> @@ -47,11 +47,17 @@ &bluetooth {
>   };
>   
>   &cdsp_pas {
> -	firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
> +	firmware-name = "qcom/sdm845/lg/judyln/cdsp.mbn";
>   };
>   
> -&gpu_zap_shader {
> -	firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
> +&gpu {
> +	zap-shader {
> +		firmware-name = "qcom/sdm845/lg/judyln/a630_zap.mbn";
> +	};
> +};
> +
> +&ipa {
> +	firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
>   };
>   
>   &mdss {
> @@ -96,7 +102,7 @@ &mdss_dsi0_out {
>   };
>   
>   &mss_pil {
> -	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
> +	firmware-name = "qcom/sdm845/lg/judyln/mba.mbn", "qcom/sdm845/lg/judyln/modem.mbn";
>   };
>   
>   &pmi8998_charger {
> @@ -135,3 +141,10 @@ sde_te_active_sleep: sde-te-active-sleep-state {
>   		bias-pull-down;
>   	};
>   };
> +<<<<<<< HEAD
> +=======
> +
> +&venus {
> +	firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
> +};
> +>>>>>>> d58184825fa5 (arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path)

Accidental rebase leftovers, please remove in this patch.

I see it been removed in followup patch, but it's always best walk 
trough your patches one by one before sending.

David

P.S. Happy to see the quirk is useful.
> 

-- 
David Heidelberg

Re: [PATCH v4 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts

[Rob Herring]

On Tue, 25 Nov 2025 00:12:30 -0800, Paul Sajna wrote:
> Rollup of improved hardware support via devicetree for LG G7 ThinQ
> (judyln) from sdm845-mainline kernel fork
> 
> Notably, this patch-series enables full DRM acceleration and wifi,
> among other small improvements in individual commits
> 
> after this patch-series the main things that remain to be worked
> on include touchscreen, audio, and modem.
> 
> Depends upon panel driver patch-series https://lore.kernel.org/all/20250910-judyln-panel-v1-1-825c74403bbb@postmarketos.org/T/#r9a976ca01e309b6c03100e984a26a0ffc2fe2002
> 
> Depends upon qcom,snoc-host-cap-skip-quirk https://lore.kernel.org/all/20251110-skip-host-cam-qmi-req-v2-0-0daf485a987a@ixit.cz/T/
> 
> Co-developed-by: Amir Dahan <system64fumo@protonmail.com>
> Co-developed-by: Christopher Brown <crispybrown@gmail.com>
> Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
> Signed-off-by: Christopher Brown <crispybrown@gmail.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> Changes in v4:
> - add panel identifier in addition to ddic
> - make sde_te pull-down
> - fixup flash current
> - remove framebuffer reserved-mem
> - remove manual lower guard
> - depend upon https://lore.kernel.org/all/20251110-skip-host-cam-qmi-req-v2-0-0daf485a987a@ixit.cz/T
> - reword commits
> - Link to v3: https://lore.kernel.org/r/20250928-judyln-dts-v3-0-b14cf9e9a928@postmarketos.org
> 
> Changes in v3:
> - change firmware paths to lowercase 'lg' (matching dt-bindings)
> - fix signoffs
> - add wifi dmesg to commit message
> - remove regulator-always-on from ibb
> - remove framebuffer
> - remove msm ids
> - don't continue commit subject into commit messages
> - split bluetooth node
> - add sbu uart details to commit message
> - change ipa gsi-loader to self
> - Link to v2: https://lore.kernel.org/r/20250916-judyln-dts-v2-0-5e16e60263af@postmarketos.org
> 
> Changes in v2:
> - sort at the start
> - drop unnecessary labels
> - drop unnecessary gmu
> - multi-led
> - split fb-panel changes
> - expand upon firmware commit message
> - use qcom,calibration-variant instead of
>   qcom,ath10k-calibration-variant
> - change firmware paths to include "LG"
> - remove framebuffer reservation
> - add lab/ibb
> 
> - Link to v1: https://lore.kernel.org/r/20250913-judyln-dts-v1-0-23b4b7790dce@postmarketos.org
> 
> ---
> Amir Dahan (1):
>       arm64: dts: qcom: sdm845-lg-common: Add LEDs
> 
> Christopher Brown (1):
>       arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger
> 
> Paul Sajna (10):
>       arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties
>       arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
>       arm64: dts: qcom: sdm845-lg-judyln: Add display panel
>       arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
>       arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node
>       arm64: dts: qcom: sdm845-lg-common: Add chassis-type
>       arm64: dts: qcom: sdm845-lg-common: Add camera flash
>       arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
>       arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self'
>       arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem
> 
>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 238 ++++++++++++++++++-------
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 138 ++++++++++++--
>  2 files changed, 296 insertions(+), 80 deletions(-)
> ---
> base-commit: 3d53f9ca24dd7492fe88fd0f1a418e3dc8b03515
> change-id: 20250911-judyln-dts-17c41e59dc0f
> prerequisite-message-id: <20250910-judyln-panel-v1-1-825c74403bbb@postmarketos.org>
> prerequisite-patch-id: e51151ea7f8fdad6ad7d90713febc5c6b6fc4f9c
> prerequisite-patch-id: b3dd44250da9cd12bc5b2d0d7e865dbe19ceed92
> prerequisite-patch-id: fd6c8077806cb03fcf37d0e0d730314c2760e334
> prerequisite-message-id: <20251110-skip-host-cam-qmi-req-v2-0-0daf485a987a@ixit.cz>
> prerequisite-patch-id: 32934e043aa82e7dccdcb962037e78663eae24a6
> prerequisite-patch-id: 9c69ab29256c15a0e8ac1c3b9ef64b27661c7815
> prerequisite-patch-id: 8fce59716f5d0d873c3407937e4f852eb18c75f0
> 
> Best regards,
> --
> Paul Sajna <sajattack@postmarketos.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Deps: looking for dependencies matching 6 patch-ids
 Deps: Applying prerequisite patch: [PATCH 1/3] drm/panel: Add LG SW49410 Panel
 Deps: Applying prerequisite patch: [PATCH 2/3] dt-bindings: display: panel: Add devicetree documentation for lg,sw49410
 Deps: Applying prerequisite patch: [PATCH 3/3] Update MAINTAINERS for lg,sw49410
 Deps: Applying prerequisite patch: [PATCH v2 1/3] dt-bindings: wireless: ath10k: Introduce quirk to skip host cap QMI requests
 Deps: Applying prerequisite patch: [PATCH v2 2/3] ath10k: Introduce a devicetree quirk to skip host cap QMI requests
 Deps: Applying prerequisite patch: [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable ath10k host-cap skip quirk
 Base: base-commit 3d53f9ca24dd7492fe88fd0f1a418e3dc8b03515 not known, ignoring
 Base: attempting to guess base-commit...
 Base: tags/next-20251124 (exact match)
 Base: tags/next-20251124 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251125-judyln-dts-v4-0-a5a60500b267@postmarketos.org:

arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dtb: panel@0 (lg,sw49410-lh609qh1): compatible:0: 'lg,sw49410' was expected
	from schema $id: http://devicetree.org/schemas/display/panel/lg,sw49410.yaml
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dtb: panel@0 (lg,sw49410-lh609qh1): compatible: ['lg,sw49410-lh609qh1', 'lg,sw49410'] is too long
	from schema $id: http://devicetree.org/schemas/display/panel/lg,sw49410.yaml
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dtb: /soc@0/display-subsystem@ae00000/dsi@ae94000/panel@0: failed to match any schema with compatible: ['lg,sw49410-lh609qh1', 'lg,sw49410']

Re: [PATCH v4 03/12] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger

[Konrad Dybcio]

On 11/25/25 9:12 AM, Paul Sajna wrote:
> From: Christopher Brown <crispybrown@gmail.com>
> 
> Values based on lineageos kernel
> 
> https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/arch/arm64/boot/dts/lge/sdm845-battery/LGE_BLT39_LGC_3000mAh.dtsi
> 
> Signed-off-by: Christopher Brown <crispybrown@gmail.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index e530a08f5e27..fa048937e396 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -37,6 +37,14 @@ key-thinq {
>  			interrupts = <89 IRQ_TYPE_LEVEL_LOW>;
>  		};
>  	};
> +
> +	battery: battery {
> +		compatible = "simple-battery";
> +
> +		charge-full-design-microamp-hours = <3000000>;
> +		voltage-min-design-microvolt = <3200000>;
> +		voltage-max-design-microvolt = <4400000>;
> +	};
>  };
>  
>  &adsp_pas {
> @@ -63,6 +71,12 @@ &mss_pil {
>  	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
>  };
>  
> +&pmi8998_charger {
> +	status = "okay";
> +
> +	monitored-battery = <&battery>;

status should go last

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v4 04/12] arm64: dts: qcom: sdm845-lg-common: Add LEDs

[Konrad Dybcio]

On 11/25/25 9:12 AM, Paul Sajna wrote:
> From: Amir Dahan <system64fumo@protonmail.com>
> 
> Add the multicolor status LED in the phone's notch.
> 
> Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v4 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node

[Konrad Dybcio]

On 11/25/25 9:12 AM, Paul Sajna wrote:
> Wi-Fi now works with this patch and relevant firmware
> 
> ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001
> ath10k_snoc 18800000.wifi: qmi fw_version 0x20060285 fw_build_timestamp 2020-10-12 23:35 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c4-00645-QCAHLSWMTPLZ-1.336037.2
> ath10k_snoc 18800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
> ath10k_snoc 18800000.wifi: kconfig debug 1 debugfs 1 tracing 0 dfs 0 testmode 0
> ath10k_snoc 18800000.wifi: firmware ver  api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790
> ath10k_snoc 18800000.wifi: htt-ver 3.83 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
> ath10k_snoc 18800000.wifi: invalid MAC address; choosing random
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

without the merge conflict leftovers, ofc ;)

Konrad

[...]

> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 9ec2edf6134c..a61f7bd65a7a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -141,10 +141,11 @@ sde_te_active_sleep: sde-te-active-sleep-state {
>  		bias-pull-down;
>  	};
>  };
> -<<<<<<< HEAD
> -=======
>  
>  &venus {
>  	firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
>  };
> ->>>>>>> d58184825fa5 (arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path)
> +
> +&wifi {
> +	qcom,calibration-variant = "lg_judyln";
> +};
> 

Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

[Paul Sajna]

I did more testing on this, and the led only comes on if it's brightness is set to approx 150/255 or lower. In that case, should I set led-max-microamp to 60mA?



November 25, 2025 at 8:12 AM, "Paul Sajna" <sajattack@postmarketos.org mailto:sajattack@postmarketos.org?to=%22Paul%20Sajna%22%20%3Csajattack%40postmarketos.org%3E > wrote:


> 
> Camera doesn't work yet (imx351), but we can use the flash as a flashlight.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 93b9a0246510..fa664b5120d2 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -494,6 +494,19 @@ &pm8998_resin {
>  status = "okay";
>  };
>  
> +&pmi8998_flash {
> + status = "okay";
> +
> + led-0 {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + led-sources = <1>;
> + led-max-microamp = <100000>;
> + flash-max-microamp = <500000>;
> + flash-max-timeout-us = <500000>;
> + };
> +};
> +
>  &pmi8998_lpg {
>  status = "okay";
>  
> 
> -- 
> 2.52.0
>

Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

[Konrad Dybcio]

On 11/28/25 9:20 PM, Paul Sajna wrote:
> I did more testing on this, and the led only comes on if it's brightness is set to approx 150/255 or lower. In that case, should I set led-max-microamp to 60mA?

FWIW your downstream kernel sets up channels 0 and 1, here you only
enabled 1. Taking a look at a picture of the phone, I only see a single
LED on the back, so perhaps you're (over)driving a single power line?

I'm not a milion percent sure, but I would assume the current draw
*limiting* register applies to the sum of the current going through
the three channels because there's only a single instance of it.

Konrad

Re: [PATCH v4 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb

[Konrad Dybcio]

On 11/25/25 9:12 AM, Paul Sajna wrote:
> These regulators are required for the LCD
> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index a61f7bd65a7a..3188334d269b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -56,10 +56,27 @@ zap-shader {
>  	};
>  };
>  
> +&ibb {
> +	regulator-min-microvolt = <4600000>;
> +	regulator-max-microvolt = <6000000>;

Sorry for not responding earlier, you can retrieve the actual volt
numbers from the hardware by reading

PMI8998_IBB_REG_BASE + REG_LABIBB_VOLTAGE = 0xdc41

ibb_uV = 1.4 + .1 * val

PMI8998_LAB_REG_BASE + REG_LABIBB_VOLTAGE = 0xde41

lab_uV = 4.6 + .1 * val

Konrad

Re: [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[Konrad Dybcio]

On 11/25/25 9:12 AM, Paul Sajna wrote:
> It causes this warning
> 
> [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
> framebuffer@9d400000
> (0x000000009d400000--0x000000009f800000) overlaps with
> memory@9d400000 (0x000000009d400000--0x000000009f800000)
> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---

It's defined for both devices that include this dtsi.. perhaps you
could remove it from there

Konrad

Re: [PATCH v4 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel

[Konrad Dybcio]

On 11/25/25 9:12 AM, Paul Sajna wrote:
> Also include other supporting msm drm nodes, including backlight
> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> Co-developed-by: Amir Dahan <system64fumo@protonmail.com>
> Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v4 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb

[Paul Sajna]

December 1, 2025 at 12:38 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:

> Sorry for not responding earlier, you can retrieve the actual volt
> numbers from the hardware by reading
> 
> PMI8998_IBB_REG_BASE + REG_LABIBB_VOLTAGE = 0xdc41
> 
> ibb_uV = 1.4 + .1 * val
> 
> PMI8998_LAB_REG_BASE + REG_LABIBB_VOLTAGE = 0xde41
> 
> lab_uV = 4.6 + .1 * val
> 
> Konrad
>

I found it in sysfs along the lines of your previous suggestion instead.

```
1|judyln:/ # cat /sys/kernel/debug/regulator/c440000.qcom,spmi:qcom,pmi8998@3:qpnp-labibb-regulator-ibb_reg/voltage
5500000
judyln:/ # cat /sys/kernel/debug/regulator/c440000.qcom,spmi:qcom,pmi8998@3:qpnp-labibb-regulator-lab_reg/voltage
5500000
```

Re: [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[Paul Sajna]

December 1, 2025 at 12:41 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:


> 
> On 11/25/25 9:12 AM, Paul Sajna wrote:
> 
> > 
> > It causes this warning
> >  
> >  [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
> >  framebuffer@9d400000 mailto:framebuffer@9d400000 
> >  (0x000000009d400000--0x000000009f800000) overlaps with
> >  memory@9d400000 mailto:memory@9d400000  (0x000000009d400000--0x000000009f800000)
> >  
> >  Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> >  ---
> > 
> It's defined for both devices that include this dtsi.. perhaps you
> could remove it from there
> 
> Konrad
>

I don't have a judyp to test with and prefer to limit scope.

Re: [PATCH v4 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb

[Konrad Dybcio]

On 12/2/25 5:21 AM, Paul Sajna wrote:
> December 1, 2025 at 12:38 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> 
>> Sorry for not responding earlier, you can retrieve the actual volt
>> numbers from the hardware by reading
>>
>> PMI8998_IBB_REG_BASE + REG_LABIBB_VOLTAGE = 0xdc41
>>
>> ibb_uV = 1.4 + .1 * val
>>
>> PMI8998_LAB_REG_BASE + REG_LABIBB_VOLTAGE = 0xde41
>>
>> lab_uV = 4.6 + .1 * val
>>
>> Konrad
>>
> 
> I found it in sysfs along the lines of your previous suggestion instead.
> 
> ```
> 1|judyln:/ # cat /sys/kernel/debug/regulator/c440000.qcom,spmi:qcom,pmi8998@3:qpnp-labibb-regulator-ibb_reg/voltage
> 5500000
> judyln:/ # cat /sys/kernel/debug/regulator/c440000.qcom,spmi:qcom,pmi8998@3:qpnp-labibb-regulator-lab_reg/voltage
> 5500000
> ```

That works too

Konrad

Re: [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[Konrad Dybcio]

On 12/2/25 5:41 AM, Paul Sajna wrote:
> December 1, 2025 at 12:41 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> 
> 
>>
>> On 11/25/25 9:12 AM, Paul Sajna wrote:
>>
>>>
>>> It causes this warning
>>>  
>>>  [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
>>>  framebuffer@9d400000 mailto:framebuffer@9d400000 
>>>  (0x000000009d400000--0x000000009f800000) overlaps with
>>>  memory@9d400000 mailto:memory@9d400000  (0x000000009d400000--0x000000009f800000)
>>>  
>>>  Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>>  ---
>>>
>> It's defined for both devices that include this dtsi.. perhaps you
>> could remove it from there
>>
>> Konrad
>>
> 
> I don't have a judyp to test with and prefer to limit scope.

This is a mechanical change

Konrad

Re: [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[Paul Sajna]

December 2, 2025 at 10:34 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:


> 
> On 12/2/25 5:41 AM, Paul Sajna wrote:
> 
> > 
> > December 1, 2025 at 12:41 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> >  
> >  
> > 
> > > 
> > > On 11/25/25 9:12 AM, Paul Sajna wrote:
> > > 
> >  It causes this warning
> >  
> >  [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
> >  framebuffer@9d400000 mailto:framebuffer@9d400000 
> >  (0x000000009d400000--0x000000009f800000) overlaps with
> >  memory@9d400000 mailto:memory@9d400000 (0x000000009d400000--0x000000009f800000)
> >  
> >  Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> >  ---
> > 
> > > 
> > > It's defined for both devices that include this dtsi.. perhaps you
> > >  could remove it from there
> > > 
> > >  Konrad
> > > 
> >  
> >  I don't have a judyp to test with and prefer to limit scope.
> > 
> This is a mechanical change
> 
> Konrad
>

Sorry, I tried to have a look at what you meant but didn't quite understand. In this patch I changed the dtsi that is included by both already. I don't see any other reserved-mem nodes in judyp. Do you mean I should remove the framebuffer from judyp? I don't think that's wise since a panel driver isn't added as far as I know.

Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

[Paul Sajna]

linux-postmarketos-qcom-sdm845-6.16.7_p20251203010632-r0.apk


December 1, 2025 at 11:42 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:


> 
> On 11/28/25 9:20 PM, Paul Sajna wrote:
> 
> > 
> > I did more testing on this, and the led only comes on if it's brightness is set to approx 150/255 or lower. In that case, should I set led-max-microamp to 60mA?
> > 
> FWIW your downstream kernel sets up channels 0 and 1, here you only
> enabled 1. Taking a look at a picture of the phone, I only see a single
> LED on the back, so perhaps you're (over)driving a single power line?
> 
> I'm not a milion percent sure, but I would assume the current draw
> *limiting* register applies to the sum of the current going through
> the three channels because there's only a single instance of it.
> 
> Konrad
>

I tried setting up both, but only the one that was mapped as `led-sources = <2>` seemed to have any effect. Also it would confuse userspace flashlight apps if there were two I think. So I'll push v5 with just the one that does anything.

Re: [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[David Heidelberg]

On 03/12/2025 09:42, Paul Sajna wrote:
> December 2, 2025 at 10:34 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> 
> 
>>
>> On 12/2/25 5:41 AM, Paul Sajna wrote:
>>
>>>
>>> December 1, 2025 at 12:41 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
>>>   
>>>   
>>>
>>>>
>>>> On 11/25/25 9:12 AM, Paul Sajna wrote:
>>>>
>>>   It causes this warning
>>>   
>>>   [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
>>>   framebuffer@9d400000 mailto:framebuffer@9d400000
>>>   (0x000000009d400000--0x000000009f800000) overlaps with
>>>   memory@9d400000 mailto:memory@9d400000 (0x000000009d400000--0x000000009f800000)
>>>   
>>>   Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>>   ---
>>>
>>>>
>>>> It's defined for both devices that include this dtsi.. perhaps you
>>>>   could remove it from there
>>>>
>>>>   Konrad
>>>>
>>>   
>>>   I don't have a judyp to test with and prefer to limit scope.
>>>
>> This is a mechanical change
>>
>> Konrad
>>
> 
> Sorry, I tried to have a look at what you meant but didn't quite understand. In this patch I changed the dtsi that is included by both already. I don't see any other reserved-mem nodes in judyp. Do you mean I should remove the framebuffer from judyp? I don't think that's wise since a panel driver isn't added as far as I know.

I think this warning likely comes from sdm845-mainline repo, as it has 
extra patches, which trying to abstract framebuffer into sdm845.dtsi, 
where it likely conflicts, have you tried against clean 6.18-rcX or next?

David

Re: [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[David Heidelberg]

On 03/12/2025 11:37, David Heidelberg wrote:
> On 03/12/2025 09:42, Paul Sajna wrote:
>> December 2, 2025 at 10:34 AM, "Konrad Dybcio" 
>> <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com? 
>> to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > 
>> wrote:
>>
>>
>>>
>>> On 12/2/25 5:41 AM, Paul Sajna wrote:
>>>
>>>>
>>>> December 1, 2025 at 12:41 PM, "Konrad Dybcio" 
>>>> <konrad.dybcio@oss.qualcomm.com 
>>>> mailto:konrad.dybcio@oss.qualcomm.com? 
>>>> to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > 
>>>> wrote:
>>>>
>>>>>
>>>>> On 11/25/25 9:12 AM, Paul Sajna wrote:
>>>>>
>>>>   It causes this warning
>>>>   [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
>>>>   framebuffer@9d400000 mailto:framebuffer@9d400000
>>>>   (0x000000009d400000--0x000000009f800000) overlaps with
>>>>   memory@9d400000 mailto:memory@9d400000 
>>>> (0x000000009d400000--0x000000009f800000)
>>>>   Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>>>   ---
>>>>
>>>>>
>>>>> It's defined for both devices that include this dtsi.. perhaps you
>>>>>   could remove it from there
>>>>>
>>>>>   Konrad
>>>>>
>>>>   I don't have a judyp to test with and prefer to limit scope.
>>>>
>>> This is a mechanical change
>>>
>>> Konrad
>>>
>>
>> Sorry, I tried to have a look at what you meant but didn't quite 
>> understand. In this patch I changed the dtsi that is included by both 
>> already. I don't see any other reserved-mem nodes in judyp. Do you 
>> mean I should remove the framebuffer from judyp? I don't think that's 
>> wise since a panel driver isn't added as far as I know.
> 
> I think this warning likely comes from sdm845-mainline repo, as it has 
> extra patches, which trying to abstract framebuffer into sdm845.dtsi, 
> where it likely conflicts, have you tried against clean 6.18-rcX or next?

... or sdm845-next repo [1]?

I sent the patches moving framebuffer from sdm845-mainline repository as 
RFC [2], but so far it's not clear to me if these should go in or not.

David

[1] https://gitlab.com/sdm845/sdm845-next/-/commits/sdm845-next
[2] 
https://lore.kernel.org/all/20251117-commonize-framebuffer-v1-1-e4c099b383c9@ixit.cz/

> 
> David

-- 
David Heidelberg

Re: [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem

[Konrad Dybcio]

On 12/3/25 11:45 AM, David Heidelberg wrote:
> On 03/12/2025 11:37, David Heidelberg wrote:
>> On 03/12/2025 09:42, Paul Sajna wrote:
>>> December 2, 2025 at 10:34 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com? to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
>>>
>>>
>>>>
>>>> On 12/2/25 5:41 AM, Paul Sajna wrote:
>>>>
>>>>>
>>>>> December 1, 2025 at 12:41 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com? to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
>>>>>
>>>>>>
>>>>>> On 11/25/25 9:12 AM, Paul Sajna wrote:
>>>>>>
>>>>>   It causes this warning
>>>>>   [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
>>>>>   framebuffer@9d400000 mailto:framebuffer@9d400000
>>>>>   (0x000000009d400000--0x000000009f800000) overlaps with
>>>>>   memory@9d400000 mailto:memory@9d400000 (0x000000009d400000--0x000000009f800000)
>>>>>   Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>>>>   ---
>>>>>
>>>>>>
>>>>>> It's defined for both devices that include this dtsi.. perhaps you
>>>>>>   could remove it from there
>>>>>>
>>>>>>   Konrad
>>>>>>
>>>>>   I don't have a judyp to test with and prefer to limit scope.
>>>>>
>>>> This is a mechanical change
>>>>
>>>> Konrad
>>>>
>>>
>>> Sorry, I tried to have a look at what you meant but didn't quite understand. In this patch I changed the dtsi that is included by both already. I don't see any other reserved-mem nodes in judyp. Do you mean I should remove the framebuffer from judyp? I don't think that's wise since a panel driver isn't added as far as I know.
>>
>> I think this warning likely comes from sdm845-mainline repo, as it has extra patches, which trying to abstract framebuffer into sdm845.dtsi, where it likely conflicts, have you tried against clean 6.18-rcX or next?
> 
> ... or sdm845-next repo [1]?
> 
> I sent the patches moving framebuffer from sdm845-mainline repository as RFC [2], but so far it's not clear to me if these should go in or not.

Ok I only did a marginal amount of grepping and judyln/judyp define
framebuffer@9d400000 as the framebuffer device, while sdm845-lg-common
defines memory@9d400000 as a memory region. I assumed they were all the
latter.

I don't see any other framebuffer@9d400000 in sdm845.dtsi so perhaps
David is right..

Konrad

Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

[Konrad Dybcio]

On 12/3/25 10:27 AM, Paul Sajna wrote:
> linux-postmarketos-qcom-sdm845-6.16.7_p20251203010632-r0.apk
> 
> 
> December 1, 2025 at 11:42 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> 
> 
>>
>> On 11/28/25 9:20 PM, Paul Sajna wrote:
>>
>>>
>>> I did more testing on this, and the led only comes on if it's brightness is set to approx 150/255 or lower. In that case, should I set led-max-microamp to 60mA?
>>>
>> FWIW your downstream kernel sets up channels 0 and 1, here you only
>> enabled 1. Taking a look at a picture of the phone, I only see a single
>> LED on the back, so perhaps you're (over)driving a single power line?
>>
>> I'm not a milion percent sure, but I would assume the current draw
>> *limiting* register applies to the sum of the current going through
>> the three channels because there's only a single instance of it.
>>
>> Konrad
>>
> 
> I tried setting up both, but only the one that was mapped as `led-sources = <2>` seemed to have any effect. Also it would confuse userspace flashlight apps if there were two I think. So I'll push v5 with just the one that does anything.

led-sources is parsed into a bitmap and written into REG_MODULE_EN,
this doesn't translate into anything that's userspace-visible

That would instead be the case if you defined a pair of LEDs under
the device node (which is valid if there's two separate ones, such
as for some phones with a back and front LED flash)

Konrad

Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

[Paul Sajna]

December 4, 2025 at 9:17 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:

> led-sources is parsed into a bitmap and written into REG_MODULE_EN,
> this doesn't translate into anything that's userspace-visible
> 
> That would instead be the case if you defined a pair of LEDs under
> the device node (which is valid if there's two separate ones, such
> as for some phones with a back and front LED flash)
> 
> Konrad
>

so it should be led-sources = <1 2> or something? Under a single node?

Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

[Konrad Dybcio]

On 12/4/25 7:37 PM, Paul Sajna wrote:
> December 4, 2025 at 9:17 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> 
>> led-sources is parsed into a bitmap and written into REG_MODULE_EN,
>> this doesn't translate into anything that's userspace-visible
>>
>> That would instead be the case if you defined a pair of LEDs under
>> the device node (which is valid if there's two separate ones, such
>> as for some phones with a back and front LED flash)
>>
>> Konrad
>>
> 
> so it should be led-sources = <1 2> or something? Under a single node?

Eh of course what I said is wrong, it does indeed parse it, but in the
end it's a !!mask (if any enabled, enable the module)

but for your purposes, try "led-sources = <0>, <1>;" under a single node
that you have right now - the count also matters and it may just resolve
the presumably-overcurrent issue

Konrad