[PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[Taniya Das]

Update the RPMh VRM clock definitions for Glymur to add the suffix to
indicate the clock div and e0 for the C3A_E0, C4A_E0, C5A_E0, and
C8A_E0 clock resources.

Fixes: ebcb9db98bda ("clk: qcom: rpmh: Add support for Glymur rpmh clocks")
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
 drivers/clk/qcom/clk-rpmh.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 1a98b3a0c528c24b600326e6b951b2edb6dcadd7..a370ab2d96c34fa8e7a090e8427b11008318c02f 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -390,10 +390,10 @@ DEFINE_CLK_RPMH_VRM(clk7, _a4, "clka7", 4);
 
 DEFINE_CLK_RPMH_VRM(div_clk1, _div2, "divclka1", 2);
 
-DEFINE_CLK_RPMH_VRM(clk3, _a, "C3A_E0", 1);
-DEFINE_CLK_RPMH_VRM(clk4, _a, "C4A_E0", 1);
-DEFINE_CLK_RPMH_VRM(clk5, _a, "C5A_E0", 1);
-DEFINE_CLK_RPMH_VRM(clk8, _a, "C8A_E0", 1);
+DEFINE_CLK_RPMH_VRM(clk3, _a1_e0, "C3A_E0", 1);
+DEFINE_CLK_RPMH_VRM(clk4, _a1_e0, "C4A_E0", 1);
+DEFINE_CLK_RPMH_VRM(clk5, _a1_e0, "C5A_E0", 1);
+DEFINE_CLK_RPMH_VRM(clk8, _a1_e0, "C8A_E0", 1);
 
 DEFINE_CLK_RPMH_BCM(ce, "CE0");
 DEFINE_CLK_RPMH_BCM(hwkm, "HK0");

---
base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
change-id: 20251125-glymur_rpmhcc_fix-5daa36a1e8ff

Best regards,
-- 
Taniya Das <taniya.das@oss.qualcomm.com>

Re: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[Dmitry Baryshkov]

On Tue, Nov 25, 2025 at 11:42:39PM +0530, Taniya Das wrote:
> Update the RPMh VRM clock definitions for Glymur to add the suffix to
> indicate the clock div and e0 for the C3A_E0, C4A_E0, C5A_E0, and
> C8A_E0 clock resources.
> 
> Fixes: ebcb9db98bda ("clk: qcom: rpmh: Add support for Glymur rpmh clocks")

It's not a bug, there is nothing to fix.

> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/clk-rpmh.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 1a98b3a0c528c24b600326e6b951b2edb6dcadd7..a370ab2d96c34fa8e7a090e8427b11008318c02f 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -390,10 +390,10 @@ DEFINE_CLK_RPMH_VRM(clk7, _a4, "clka7", 4);
>  
>  DEFINE_CLK_RPMH_VRM(div_clk1, _div2, "divclka1", 2);
>  
> -DEFINE_CLK_RPMH_VRM(clk3, _a, "C3A_E0", 1);
> -DEFINE_CLK_RPMH_VRM(clk4, _a, "C4A_E0", 1);
> -DEFINE_CLK_RPMH_VRM(clk5, _a, "C5A_E0", 1);
> -DEFINE_CLK_RPMH_VRM(clk8, _a, "C8A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk3, _a1_e0, "C3A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk4, _a1_e0, "C4A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk5, _a1_e0, "C5A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk8, _a1_e0, "C8A_E0", 1);
>  
>  DEFINE_CLK_RPMH_BCM(ce, "CE0");
>  DEFINE_CLK_RPMH_BCM(hwkm, "HK0");
> 
> ---
> base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
> change-id: 20251125-glymur_rpmhcc_fix-5daa36a1e8ff
> 
> Best regards,
> -- 
> Taniya Das <taniya.das@oss.qualcomm.com>
> 

-- 
With best wishes
Dmitry

Re: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[Taniya Das]

On 11/25/2025 11:56 PM, Dmitry Baryshkov wrote:
> On Tue, Nov 25, 2025 at 11:42:39PM +0530, Taniya Das wrote:
>> Update the RPMh VRM clock definitions for Glymur to add the suffix to
>> indicate the clock div and e0 for the C3A_E0, C4A_E0, C5A_E0, and
>> C8A_E0 clock resources.
>>
>> Fixes: ebcb9db98bda ("clk: qcom: rpmh: Add support for Glymur rpmh clocks")
> 
> It's not a bug, there is nothing to fix.
> 

Will remove the fixes tag.

>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>> ---
>>  drivers/clk/qcom/clk-rpmh.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
>> index 1a98b3a0c528c24b600326e6b951b2edb6dcadd7..a370ab2d96c34fa8e7a090e8427b11008318c02f 100644
>> --- a/drivers/clk/qcom/clk-rpmh.c
>> +++ b/drivers/clk/qcom/clk-rpmh.c
>> @@ -390,10 +390,10 @@ DEFINE_CLK_RPMH_VRM(clk7, _a4, "clka7", 4);
>>  
>>  DEFINE_CLK_RPMH_VRM(div_clk1, _div2, "divclka1", 2);
>>  
>> -DEFINE_CLK_RPMH_VRM(clk3, _a, "C3A_E0", 1);
>> -DEFINE_CLK_RPMH_VRM(clk4, _a, "C4A_E0", 1);
>> -DEFINE_CLK_RPMH_VRM(clk5, _a, "C5A_E0", 1);
>> -DEFINE_CLK_RPMH_VRM(clk8, _a, "C8A_E0", 1);
>> +DEFINE_CLK_RPMH_VRM(clk3, _a1_e0, "C3A_E0", 1);
>> +DEFINE_CLK_RPMH_VRM(clk4, _a1_e0, "C4A_E0", 1);
>> +DEFINE_CLK_RPMH_VRM(clk5, _a1_e0, "C5A_E0", 1);
>> +DEFINE_CLK_RPMH_VRM(clk8, _a1_e0, "C8A_E0", 1);
>>  
>>  DEFINE_CLK_RPMH_BCM(ce, "CE0");
>>  DEFINE_CLK_RPMH_BCM(hwkm, "HK0");
>>
>> ---
>> base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
>> change-id: 20251125-glymur_rpmhcc_fix-5daa36a1e8ff
>>
>> Best regards,
>> -- 
>> Taniya Das <taniya.das@oss.qualcomm.com>
>>
> 

-- 
Thanks,
Taniya Das

Re: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[kernel test robot]

Hi Taniya,

kernel test robot noticed the following build errors:

[auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Taniya-Das/clk-qcom-clk-rpmh-Update-the-clock-suffix-for-Glymur/20251126-021404
base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
patch link:    https://lore.kernel.org/r/20251125-glymur_rpmhcc_fix-v1-1-60081b3cce7f%40oss.qualcomm.com
patch subject: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur
config: arm-randconfig-002-20251127 (https://download.01.org/0day-ci/archive/20251127/202511271512.D8UQpGul-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511271512.D8UQpGul-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511271512.D8UQpGul-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/clk/qcom/clk-rpmh.c:891:21: error: use of undeclared identifier 'clk_rpmh_clk3_a'
     891 |         [RPMH_RF_CLK3]          = &clk_rpmh_clk3_a.hw,
         |                                    ^~~~~~~~~~~~~~~
>> drivers/clk/qcom/clk-rpmh.c:892:22: error: use of undeclared identifier 'clk_rpmh_clk3_a_ao'
     892 |         [RPMH_RF_CLK3_A]        = &clk_rpmh_clk3_a_ao.hw,
         |                                    ^~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/clk-rpmh.c:893:21: error: use of undeclared identifier 'clk_rpmh_clk4_a'
     893 |         [RPMH_RF_CLK4]          = &clk_rpmh_clk4_a.hw,
         |                                    ^~~~~~~~~~~~~~~
>> drivers/clk/qcom/clk-rpmh.c:894:22: error: use of undeclared identifier 'clk_rpmh_clk4_a_ao'
     894 |         [RPMH_RF_CLK4_A]        = &clk_rpmh_clk4_a_ao.hw,
         |                                    ^~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/clk-rpmh.c:895:21: error: use of undeclared identifier 'clk_rpmh_clk5_a'
     895 |         [RPMH_RF_CLK5]          = &clk_rpmh_clk5_a.hw,
         |                                    ^~~~~~~~~~~~~~~
>> drivers/clk/qcom/clk-rpmh.c:896:22: error: use of undeclared identifier 'clk_rpmh_clk5_a_ao'
     896 |         [RPMH_RF_CLK5_A]        = &clk_rpmh_clk5_a_ao.hw,
         |                                    ^~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/clk-rpmh.c:901:14: error: invalid application of 'sizeof' to an incomplete type 'struct clk_hw *[]'
     901 |         .num_clks = ARRAY_SIZE(glymur_rpmh_clocks),
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/array_size.h:11:32: note: expanded from macro 'ARRAY_SIZE'
      11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
         |                                ^~~~~
   7 errors generated.


vim +/clk_rpmh_clk3_a +891 drivers/clk/qcom/clk-rpmh.c

c035a9e265dd80 Taniya Das 2024-12-04  887  
ebcb9db98bdab8 Taniya Das 2025-08-25  888  static struct clk_hw *glymur_rpmh_clocks[] = {
ebcb9db98bdab8 Taniya Das 2025-08-25  889  	[RPMH_CXO_CLK]		= &clk_rpmh_bi_tcxo_div2.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25  890  	[RPMH_CXO_CLK_A]	= &clk_rpmh_bi_tcxo_div2_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @891  	[RPMH_RF_CLK3]		= &clk_rpmh_clk3_a.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @892  	[RPMH_RF_CLK3_A]	= &clk_rpmh_clk3_a_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @893  	[RPMH_RF_CLK4]		= &clk_rpmh_clk4_a.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @894  	[RPMH_RF_CLK4_A]	= &clk_rpmh_clk4_a_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @895  	[RPMH_RF_CLK5]		= &clk_rpmh_clk5_a.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @896  	[RPMH_RF_CLK5_A]	= &clk_rpmh_clk5_a_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25  897  };
ebcb9db98bdab8 Taniya Das 2025-08-25  898  
ebcb9db98bdab8 Taniya Das 2025-08-25  899  static const struct clk_rpmh_desc clk_rpmh_glymur = {
ebcb9db98bdab8 Taniya Das 2025-08-25  900  	.clks = glymur_rpmh_clocks,
ebcb9db98bdab8 Taniya Das 2025-08-25 @901  	.num_clks = ARRAY_SIZE(glymur_rpmh_clocks),
ebcb9db98bdab8 Taniya Das 2025-08-25  902  };
ebcb9db98bdab8 Taniya Das 2025-08-25  903  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[kernel test robot]

Hi Taniya,

kernel test robot noticed the following build errors:

[auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Taniya-Das/clk-qcom-clk-rpmh-Update-the-clock-suffix-for-Glymur/20251126-021404
base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
patch link:    https://lore.kernel.org/r/20251125-glymur_rpmhcc_fix-v1-1-60081b3cce7f%40oss.qualcomm.com
patch subject: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur
config: arm64-randconfig-003-20251127 (https://download.01.org/0day-ci/archive/20251128/202511280306.L2l4tAmD-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251128/202511280306.L2l4tAmD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511280306.L2l4tAmD-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/clk/qcom/clk-rpmh.c:891:21: error: 'clk_rpmh_clk3_a' undeclared here (not in a function); did you mean 'clk_rpmh_clk3_a2'?
     891 |  [RPMH_RF_CLK3]  = &clk_rpmh_clk3_a.hw,
         |                     ^~~~~~~~~~~~~~~
         |                     clk_rpmh_clk3_a2
>> drivers/clk/qcom/clk-rpmh.c:892:22: error: 'clk_rpmh_clk3_a_ao' undeclared here (not in a function); did you mean 'clk_rpmh_clk3_a2_ao'?
     892 |  [RPMH_RF_CLK3_A] = &clk_rpmh_clk3_a_ao.hw,
         |                      ^~~~~~~~~~~~~~~~~~
         |                      clk_rpmh_clk3_a2_ao
>> drivers/clk/qcom/clk-rpmh.c:893:21: error: 'clk_rpmh_clk4_a' undeclared here (not in a function); did you mean 'clk_rpmh_clk4_a2'?
     893 |  [RPMH_RF_CLK4]  = &clk_rpmh_clk4_a.hw,
         |                     ^~~~~~~~~~~~~~~
         |                     clk_rpmh_clk4_a2
>> drivers/clk/qcom/clk-rpmh.c:894:22: error: 'clk_rpmh_clk4_a_ao' undeclared here (not in a function); did you mean 'clk_rpmh_clk4_a2_ao'?
     894 |  [RPMH_RF_CLK4_A] = &clk_rpmh_clk4_a_ao.hw,
         |                      ^~~~~~~~~~~~~~~~~~
         |                      clk_rpmh_clk4_a2_ao
>> drivers/clk/qcom/clk-rpmh.c:895:21: error: 'clk_rpmh_clk5_a' undeclared here (not in a function); did you mean 'clk_rpmh_clk5_a2'?
     895 |  [RPMH_RF_CLK5]  = &clk_rpmh_clk5_a.hw,
         |                     ^~~~~~~~~~~~~~~
         |                     clk_rpmh_clk5_a2
>> drivers/clk/qcom/clk-rpmh.c:896:22: error: 'clk_rpmh_clk5_a_ao' undeclared here (not in a function); did you mean 'clk_rpmh_clk5_a2_ao'?
     896 |  [RPMH_RF_CLK5_A] = &clk_rpmh_clk5_a_ao.hw,
         |                      ^~~~~~~~~~~~~~~~~~
         |                      clk_rpmh_clk5_a2_ao


vim +891 drivers/clk/qcom/clk-rpmh.c

c035a9e265dd80 Taniya Das 2024-12-04  887  
ebcb9db98bdab8 Taniya Das 2025-08-25  888  static struct clk_hw *glymur_rpmh_clocks[] = {
ebcb9db98bdab8 Taniya Das 2025-08-25  889  	[RPMH_CXO_CLK]		= &clk_rpmh_bi_tcxo_div2.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25  890  	[RPMH_CXO_CLK_A]	= &clk_rpmh_bi_tcxo_div2_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @891  	[RPMH_RF_CLK3]		= &clk_rpmh_clk3_a.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @892  	[RPMH_RF_CLK3_A]	= &clk_rpmh_clk3_a_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @893  	[RPMH_RF_CLK4]		= &clk_rpmh_clk4_a.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @894  	[RPMH_RF_CLK4_A]	= &clk_rpmh_clk4_a_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @895  	[RPMH_RF_CLK5]		= &clk_rpmh_clk5_a.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25 @896  	[RPMH_RF_CLK5_A]	= &clk_rpmh_clk5_a_ao.hw,
ebcb9db98bdab8 Taniya Das 2025-08-25  897  };
ebcb9db98bdab8 Taniya Das 2025-08-25  898  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[Taniya Das]

On 11/28/2025 12:59 AM, kernel test robot wrote:
> Hi Taniya,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Taniya-Das/clk-qcom-clk-rpmh-Update-the-clock-suffix-for-Glymur/20251126-021404
> base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
> patch link:    https://lore.kernel.org/r/20251125-glymur_rpmhcc_fix-v1-1-60081b3cce7f%40oss.qualcomm.com
> patch subject: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur
> config: arm64-randconfig-003-20251127 (https://download.01.org/0day-ci/archive/20251128/202511280306.L2l4tAmD-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 9.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251128/202511280306.L2l4tAmD-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202511280306.L2l4tAmD-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/clk/qcom/clk-rpmh.c:891:21: error: 'clk_rpmh_clk3_a' undeclared here (not in a function); did you mean 'clk_rpmh_clk3_a2'?
>      891 |  [RPMH_RF_CLK3]  = &clk_rpmh_clk3_a.hw,
>          |                     ^~~~~~~~~~~~~~~
>          |                     clk_rpmh_clk3_a2
>>> drivers/clk/qcom/clk-rpmh.c:892:22: error: 'clk_rpmh_clk3_a_ao' undeclared here (not in a function); did you mean 'clk_rpmh_clk3_a2_ao'?
>      892 |  [RPMH_RF_CLK3_A] = &clk_rpmh_clk3_a_ao.hw,
>          |                      ^~~~~~~~~~~~~~~~~~
>          |                      clk_rpmh_clk3_a2_ao
>>> drivers/clk/qcom/clk-rpmh.c:893:21: error: 'clk_rpmh_clk4_a' undeclared here (not in a function); did you mean 'clk_rpmh_clk4_a2'?
>      893 |  [RPMH_RF_CLK4]  = &clk_rpmh_clk4_a.hw,
>          |                     ^~~~~~~~~~~~~~~
>          |                     clk_rpmh_clk4_a2
>>> drivers/clk/qcom/clk-rpmh.c:894:22: error: 'clk_rpmh_clk4_a_ao' undeclared here (not in a function); did you mean 'clk_rpmh_clk4_a2_ao'?
>      894 |  [RPMH_RF_CLK4_A] = &clk_rpmh_clk4_a_ao.hw,
>          |                      ^~~~~~~~~~~~~~~~~~
>          |                      clk_rpmh_clk4_a2_ao
>>> drivers/clk/qcom/clk-rpmh.c:895:21: error: 'clk_rpmh_clk5_a' undeclared here (not in a function); did you mean 'clk_rpmh_clk5_a2'?
>      895 |  [RPMH_RF_CLK5]  = &clk_rpmh_clk5_a.hw,
>          |                     ^~~~~~~~~~~~~~~
>          |                     clk_rpmh_clk5_a2
>>> drivers/clk/qcom/clk-rpmh.c:896:22: error: 'clk_rpmh_clk5_a_ao' undeclared here (not in a function); did you mean 'clk_rpmh_clk5_a2_ao'?
>      896 |  [RPMH_RF_CLK5_A] = &clk_rpmh_clk5_a_ao.hw,
>          |                      ^~~~~~~~~~~~~~~~~~
>          |                      clk_rpmh_clk5_a2_ao
> 
> 
> vim +891 drivers/clk/qcom/clk-rpmh.c
> 
> c035a9e265dd80 Taniya Das 2024-12-04  887  
> ebcb9db98bdab8 Taniya Das 2025-08-25  888  static struct clk_hw *glymur_rpmh_clocks[] = {
> ebcb9db98bdab8 Taniya Das 2025-08-25  889  	[RPMH_CXO_CLK]		= &clk_rpmh_bi_tcxo_div2.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25  890  	[RPMH_CXO_CLK_A]	= &clk_rpmh_bi_tcxo_div2_ao.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25 @891  	[RPMH_RF_CLK3]		= &clk_rpmh_clk3_a.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25 @892  	[RPMH_RF_CLK3_A]	= &clk_rpmh_clk3_a_ao.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25 @893  	[RPMH_RF_CLK4]		= &clk_rpmh_clk4_a.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25 @894  	[RPMH_RF_CLK4_A]	= &clk_rpmh_clk4_a_ao.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25 @895  	[RPMH_RF_CLK5]		= &clk_rpmh_clk5_a.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25 @896  	[RPMH_RF_CLK5_A]	= &clk_rpmh_clk5_a_ao.hw,
> ebcb9db98bdab8 Taniya Das 2025-08-25  897  };
> ebcb9db98bdab8 Taniya Das 2025-08-25  898  
> 




It is fixed in
https://lore.kernel.org/lkml/20251126-gcc_kaanapali-v3-v4-1-0fe73d6898e9@oss.qualcomm.com/
and it is pulled in the series:
https://lore.kernel.org/lkml/20251126-gcc_kaanapali-v3-v4-1-0fe73d6898e9@oss.qualcomm.com/

-- 
Thanks,
Taniya Das

Re: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[Bjorn Andersson]

On Tue, Nov 25, 2025 at 11:42:39PM +0530, Taniya Das wrote:
> Update the RPMh VRM clock definitions for Glymur to add the suffix to
> indicate the clock div and e0 for the C3A_E0, C4A_E0, C5A_E0, and
> C8A_E0 clock resources.

This clearly explain what the patch does, but could you please start the
commit message with a paragraph (or sentence) that explains why this
change is done?

Regards,
Bjorn

> 
> Fixes: ebcb9db98bda ("clk: qcom: rpmh: Add support for Glymur rpmh clocks")
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/clk-rpmh.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 1a98b3a0c528c24b600326e6b951b2edb6dcadd7..a370ab2d96c34fa8e7a090e8427b11008318c02f 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -390,10 +390,10 @@ DEFINE_CLK_RPMH_VRM(clk7, _a4, "clka7", 4);
>  
>  DEFINE_CLK_RPMH_VRM(div_clk1, _div2, "divclka1", 2);
>  
> -DEFINE_CLK_RPMH_VRM(clk3, _a, "C3A_E0", 1);
> -DEFINE_CLK_RPMH_VRM(clk4, _a, "C4A_E0", 1);
> -DEFINE_CLK_RPMH_VRM(clk5, _a, "C5A_E0", 1);
> -DEFINE_CLK_RPMH_VRM(clk8, _a, "C8A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk3, _a1_e0, "C3A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk4, _a1_e0, "C4A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk5, _a1_e0, "C5A_E0", 1);
> +DEFINE_CLK_RPMH_VRM(clk8, _a1_e0, "C8A_E0", 1);
>  
>  DEFINE_CLK_RPMH_BCM(ce, "CE0");
>  DEFINE_CLK_RPMH_BCM(hwkm, "HK0");
> 
> ---
> base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
> change-id: 20251125-glymur_rpmhcc_fix-5daa36a1e8ff
> 
> Best regards,
> -- 
> Taniya Das <taniya.das@oss.qualcomm.com>
> 

Re: [PATCH] clk: qcom: clk-rpmh: Update the clock suffix for Glymur

[Bjorn Andersson]

On Wed, Dec 17, 2025 at 06:39:00PM -0800, Bjorn Andersson wrote:
> On Tue, Nov 25, 2025 at 11:42:39PM +0530, Taniya Das wrote:
> > Update the RPMh VRM clock definitions for Glymur to add the suffix to
> > indicate the clock div and e0 for the C3A_E0, C4A_E0, C5A_E0, and
> > C8A_E0 clock resources.
> 
> This clearly explain what the patch does, but could you please start the
> commit message with a paragraph (or sentence) that explains why this
> change is done?
> 

Never mind, I figured out that you have resubmitted this patch as
20251209-gcc_kaanapali-v3-v5-1-3af118262289@oss.qualcomm.com, but in
some way that patchwork wasn't able to detect that they are the same
patch.

Thanks for addressing my request in that version.

Regards,
Bjorn

> Regards,
> Bjorn
> 
> > 
> > Fixes: ebcb9db98bda ("clk: qcom: rpmh: Add support for Glymur rpmh clocks")
> > Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> > ---
> >  drivers/clk/qcom/clk-rpmh.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> > index 1a98b3a0c528c24b600326e6b951b2edb6dcadd7..a370ab2d96c34fa8e7a090e8427b11008318c02f 100644
> > --- a/drivers/clk/qcom/clk-rpmh.c
> > +++ b/drivers/clk/qcom/clk-rpmh.c
> > @@ -390,10 +390,10 @@ DEFINE_CLK_RPMH_VRM(clk7, _a4, "clka7", 4);
> >  
> >  DEFINE_CLK_RPMH_VRM(div_clk1, _div2, "divclka1", 2);
> >  
> > -DEFINE_CLK_RPMH_VRM(clk3, _a, "C3A_E0", 1);
> > -DEFINE_CLK_RPMH_VRM(clk4, _a, "C4A_E0", 1);
> > -DEFINE_CLK_RPMH_VRM(clk5, _a, "C5A_E0", 1);
> > -DEFINE_CLK_RPMH_VRM(clk8, _a, "C8A_E0", 1);
> > +DEFINE_CLK_RPMH_VRM(clk3, _a1_e0, "C3A_E0", 1);
> > +DEFINE_CLK_RPMH_VRM(clk4, _a1_e0, "C4A_E0", 1);
> > +DEFINE_CLK_RPMH_VRM(clk5, _a1_e0, "C5A_E0", 1);
> > +DEFINE_CLK_RPMH_VRM(clk8, _a1_e0, "C8A_E0", 1);
> >  
> >  DEFINE_CLK_RPMH_BCM(ce, "CE0");
> >  DEFINE_CLK_RPMH_BCM(hwkm, "HK0");
> > 
> > ---
> > base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
> > change-id: 20251125-glymur_rpmhcc_fix-5daa36a1e8ff
> > 
> > Best regards,
> > -- 
> > Taniya Das <taniya.das@oss.qualcomm.com>
> >