* [PATCH 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation
2025-09-30 14:32 [PATCH 0/6] Further bringup of SHIFTphone 8 Luca Weiss
@ 2025-09-30 14:32 ` Luca Weiss
2025-10-01 8:24 ` Konrad Dybcio
2025-09-30 14:32 ` [PATCH 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays Luca Weiss
` (4 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: Luca Weiss @ 2025-09-30 14:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
From: Alexander Martinz <amartinz@shiftphones.com>
Make sure the nodes are sorted correctly, and the indentation is
correct.
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index eb8efba1b9dda422dd0295db2a52420a1a23d070..8d45e6ac0e445b9e20bb9c1520f804623c505653 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -857,7 +857,7 @@ &uart5 {
&uart7 {
/delete-property/interrupts;
interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>,
- <&tlmm 31 IRQ_TYPE_EDGE_FALLING>;
+ <&tlmm 31 IRQ_TYPE_EDGE_FALLING>;
pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>, <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>;
pinctrl-names = "default", "sleep";
@@ -920,10 +920,6 @@ &usb_1_dwc3_hs {
remote-endpoint = <&pmic_glink_hs_in>;
};
-&usb_dp_qmpphy_out {
- remote-endpoint = <&pmic_glink_ss_in>;
-};
-
&usb_1_hsphy {
vdda-pll-supply = <&vreg_l10c>;
vdda18-supply = <&vreg_l1c>;
@@ -950,6 +946,10 @@ &usb_1_qmpphy {
status = "okay";
};
+&usb_dp_qmpphy_out {
+ remote-endpoint = <&pmic_glink_ss_in>;
+};
+
&wifi {
qcom,calibration-variant = "SHIFTphone_8";
--
2.51.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation
2025-09-30 14:32 ` [PATCH 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation Luca Weiss
@ 2025-10-01 8:24 ` Konrad Dybcio
0 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:24 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
>
> Make sure the nodes are sorted correctly, and the indentation is
> correct.
>
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays
2025-09-30 14:32 [PATCH 0/6] Further bringup of SHIFTphone 8 Luca Weiss
2025-09-30 14:32 ` [PATCH 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation Luca Weiss
@ 2025-09-30 14:32 ` Luca Weiss
2025-10-01 8:26 ` Konrad Dybcio
2025-09-30 14:32 ` [PATCH 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory Luca Weiss
` (3 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: Luca Weiss @ 2025-09-30 14:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
From: Alexander Martinz <amartinz@shiftphones.com>
As with all other devices in commit 7747a49db7e5 ("arm64: dts: qcom:
sc7280-*: Remove thermal zone polling delays"), apply the same change to
this device.
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 8d45e6ac0e445b9e20bb9c1520f804623c505653..2efcfb631c3683456794b0a0cc5686f00efd329c 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -131,7 +131,7 @@ rmtfs_mem: rmtfs@f8500000 {
thermal-zones {
camera-thermal {
polling-delay-passive = <0>;
- polling-delay = <0>;
+
thermal-sensors = <&pmk8350_adc_tm 2>;
trips {
@@ -145,7 +145,7 @@ active-config0 {
chg-skin-thermal {
polling-delay-passive = <0>;
- polling-delay = <0>;
+
thermal-sensors = <&pm7250b_adc_tm 0>;
trips {
@@ -159,7 +159,7 @@ active-config0 {
conn-thermal {
polling-delay-passive = <0>;
- polling-delay = <0>;
+
thermal-sensors = <&pm7250b_adc_tm 1>;
trips {
@@ -173,7 +173,7 @@ active-config0 {
quiet-thermal {
polling-delay-passive = <0>;
- polling-delay = <0>;
+
thermal-sensors = <&pmk8350_adc_tm 1>;
trips {
@@ -187,7 +187,7 @@ active-config0 {
rear-cam-thermal {
polling-delay-passive = <0>;
- polling-delay = <0>;
+
thermal-sensors = <&pmk8350_adc_tm 4>;
trips {
@@ -201,7 +201,7 @@ active-config0 {
sdm-skin-thermal {
polling-delay-passive = <0>;
- polling-delay = <0>;
+
thermal-sensors = <&pmk8350_adc_tm 3>;
trips {
@@ -215,7 +215,7 @@ active-config0 {
xo-thermal {
polling-delay-passive = <0>;
- polling-delay = <0>;
+
thermal-sensors = <&pmk8350_adc_tm 0>;
trips {
--
2.51.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays
2025-09-30 14:32 ` [PATCH 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays Luca Weiss
@ 2025-10-01 8:26 ` Konrad Dybcio
0 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:26 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
>
> As with all other devices in commit 7747a49db7e5 ("arm64: dts: qcom:
> sc7280-*: Remove thermal zone polling delays"), apply the same change to
> this device.
Your passive delays are <0> too (which has been the default value if
absent for a while) - IIRC you don't need either if you just want
userland temperature reporting, but you may need/want it if you hook
up any cooling devices
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory
2025-09-30 14:32 [PATCH 0/6] Further bringup of SHIFTphone 8 Luca Weiss
2025-09-30 14:32 ` [PATCH 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation Luca Weiss
2025-09-30 14:32 ` [PATCH 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays Luca Weiss
@ 2025-09-30 14:32 ` Luca Weiss
2025-10-01 8:27 ` Konrad Dybcio
2025-09-30 14:32 ` [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED Luca Weiss
` (2 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: Luca Weiss @ 2025-09-30 14:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
From: Alexander Martinz <amartinz@shiftphones.com>
It seems we also need to reserve a region of 81 MiB called "removed_mem"
otherwise we can easily hit memory errors with higher RAM usage.
Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 2efcfb631c3683456794b0a0cc5686f00efd329c..ce794ca724db6deb39f7fae47912c3fefe974573 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -118,6 +118,11 @@ cdsp_mem: cdsp@88f00000 {
no-map;
};
+ removed_mem: removed@c0000000 {
+ reg = <0x0 0xc0000000 0x0 0x5100000>;
+ no-map;
+ };
+
rmtfs_mem: rmtfs@f8500000 {
compatible = "qcom,rmtfs-mem";
reg = <0x0 0xf8500000 0x0 0x600000>;
--
2.51.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory
2025-09-30 14:32 ` [PATCH 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory Luca Weiss
@ 2025-10-01 8:27 ` Konrad Dybcio
0 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:27 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
>
> It seems we also need to reserve a region of 81 MiB called "removed_mem"
> otherwise we can easily hit memory errors with higher RAM usage.
>
> Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED
2025-09-30 14:32 [PATCH 0/6] Further bringup of SHIFTphone 8 Luca Weiss
` (2 preceding siblings ...)
2025-09-30 14:32 ` [PATCH 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory Luca Weiss
@ 2025-09-30 14:32 ` Luca Weiss
2025-10-01 8:30 ` Konrad Dybcio
2025-10-22 15:23 ` Pavel Machek
2025-09-30 14:32 ` [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED Luca Weiss
2025-09-30 14:32 ` [PATCH 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node Luca Weiss
5 siblings, 2 replies; 17+ messages in thread
From: Luca Weiss @ 2025-09-30 14:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
From: Casey Connolly <casey.connolly@linaro.org>
Describe the flash LED on this phone.
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index ce794ca724db6deb39f7fae47912c3fefe974573..36cc67469615974c193ea3a9db1b2362869d56bb 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -619,6 +619,19 @@ volume_down_default: volume-down-default-state {
};
};
+&pm8350c_flash {
+ status = "okay";
+
+ led-0 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <1>, <2>;
+ led-max-microamp = <500000>;
+ flash-max-microamp = <1500000>;
+ flash-max-timeout-us = <1280000>;
+ };
+};
+
&pmk8350_adc_tm {
status = "okay";
--
2.51.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED
2025-09-30 14:32 ` [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED Luca Weiss
@ 2025-10-01 8:30 ` Konrad Dybcio
2025-10-22 15:23 ` Pavel Machek
1 sibling, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:30 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> Describe the flash LED on this phone.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index ce794ca724db6deb39f7fae47912c3fefe974573..36cc67469615974c193ea3a9db1b2362869d56bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -619,6 +619,19 @@ volume_down_default: volume-down-default-state {
> };
> };
>
> +&pm8350c_flash {
> + status = "okay";
> +
> + led-0 {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + led-sources = <1>, <2>;
> + led-max-microamp = <500000>;
> + flash-max-microamp = <1500000>;
> + flash-max-timeout-us = <1280000>;
> + };
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED
2025-09-30 14:32 ` [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED Luca Weiss
2025-10-01 8:30 ` Konrad Dybcio
@ 2025-10-22 15:23 ` Pavel Machek
1 sibling, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2025-10-22 15:23 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Tue 2025-09-30 16:32:22, Luca Weiss wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> Describe the flash LED on this phone.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
> };
>
> +&pm8350c_flash {
> + status = "okay";
> +
> + led-0 {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + led-sources = <1>, <2>;
> + led-max-microamp = <500000>;
> + flash-max-microamp = <1500000>;
> + flash-max-timeout-us = <1280000>;
> + };
> +};
> +
> &pmk8350_adc_tm {
> status = "okay";
>
>
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
2025-09-30 14:32 [PATCH 0/6] Further bringup of SHIFTphone 8 Luca Weiss
` (3 preceding siblings ...)
2025-09-30 14:32 ` [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED Luca Weiss
@ 2025-09-30 14:32 ` Luca Weiss
2025-10-01 8:29 ` Konrad Dybcio
2025-10-22 15:24 ` Pavel Machek
2025-09-30 14:32 ` [PATCH 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node Luca Weiss
5 siblings, 2 replies; 17+ messages in thread
From: Luca Weiss @ 2025-09-30 14:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss, Luca Weiss
From: Luca Weiss <luca@lucaweiss.eu>
Enable the RGB LED connected to the PM7350C (PM8350C).
Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -632,6 +632,33 @@ led-0 {
};
};
+&pm8350c_pwm {
+ status = "okay";
+
+ multi-led {
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_STATUS;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ };
+ };
+};
+
&pmk8350_adc_tm {
status = "okay";
--
2.51.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
2025-09-30 14:32 ` [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED Luca Weiss
@ 2025-10-01 8:29 ` Konrad Dybcio
2025-10-01 8:30 ` Luca Weiss
2025-10-22 15:24 ` Pavel Machek
1 sibling, 1 reply; 17+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:29 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Luca Weiss <luca@lucaweiss.eu>
>
> Enable the RGB LED connected to the PM7350C (PM8350C).
>
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -632,6 +632,33 @@ led-0 {
> };
> };
>
> +&pm8350c_pwm {
> + status = "okay";
> +
> + multi-led {
> + color = <LED_COLOR_ID_RGB>;
> + function = LED_FUNCTION_STATUS;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_RED>;
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_GREEN>;
> + };
> +
> + led@3 {
> + reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> + };
I assume you managed to confirm these mappings are correct.. sometimes
they are not what you'd expect
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
2025-10-01 8:29 ` Konrad Dybcio
@ 2025-10-01 8:30 ` Luca Weiss
2025-10-01 8:37 ` Konrad Dybcio
0 siblings, 1 reply; 17+ messages in thread
From: Luca Weiss @ 2025-10-01 8:30 UTC (permalink / raw)
To: Konrad Dybcio, Luca Weiss, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
On Wed Oct 1, 2025 at 10:29 AM CEST, Konrad Dybcio wrote:
> On 9/30/25 4:32 PM, Luca Weiss wrote:
>> From: Luca Weiss <luca@lucaweiss.eu>
>>
>> Enable the RGB LED connected to the PM7350C (PM8350C).
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>> @@ -632,6 +632,33 @@ led-0 {
>> };
>> };
>>
>> +&pm8350c_pwm {
>> + status = "okay";
>> +
>> + multi-led {
>> + color = <LED_COLOR_ID_RGB>;
>> + function = LED_FUNCTION_STATUS;
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + led@1 {
>> + reg = <1>;
>> + color = <LED_COLOR_ID_RED>;
>> + };
>> +
>> + led@2 {
>> + reg = <2>;
>> + color = <LED_COLOR_ID_GREEN>;
>> + };
>> +
>> + led@3 {
>> + reg = <3>;
>> + color = <LED_COLOR_ID_BLUE>;
>> + };
>
> I assume you managed to confirm these mappings are correct.. sometimes
> they are not what you'd expect
If you mean, that red == red, green == green and blue == blue, yes. The
RGB configured from user space matches the color on the LED.
Regards
Luca
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
2025-10-01 8:30 ` Luca Weiss
@ 2025-10-01 8:37 ` Konrad Dybcio
0 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:37 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
On 10/1/25 10:30 AM, Luca Weiss wrote:
> On Wed Oct 1, 2025 at 10:29 AM CEST, Konrad Dybcio wrote:
>> On 9/30/25 4:32 PM, Luca Weiss wrote:
>>> From: Luca Weiss <luca@lucaweiss.eu>
>>>
>>> Enable the RGB LED connected to the PM7350C (PM8350C).
>>>
>>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
>>> 1 file changed, 27 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> @@ -632,6 +632,33 @@ led-0 {
>>> };
>>> };
>>>
>>> +&pm8350c_pwm {
>>> + status = "okay";
>>> +
>>> + multi-led {
>>> + color = <LED_COLOR_ID_RGB>;
>>> + function = LED_FUNCTION_STATUS;
>>> +
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + led@1 {
>>> + reg = <1>;
>>> + color = <LED_COLOR_ID_RED>;
>>> + };
>>> +
>>> + led@2 {
>>> + reg = <2>;
>>> + color = <LED_COLOR_ID_GREEN>;
>>> + };
>>> +
>>> + led@3 {
>>> + reg = <3>;
>>> + color = <LED_COLOR_ID_BLUE>;
>>> + };
>>
>> I assume you managed to confirm these mappings are correct.. sometimes
>> they are not what you'd expect
>
> If you mean, that red == red, green == green and blue == blue, yes. The
> RGB configured from user space matches the color on the LED.
Yeah that's what I meant, thanks
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED
2025-09-30 14:32 ` [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED Luca Weiss
2025-10-01 8:29 ` Konrad Dybcio
@ 2025-10-22 15:24 ` Pavel Machek
1 sibling, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2025-10-22 15:24 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Tue 2025-09-30 16:32:23, Luca Weiss wrote:
> From: Luca Weiss <luca@lucaweiss.eu>
>
> Enable the RGB LED connected to the PM7350C (PM8350C).
>
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Thanks!
Pavel
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node
2025-09-30 14:32 [PATCH 0/6] Further bringup of SHIFTphone 8 Luca Weiss
` (4 preceding siblings ...)
2025-09-30 14:32 ` [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED Luca Weiss
@ 2025-09-30 14:32 ` Luca Weiss
2025-10-01 8:29 ` Konrad Dybcio
5 siblings, 1 reply; 17+ messages in thread
From: Luca Weiss @ 2025-09-30 14:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Casey Connolly, Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
From: Alexander Martinz <amartinz@shiftphones.com>
Enable the venus node so that the video encoder/decoder will start
working.
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index b4c69dc50ed0f0b3cb45341a01c89210bd261993..98c1ad4c21118831f079c83f4fe66ea30c141fac 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -995,6 +995,12 @@ &usb_dp_qmpphy_out {
remote-endpoint = <&pmic_glink_ss_in>;
};
+&venus {
+ firmware-name = "qcom/qcm6490/SHIFT/otter/venus.mbn";
+
+ status = "okay";
+};
+
&wifi {
qcom,calibration-variant = "SHIFTphone_8";
--
2.51.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node
2025-09-30 14:32 ` [PATCH 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node Luca Weiss
@ 2025-10-01 8:29 ` Konrad Dybcio
0 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:29 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Casey Connolly,
Alexander Martinz
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Alexander Martinz <amartinz@shiftphones.com>
>
> Enable the venus node so that the video encoder/decoder will start
> working.
>
> Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index b4c69dc50ed0f0b3cb45341a01c89210bd261993..98c1ad4c21118831f079c83f4fe66ea30c141fac 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -995,6 +995,12 @@ &usb_dp_qmpphy_out {
> remote-endpoint = <&pmic_glink_ss_in>;
> };
>
> +&venus {
> + firmware-name = "qcom/qcm6490/SHIFT/otter/venus.mbn";
> +
> + status = "okay";
> +};
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 17+ messages in thread