[PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address

[PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address

[Krzysztof Kozlowski]

Match unit-address to reg entry to fix dtbs W=1 warnings:

  Warning (simple_bus_reg): /soc/syscon@1fcb000: simple-bus unit address format error, expected "1fc0000"

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 342c3d14001e..72d82a9a6cc5 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -515,7 +515,7 @@ tcsr_mutex: hwlock@1f40000 {
 			#hwlock-cells = <1>;
 		};
 
-		tcsr: syscon@1fcb000 {
+		tcsr: syscon@1fc0000 {
 			compatible = "qcom,sdx55-tcsr", "syscon";
 			reg = <0x01fc0000 0x1000>;
 		};
-- 
2.34.1

[PATCH 02/10] ARM: dts: qcom: sdx55: correct rsc unit-address

[Krzysztof Kozlowski]

Match unit-address to reg entry to fix dtbs W=1 warnings:

  Warning (simple_bus_reg): /soc/rsc@17840000: simple-bus unit address format error, expected "17830000"

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 72d82a9a6cc5..06c2646dd673 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -792,7 +792,7 @@ frame@17829000 {
 			};
 		};
 
-		apps_rsc: rsc@17840000 {
+		apps_rsc: rsc@17830000 {
 			compatible = "qcom,rpmh-rsc";
 			reg = <0x17830000 0x10000>, <0x17840000 0x10000>;
 			reg-names = "drv-0", "drv-1";
-- 
2.34.1

[PATCH 03/10] ARM: dts: qcom: msm8974: correct pronto unit-address

[Krzysztof Kozlowski]

Match unit-address to reg entry to fix dtbs W=1 warnings:

  Warning (simple_bus_reg): /soc/remoteproc@fb21b000: simple-bus unit address format error, expected "fb204000"

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 788d9540fab8..939449a0c695 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -707,7 +707,7 @@ rng@f9bff000 {
 			clock-names = "core";
 		};
 
-		pronto: remoteproc@fb21b000 {
+		pronto: remoteproc@fb204000 {
 			compatible = "qcom,pronto-v2-pil", "qcom,pronto";
 			reg = <0xfb204000 0x2000>, <0xfb202000 0x1000>, <0xfb21b000 0x3000>;
 			reg-names = "ccu", "dxe", "pmu";
-- 
2.34.1

[PATCH 04/10] ARM: dts: qcom: ipq8064: drop leading 0 from unit-address

[Krzysztof Kozlowski]

Unit-address should not start with 0:

  Warning (simple_bus_reg): /soc/syscon@03000000: simple-bus unit address format error, expected "3000000"

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 621edf508a88..182018d79a7b 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -609,7 +609,7 @@ saw1: regulator@2099000 {
 			regulator;
 		};
 
-		nss_common: syscon@03000000 {
+		nss_common: syscon@3000000 {
 			compatible = "syscon";
 			reg = <0x03000000 0x0000FFFF>;
 		};
-- 
2.34.1

[PATCH 05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address

[Krzysztof Kozlowski]

GCC comes with syscon compatible so the thermal-sensor child node should
not have unit-address (bindings also do not expect it):

  Warning (unit_address_vs_reg): /soc/clock-controller@900000/thermal-sensor@900000: node has a unit name, but no reg or ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 182018d79a7b..49310520da1c 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -522,7 +522,7 @@ gcc: clock-controller@900000 {
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;
 
-			tsens: thermal-sensor@900000 {
+			tsens: thermal-sensor {
 				compatible = "qcom,ipq8064-tsens";
 
 				nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>;
-- 
2.34.1

[PATCH 06/10] ARM: dts: qcom: ipq8064: correct LED node names

[Krzysztof Kozlowski]

GPIO LEDs is not a bus, so drop unit-address and also start suffix
numbering from 0:

  Warning (unit_address_vs_reg): /soc/leds/led@7: node has a unit name, but no reg or ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-ipq8064-rb3011.dts |  2 +-
 arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi  | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
index 47a5d1849c72..52eadefd2fb4 100644
--- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
+++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
@@ -203,7 +203,7 @@ leds {
 			pinctrl-0 = <&leds_pins>;
 			pinctrl-names = "default";
 
-			led@7 {
+			led-0 {
 				label = "rb3011:green:user";
 				color = <LED_COLOR_ID_GREEN>;
 				gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
index 411c8d63c38e..c5abe7151f14 100644
--- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
@@ -92,34 +92,34 @@ leds {
 			pinctrl-0 = <&leds_pins>;
 			pinctrl-names = "default";
 
-			led@7 {
+			led-0 {
 				label = "led_usb1";
 				gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>;
 				linux,default-trigger = "usbdev";
 				default-state = "off";
 			};
 
-			led@8 {
+			led-1 {
 				label = "led_usb3";
 				gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>;
 				linux,default-trigger = "usbdev";
 				default-state = "off";
 			};
 
-			led@9 {
+			led-2 {
 				label = "status_led_fail";
 				function = LED_FUNCTION_STATUS;
 				gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>;
 				default-state = "off";
 			};
 
-			led@26 {
+			led-3 {
 				label = "sata_led";
 				gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>;
 				default-state = "off";
 			};
 
-			led@53 {
+			led-4 {
 				label = "status_led_pass";
 				function = LED_FUNCTION_STATUS;
 				gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;
-- 
2.34.1

[PATCH 07/10] ARM: dts: qcom: ipq8064: align USB node names with bindings

[Krzysztof Kozlowski]

Bindings expect USB controller node names to be named "usb".

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-ipq8064.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 49310520da1c..396938ec46cb 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -614,7 +614,7 @@ nss_common: syscon@3000000 {
 			reg = <0x03000000 0x0000FFFF>;
 		};
 
-		usb3_0: usb3@100f8800 {
+		usb3_0: usb@100f8800 {
 			compatible = "qcom,ipq8064-dwc3", "qcom,dwc3";
 			#address-cells = <1>;
 			#size-cells = <1>;
@@ -629,7 +629,7 @@ usb3_0: usb3@100f8800 {
 
 			status = "disabled";
 
-			dwc3_0: dwc3@10000000 {
+			dwc3_0: usb@10000000 {
 				compatible = "snps,dwc3";
 				reg = <0x10000000 0xcd00>;
 				interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
@@ -660,7 +660,7 @@ ss_phy_0: phy@100f8830 {
 			status = "disabled";
 		};
 
-		usb3_1: usb3@110f8800 {
+		usb3_1: usb@110f8800 {
 			compatible = "qcom,ipq8064-dwc3", "qcom,dwc3";
 			#address-cells = <1>;
 			#size-cells = <1>;
@@ -675,7 +675,7 @@ usb3_1: usb3@110f8800 {
 
 			status = "disabled";
 
-			dwc3_1: dwc3@11000000 {
+			dwc3_1: usb@11000000 {
 				compatible = "snps,dwc3";
 				reg = <0x11000000 0xcd00>;
 				interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.34.1

[PATCH 08/10] ARM: dts: qcom: apq8060-dragonboard: move regulators out of simple-bus

[Krzysztof Kozlowski]

Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
W=1 warnings:

  Warning (simple_bus_reg): /regulators/regulator-fixed: missing or empty reg/ranges property
  Warning (simple_bus_reg): /regulators/xc622a331mrg: missing or empty reg/ranges property
  Warning (simple_bus_reg): /regulators/nds332p: missing or empty reg/ranges property
  Warning (simple_bus_reg): /regulators/txb0104rgyr: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../arm/boot/dts/qcom-apq8060-dragonboard.dts | 80 +++++++++----------
 1 file changed, 38 insertions(+), 42 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
index 8e4b61e4d4b1..e830cb2395aa 100644
--- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
@@ -18,50 +18,46 @@ chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
-	regulators {
-		compatible = "simple-bus";
-
-		/* Main power of the board: 3.7V */
-		vph: regulator-fixed {
-			compatible = "regulator-fixed";
-			regulator-min-microvolt = <3700000>;
-			regulator-max-microvolt = <3700000>;
-			regulator-name = "VPH";
-			regulator-type = "voltage";
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		/* GPIO controlled ethernet power regulator */
-		dragon_veth: xc622a331mrg {
-			compatible = "regulator-fixed";
-			regulator-name = "XC6222A331MR-G";
-			regulator-min-microvolt = <3300000>;
-			regulator-max-microvolt = <3300000>;
-			vin-supply = <&vph>;
-			gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
-			enable-active-high;
-			pinctrl-names = "default";
-			pinctrl-0 = <&dragon_veth_gpios>;
-			regulator-always-on;
-		};
+	/* Main power of the board: 3.7V */
+	vph: regulator-fixed {
+		compatible = "regulator-fixed";
+		regulator-min-microvolt = <3700000>;
+		regulator-max-microvolt = <3700000>;
+		regulator-name = "VPH";
+		regulator-type = "voltage";
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	/* GPIO controlled ethernet power regulator */
+	dragon_veth: xc622a331mrg {
+		compatible = "regulator-fixed";
+		regulator-name = "XC6222A331MR-G";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vph>;
+		gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		pinctrl-names = "default";
+		pinctrl-0 = <&dragon_veth_gpios>;
+		regulator-always-on;
+	};
 
-		/* VDDvario fixed regulator */
-		dragon_vario: nds332p {
-			compatible = "regulator-fixed";
-			regulator-name = "NDS332P";
-			regulator-min-microvolt = <1800000>;
-			regulator-max-microvolt = <1800000>;
-			vin-supply = <&pm8058_s3>;
-		};
+	/* VDDvario fixed regulator */
+	dragon_vario: nds332p {
+		compatible = "regulator-fixed";
+		regulator-name = "NDS332P";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		vin-supply = <&pm8058_s3>;
+	};
 
-		/* This is a levelshifter for SDCC5 */
-		dragon_vio_txb: txb0104rgyr {
-			compatible = "regulator-fixed";
-			regulator-name = "Dragon SDCC levelshifter";
-			vin-supply = <&pm8058_l14>;
-			regulator-always-on;
-		};
+	/* This is a levelshifter for SDCC5 */
+	dragon_vio_txb: txb0104rgyr {
+		compatible = "regulator-fixed";
+		regulator-name = "Dragon SDCC levelshifter";
+		vin-supply = <&pm8058_l14>;
+		regulator-always-on;
 	};
 
 	/*
-- 
2.34.1

[PATCH 09/10] ARM: dts: qcom: msm8960-cdp: move regulator out of simple-bus

[Krzysztof Kozlowski]

Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
W=1 warning:

  Warning (simple_bus_reg): /regulators/gpio-regulator: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-msm8960-cdp.dts | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
index 8fa2befa629a..6c1bc3818883 100644
--- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts
+++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
@@ -15,16 +15,12 @@ chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
-	regulators {
-		compatible = "simple-bus";
-
-		ext_l2: gpio-regulator {
-			compatible = "regulator-fixed";
-			regulator-name = "ext_l2";
-			gpio = <&msmgpio 91 0>;
-			startup-delay-us = <10000>;
-			enable-active-high;
-		};
+	ext_l2: gpio-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "ext_l2";
+		gpio = <&msmgpio 91 0>;
+		startup-delay-us = <10000>;
+		enable-active-high;
 	};
 };
 
-- 
2.34.1

[PATCH 10/10] ARM: dts: qcom: apq8084: correct thermal sensor unit-address

[Krzysztof Kozlowski]

Match unit-address to reg entry to fix dtbs W=1 warnings:

  Warning (simple_bus_reg): /soc/thermal-sensor@fc4a8000: simple-bus unit address format error, expected "fc4a9000"

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-apq8084.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
index 83839e1ec4d1..8f178bc87e1d 100644
--- a/arch/arm/boot/dts/qcom-apq8084.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
@@ -507,7 +507,7 @@ tsens_s4_p2_backup: s4-p2_backup@44e {
 			};
 		};
 
-		tsens: thermal-sensor@fc4a8000 {
+		tsens: thermal-sensor@fc4a9000 {
 			compatible = "qcom,msm8974-tsens", "qcom,tsens-v0_1";
 			reg = <0xfc4a9000 0x1000>, /* TM */
 			      <0xfc4a8000 0x1000>; /* SROT */
-- 
2.34.1

Re: [PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Match unit-address to reg entry to fix dtbs W=1 warnings:
> 
>   Warning (simple_bus_reg): /soc/syscon@1fcb000: simple-bus unit address format error, expected "1fc0000"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 342c3d14001e..72d82a9a6cc5 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -515,7 +515,7 @@ tcsr_mutex: hwlock@1f40000 {
>  			#hwlock-cells = <1>;
>  		};
>  
> -		tcsr: syscon@1fcb000 {
> +		tcsr: syscon@1fc0000 {
>  			compatible = "qcom,sdx55-tcsr", "syscon";
>  			reg = <0x01fc0000 0x1000>;
>  		};

Re: [PATCH 02/10] ARM: dts: qcom: sdx55: correct rsc unit-address

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Match unit-address to reg entry to fix dtbs W=1 warnings:
> 
>   Warning (simple_bus_reg): /soc/rsc@17840000: simple-bus unit address format error, expected "17830000"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 72d82a9a6cc5..06c2646dd673 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -792,7 +792,7 @@ frame@17829000 {
>  			};
>  		};
>  
> -		apps_rsc: rsc@17840000 {
> +		apps_rsc: rsc@17830000 {
>  			compatible = "qcom,rpmh-rsc";
>  			reg = <0x17830000 0x10000>, <0x17840000 0x10000>;
>  			reg-names = "drv-0", "drv-1";

Re: [PATCH 03/10] ARM: dts: qcom: msm8974: correct pronto unit-address

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Match unit-address to reg entry to fix dtbs W=1 warnings:
> 
>   Warning (simple_bus_reg): /soc/remoteproc@fb21b000: simple-bus unit address format error, expected "fb204000"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 788d9540fab8..939449a0c695 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -707,7 +707,7 @@ rng@f9bff000 {
>  			clock-names = "core";
>  		};
>  
> -		pronto: remoteproc@fb21b000 {
> +		pronto: remoteproc@fb204000 {
>  			compatible = "qcom,pronto-v2-pil", "qcom,pronto";
>  			reg = <0xfb204000 0x2000>, <0xfb202000 0x1000>, <0xfb21b000 0x3000>;
>  			reg-names = "ccu", "dxe", "pmu";

Re: [PATCH 04/10] ARM: dts: qcom: ipq8064: drop leading 0 from unit-address

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Unit-address should not start with 0:
> 
>   Warning (simple_bus_reg): /soc/syscon@03000000: simple-bus unit address format error, expected "3000000"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

>  arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 621edf508a88..182018d79a7b 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -609,7 +609,7 @@ saw1: regulator@2099000 {
>  			regulator;
>  		};
>  
> -		nss_common: syscon@03000000 {
> +		nss_common: syscon@3000000 {
>  			compatible = "syscon";
>  			reg = <0x03000000 0x0000FFFF>;
some random uppercase hex, if you'd like to clean that up too!

Konrad

>  		};

Re: [PATCH 05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> GCC comes with syscon compatible so the thermal-sensor child node should
> not have unit-address (bindings also do not expect it):
> 
>   Warning (unit_address_vs_reg): /soc/clock-controller@900000/thermal-sensor@900000: node has a unit name, but no reg or ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 182018d79a7b..49310520da1c 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -522,7 +522,7 @@ gcc: clock-controller@900000 {
>  			#reset-cells = <1>;
>  			#power-domain-cells = <1>;
>  
> -			tsens: thermal-sensor@900000 {
> +			tsens: thermal-sensor {
>  				compatible = "qcom,ipq8064-tsens";
>  
>  				nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>;

Re: [PATCH 06/10] ARM: dts: qcom: ipq8064: correct LED node names

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> GPIO LEDs is not a bus, so drop unit-address and also start suffix
> numbering from 0:
> 
>   Warning (unit_address_vs_reg): /soc/leds/led@7: node has a unit name, but no reg or ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts |  2 +-
>  arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi  | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 47a5d1849c72..52eadefd2fb4 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -203,7 +203,7 @@ leds {
>  			pinctrl-0 = <&leds_pins>;
>  			pinctrl-names = "default";
>  
> -			led@7 {
> +			led-0 {
>  				label = "rb3011:green:user";
>  				color = <LED_COLOR_ID_GREEN>;
>  				gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> index 411c8d63c38e..c5abe7151f14 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> @@ -92,34 +92,34 @@ leds {
>  			pinctrl-0 = <&leds_pins>;
>  			pinctrl-names = "default";
>  
> -			led@7 {
> +			led-0 {
>  				label = "led_usb1";
>  				gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>;
>  				linux,default-trigger = "usbdev";
>  				default-state = "off";
>  			};
>  
> -			led@8 {
> +			led-1 {
>  				label = "led_usb3";
>  				gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>;
>  				linux,default-trigger = "usbdev";
>  				default-state = "off";
>  			};
>  
> -			led@9 {
> +			led-2 {
>  				label = "status_led_fail";
>  				function = LED_FUNCTION_STATUS;
>  				gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>;
>  				default-state = "off";
>  			};
>  
> -			led@26 {
> +			led-3 {
>  				label = "sata_led";
>  				gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>;
>  				default-state = "off";
>  			};
>  
> -			led@53 {
> +			led-4 {
>  				label = "status_led_pass";
>  				function = LED_FUNCTION_STATUS;
>  				gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;

Re: [PATCH 07/10] ARM: dts: qcom: ipq8064: align USB node names with bindings

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Bindings expect USB controller node names to be named "usb".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq8064.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 49310520da1c..396938ec46cb 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -614,7 +614,7 @@ nss_common: syscon@3000000 {
>  			reg = <0x03000000 0x0000FFFF>;
>  		};
>  
> -		usb3_0: usb3@100f8800 {
> +		usb3_0: usb@100f8800 {
>  			compatible = "qcom,ipq8064-dwc3", "qcom,dwc3";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> @@ -629,7 +629,7 @@ usb3_0: usb3@100f8800 {
>  
>  			status = "disabled";
>  
> -			dwc3_0: dwc3@10000000 {
> +			dwc3_0: usb@10000000 {
>  				compatible = "snps,dwc3";
>  				reg = <0x10000000 0xcd00>;
>  				interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
> @@ -660,7 +660,7 @@ ss_phy_0: phy@100f8830 {
>  			status = "disabled";
>  		};
>  
> -		usb3_1: usb3@110f8800 {
> +		usb3_1: usb@110f8800 {
>  			compatible = "qcom,ipq8064-dwc3", "qcom,dwc3";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> @@ -675,7 +675,7 @@ usb3_1: usb3@110f8800 {
>  
>  			status = "disabled";
>  
> -			dwc3_1: dwc3@11000000 {
> +			dwc3_1: usb@11000000 {
>  				compatible = "snps,dwc3";
>  				reg = <0x11000000 0xcd00>;
>  				interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;

Re: [PATCH 08/10] ARM: dts: qcom: apq8060-dragonboard: move regulators out of simple-bus

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
> W=1 warnings:
> 
>   Warning (simple_bus_reg): /regulators/regulator-fixed: missing or empty reg/ranges property
>   Warning (simple_bus_reg): /regulators/xc622a331mrg: missing or empty reg/ranges property
>   Warning (simple_bus_reg): /regulators/nds332p: missing or empty reg/ranges property
>   Warning (simple_bus_reg): /regulators/txb0104rgyr: missing or empty reg/ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../arm/boot/dts/qcom-apq8060-dragonboard.dts | 80 +++++++++----------
>  1 file changed, 38 insertions(+), 42 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 8e4b61e4d4b1..e830cb2395aa 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -18,50 +18,46 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> -	regulators {
> -		compatible = "simple-bus";
> -
> -		/* Main power of the board: 3.7V */
> -		vph: regulator-fixed {
> -			compatible = "regulator-fixed";
> -			regulator-min-microvolt = <3700000>;
> -			regulator-max-microvolt = <3700000>;
> -			regulator-name = "VPH";
> -			regulator-type = "voltage";
> -			regulator-always-on;
> -			regulator-boot-on;
> -		};
> -
> -		/* GPIO controlled ethernet power regulator */
> -		dragon_veth: xc622a331mrg {
> -			compatible = "regulator-fixed";
> -			regulator-name = "XC6222A331MR-G";
> -			regulator-min-microvolt = <3300000>;
> -			regulator-max-microvolt = <3300000>;
> -			vin-supply = <&vph>;
> -			gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
> -			enable-active-high;
> -			pinctrl-names = "default";
> -			pinctrl-0 = <&dragon_veth_gpios>;
> -			regulator-always-on;
> -		};
> +	/* Main power of the board: 3.7V */
> +	vph: regulator-fixed {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <3700000>;
> +		regulator-max-microvolt = <3700000>;
> +		regulator-name = "VPH";
> +		regulator-type = "voltage";
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
> +	/* GPIO controlled ethernet power regulator */
> +	dragon_veth: xc622a331mrg {
These names could also be fixed up, but that's for another day..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> +		compatible = "regulator-fixed";
> +		regulator-name = "XC6222A331MR-G";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vph>;
> +		gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&dragon_veth_gpios>;
> +		regulator-always-on;
> +	};
>  
> -		/* VDDvario fixed regulator */
> -		dragon_vario: nds332p {
> -			compatible = "regulator-fixed";
> -			regulator-name = "NDS332P";
> -			regulator-min-microvolt = <1800000>;
> -			regulator-max-microvolt = <1800000>;
> -			vin-supply = <&pm8058_s3>;
> -		};
> +	/* VDDvario fixed regulator */
> +	dragon_vario: nds332p {
> +		compatible = "regulator-fixed";
> +		regulator-name = "NDS332P";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		vin-supply = <&pm8058_s3>;
> +	};
>  
> -		/* This is a levelshifter for SDCC5 */
> -		dragon_vio_txb: txb0104rgyr {
> -			compatible = "regulator-fixed";
> -			regulator-name = "Dragon SDCC levelshifter";
> -			vin-supply = <&pm8058_l14>;
> -			regulator-always-on;
> -		};
> +	/* This is a levelshifter for SDCC5 */
> +	dragon_vio_txb: txb0104rgyr {
> +		compatible = "regulator-fixed";
> +		regulator-name = "Dragon SDCC levelshifter";
> +		vin-supply = <&pm8058_l14>;
> +		regulator-always-on;
>  	};
>  
>  	/*

Re: [PATCH 09/10] ARM: dts: qcom: msm8960-cdp: move regulator out of simple-bus

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
> W=1 warning:
> 
>   Warning (simple_bus_reg): /regulators/gpio-regulator: missing or empty reg/ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-msm8960-cdp.dts | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> index 8fa2befa629a..6c1bc3818883 100644
> --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> @@ -15,16 +15,12 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> -	regulators {
> -		compatible = "simple-bus";
> -
> -		ext_l2: gpio-regulator {
> -			compatible = "regulator-fixed";
> -			regulator-name = "ext_l2";
> -			gpio = <&msmgpio 91 0>;
> -			startup-delay-us = <10000>;
> -			enable-active-high;
> -		};
> +	ext_l2: gpio-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "ext_l2";
> +		gpio = <&msmgpio 91 0>;
> +		startup-delay-us = <10000>;
> +		enable-active-high;
>  	};
>  };
>  

Re: [PATCH 10/10] ARM: dts: qcom: apq8084: correct thermal sensor unit-address

[Konrad Dybcio]

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Match unit-address to reg entry to fix dtbs W=1 warnings:
> 
>   Warning (simple_bus_reg): /soc/thermal-sensor@fc4a8000: simple-bus unit address format error, expected "fc4a9000"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-apq8084.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
> index 83839e1ec4d1..8f178bc87e1d 100644
> --- a/arch/arm/boot/dts/qcom-apq8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
> @@ -507,7 +507,7 @@ tsens_s4_p2_backup: s4-p2_backup@44e {
>  			};
>  		};
>  
> -		tsens: thermal-sensor@fc4a8000 {
> +		tsens: thermal-sensor@fc4a9000 {
>  			compatible = "qcom,msm8974-tsens", "qcom,tsens-v0_1";
>  			reg = <0xfc4a9000 0x1000>, /* TM */
>  			      <0xfc4a8000 0x1000>; /* SROT */

Re: (subset) [PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address

[Bjorn Andersson]

On Thu, 20 Apr 2023 09:50:44 +0200, Krzysztof Kozlowski wrote:
> Match unit-address to reg entry to fix dtbs W=1 warnings:
> 
>   Warning (simple_bus_reg): /soc/syscon@1fcb000: simple-bus unit address format error, expected "1fc0000"
> 
> 

Applied, thanks!

[01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address
        commit: 2c7a2700bad5f735b76acaaf721752f33e030497
[02/10] ARM: dts: qcom: sdx55: correct rsc unit-address
        commit: 59cf17540e48ab6c37289f0333bdf0b9c639ba80
[03/10] ARM: dts: qcom: msm8974: correct pronto unit-address
        commit: 547c0034b40ee18e5e4b48501b935f0ab8f70a37
[04/10] ARM: dts: qcom: ipq8064: drop leading 0 from unit-address
        commit: 038b8980077bf02c82324aefd6b69e00f5b8a1a2
[05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address
        commit: 0dd882ae3dd9cfb51d5dc5083da3af7a35db1355
[06/10] ARM: dts: qcom: ipq8064: correct LED node names
        commit: 740e5ecb78d4426526cb2b3f49d0043225a8bed9
[07/10] ARM: dts: qcom: ipq8064: align USB node names with bindings
        commit: c13ba9b148716160a2cbbc7620944a976b6b1491
[08/10] ARM: dts: qcom: apq8060-dragonboard: move regulators out of simple-bus
        commit: f0e401e15d3eab570f92fab2c9ce56a2564fa828
[09/10] ARM: dts: qcom: msm8960-cdp: move regulator out of simple-bus
        commit: 71abfd7a0a100010d32edb28917f437537afbb7f
[10/10] ARM: dts: qcom: apq8084: correct thermal sensor unit-address
        commit: a8311da44f38a2f52cb4cf44710c95c1e6f2f6ec

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>