* [PATCH] Audit: remove duplicate comments
@ 2013-09-23 7:55 Gao feng
2013-09-23 15:16 ` Casey Schaufler
0 siblings, 1 reply; 3+ messages in thread
From: Gao feng @ 2013-09-23 7:55 UTC (permalink / raw)
To: linux-audit; +Cc: akpm
Remove it.
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
---
kernel/audit.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/kernel/audit.c b/kernel/audit.c
index 91e53d0..f94db2a 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1067,13 +1067,6 @@ static void wait_for_auditd(unsigned long sleep_time)
remove_wait_queue(&audit_backlog_wait, &wait);
}
-/* Obtain an audit buffer. This routine does locking to obtain the
- * audit buffer, but then no locking is required for calls to
- * audit_log_*format. If the tsk is a task that is currently in a
- * syscall, then the syscall is marked as auditable and an audit record
- * will be written at syscall exit. If there is no associated task, tsk
- * should be NULL. */
-
/**
* audit_log_start - obtain an audit buffer
* @ctx: audit_context (may be NULL)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Audit: remove duplicate comments
2013-09-23 7:55 [PATCH] Audit: remove duplicate comments Gao feng
@ 2013-09-23 15:16 ` Casey Schaufler
2013-09-23 15:28 ` Richard Guy Briggs
0 siblings, 1 reply; 3+ messages in thread
From: Casey Schaufler @ 2013-09-23 15:16 UTC (permalink / raw)
To: Gao feng; +Cc: akpm, linux-audit
On 9/23/2013 12:55 AM, Gao feng wrote:
> Remove it.
Why? Is it inaccurate?
>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
> ---
> kernel/audit.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 91e53d0..f94db2a 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -1067,13 +1067,6 @@ static void wait_for_auditd(unsigned long sleep_time)
> remove_wait_queue(&audit_backlog_wait, &wait);
> }
>
> -/* Obtain an audit buffer. This routine does locking to obtain the
> - * audit buffer, but then no locking is required for calls to
> - * audit_log_*format. If the tsk is a task that is currently in a
> - * syscall, then the syscall is marked as auditable and an audit record
> - * will be written at syscall exit. If there is no associated task, tsk
> - * should be NULL. */
> -
> /**
> * audit_log_start - obtain an audit buffer
> * @ctx: audit_context (may be NULL)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Audit: remove duplicate comments
2013-09-23 15:16 ` Casey Schaufler
@ 2013-09-23 15:28 ` Richard Guy Briggs
0 siblings, 0 replies; 3+ messages in thread
From: Richard Guy Briggs @ 2013-09-23 15:28 UTC (permalink / raw)
To: Casey Schaufler; +Cc: akpm, linux-audit
On Mon, Sep 23, 2013 at 08:16:07AM -0700, Casey Schaufler wrote:
> On 9/23/2013 12:55 AM, Gao feng wrote:
> > Remove it.
>
> Why? Is it inaccurate?
Yes. It is a duplicate from 8 years ago that is no longer accurate.
> > Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
> > ---
> > kernel/audit.c | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/kernel/audit.c b/kernel/audit.c
> > index 91e53d0..f94db2a 100644
> > --- a/kernel/audit.c
> > +++ b/kernel/audit.c
> > @@ -1067,13 +1067,6 @@ static void wait_for_auditd(unsigned long sleep_time)
> > remove_wait_queue(&audit_backlog_wait, &wait);
> > }
> >
> > -/* Obtain an audit buffer. This routine does locking to obtain the
> > - * audit buffer, but then no locking is required for calls to
> > - * audit_log_*format. If the tsk is a task that is currently in a
> > - * syscall, then the syscall is marked as auditable and an audit record
> > - * will be written at syscall exit. If there is no associated task, tsk
> > - * should be NULL. */
> > -
> > /**
> > * audit_log_start - obtain an audit buffer
> > * @ctx: audit_context (may be NULL)
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer
Kernel Security
AMER ENG Base Operating Systems
Remote, Ottawa, Canada
Voice: +1.647.777.2635
Internal: (81) 32635
Alt: +1.613.693.0684x3545
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-23 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 7:55 [PATCH] Audit: remove duplicate comments Gao feng
2013-09-23 15:16 ` Casey Schaufler
2013-09-23 15:28 ` Richard Guy Briggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox