From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Alan Stern <stern@rowland.harvard.edu>,
linux-pm@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bart.vanassche@wdc.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Adrian Hunter <adrian.hunter@intel.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC V2 1/3] block: put runtime PM code into common helpers
Date: Tue, 17 Jul 2018 15:21:17 +0200 [thread overview]
Message-ID: <20180717132117.GG13582@lst.de> (raw)
In-Reply-To: <20180713080602.31602-2-ming.lei@redhat.com>
> #ifdef CONFIG_PM
> +static int __blk_pre_runtime_suspend(struct request_queue *q, bool active)
> +{
> + int ret;
> +
> + if (active) {
> + ret = -EBUSY;
> + pm_runtime_mark_last_busy(q->dev);
> + } else {
> + ret = 0;
> + q->rpm_status = RPM_SUSPENDING;
> + }
> +
> + return ret;
> +}
Why not:
if (active) {
pm_runtime_mark_last_busy(q->dev);
return -EBUSY;
}
q->rpm_status = RPM_SUSPENDING;
return 0;
next prev parent reply other threads:[~2018-07-17 13:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 8:05 [PATCH RFC V2 0/3] blk-mq: support runtime PM Ming Lei
2018-07-13 8:06 ` [PATCH RFC V2 1/3] block: put runtime PM code into common helpers Ming Lei
2018-07-17 13:21 ` Christoph Hellwig [this message]
2018-07-13 8:06 ` [PATCH RFC V2 2/3] blk-mq: prepare for supporting runtime PM Ming Lei
2018-07-13 20:16 ` Alan Stern
2018-07-17 13:23 ` Christoph Hellwig
2018-07-13 8:06 ` [PATCH RFC V2 3/3] scsi_mq: enable " Ming Lei
2018-07-17 13:24 ` Christoph Hellwig
2018-07-17 15:30 ` Ming Lei
2018-07-17 15:34 ` Bart Van Assche
2018-07-17 15:38 ` Ming Lei
2018-07-17 19:50 ` hch
2018-07-17 20:54 ` Alan Stern
2018-07-17 21:49 ` Jens Axboe
2018-07-18 12:06 ` Ming Lei
2018-07-18 12:28 ` Johannes Thumshirn
2018-07-18 12:37 ` Ming Lei
2018-07-18 14:12 ` Alan Stern
2018-07-18 14:18 ` Johannes Thumshirn
2018-07-18 15:01 ` Alan Stern
2018-07-19 6:41 ` Johannes Thumshirn
2018-07-19 14:35 ` Alan Stern
2018-07-19 14:43 ` Johannes Thumshirn
2018-07-18 14:50 ` Jens Axboe
2018-07-18 18:46 ` Alan Stern
2018-07-18 23:08 ` Ming Lei
2018-07-18 12:43 ` Hannes Reinecke
2018-07-18 13:05 ` Ming Lei
2018-07-13 14:21 ` [PATCH RFC V2 0/3] blk-mq: support " Jens Axboe
2018-07-14 2:37 ` Ming Lei
2018-07-14 2:54 ` Jens Axboe
2018-07-16 16:21 ` Bart Van Assche
2018-07-16 16:03 ` Bart Van Assche
2018-07-17 1:12 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717132117.GG13582@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox