From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>,
Keith Busch <keith.busch@intel.com>
Subject: [RFC PATCH 4/7] blk-mq: add callback of .free_request
Date: Fri, 12 Jul 2019 10:47:23 +0800 [thread overview]
Message-ID: <20190712024726.1227-5-ming.lei@redhat.com> (raw)
In-Reply-To: <20190712024726.1227-1-ming.lei@redhat.com>
blk_steal_bios() is usually used before freeing the request, however,
we have to tell driver that the un-completed request will be freed,
then driver can free any private part for the request.
Then we can apply blk_steal_bios() in other cases, such as freeing
the request and re-submit the stolen bios after the hctx is down
in CPU hotplug situation.
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Keith Busch <keith.busch@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
include/linux/blk-mq.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index dc86bdac08f4..353606023a0f 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -141,6 +141,7 @@ typedef int (poll_fn)(struct blk_mq_hw_ctx *);
typedef int (map_queues_fn)(struct blk_mq_tag_set *set);
typedef bool (busy_fn)(struct request_queue *);
typedef void (complete_fn)(struct request *);
+typedef void (free_request_fn)(struct request *);
struct blk_mq_ops {
@@ -201,6 +202,12 @@ struct blk_mq_ops {
/* Called from inside blk_get_request() */
void (*initialize_rq_fn)(struct request *rq);
+ /*
+ * Called before freeing one request which isn't completed yet,
+ * and usually for freeing the driver private part
+ */
+ free_request_fn *free_request;
+
/*
* If set, returns whether or not this queue currently is busy
*/
--
2.20.1
next prev parent reply other threads:[~2019-07-12 2:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 2:47 [RFC PATCH 0/7] blk-mq: improvement on handling IO during CPU hotplug Ming Lei
2019-07-12 2:47 ` [RFC PATCH 1/7] blk-mq: add new state of BLK_MQ_S_INTERNAL_STOPPED Ming Lei
2019-07-12 2:47 ` [RFC PATCH 2/7] blk-mq: add blk-mq flag of BLK_MQ_F_NO_MANAGED_IRQ Ming Lei
2019-07-16 2:53 ` John Garry
2019-07-16 6:08 ` Ming Lei
2019-07-12 2:47 ` [RFC PATCH 3/7] blk-mq: stop to handle IO before hctx's all CPUs become offline Ming Lei
2019-07-12 9:03 ` Minwoo Im
2019-07-16 3:03 ` John Garry
2019-07-16 6:12 ` Ming Lei
2019-07-12 2:47 ` Ming Lei [this message]
2019-07-12 2:47 ` [RFC PATCH 5/7] SCSI: implement .free_request callback Ming Lei
2019-07-12 2:47 ` [RFC PATCH 6/7] blk-mq: re-submit IO in case that hctx is dead Ming Lei
2019-07-12 2:47 ` [RFC PATCH 7/7] blk-mq: handle requests dispatched from IO scheduler " Ming Lei
2019-07-16 6:54 ` [RFC PATCH 0/7] blk-mq: improvement on handling IO during CPU hotplug John Garry
2019-07-16 7:18 ` Ming Lei
2019-07-16 8:13 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712024726.1227-5-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox