[PATCH] block: mtip32xx: Fix typos in comments and log messages

[PATCH] block: mtip32xx: Fix typos in comments and log messages

[Alok Tiwari]

This patch corrects several minor typos and spelling errors in mtip32xx.c
- Fixing "ge" -> "get" in a warning message.
- Correcting "kernrel" -> "kernel", "progess" -> "progress"
  "strucutre" -> "structure" in comments.

no functional impact.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/block/mtip32xx/mtip32xx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 567192e371a8..df184a9f006f 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -1337,7 +1337,7 @@ static int mtip_get_smart_attr(struct mtip_port *port, unsigned int id,
 	memset(port->smart_buf, 0, ATA_SECT_SIZE);
 	rv = mtip_get_smart_data(port, port->smart_buf, port->smart_buf_dma);
 	if (rv) {
-		dev_warn(&port->dd->pdev->dev, "Failed to ge SMART data\n");
+		dev_warn(&port->dd->pdev->dev, "Failed to get SMART data\n");
 		return rv;
 	}
 
@@ -2127,7 +2127,7 @@ static int mtip_hw_submit_io(struct driver_data *dd, struct request *rq,
 /*
  * Sysfs status dump.
  *
- * @dev  Pointer to the device structure, passed by the kernrel.
+ * @dev  Pointer to the device structure, passed by the kernel.
  * @attr Pointer to the device_attribute structure passed by the kernel.
  * @buf  Pointer to the char buffer that will receive the stats info.
  *
@@ -2679,7 +2679,7 @@ static int mtip_hw_get_identify(struct driver_data *dd)
 		}
 	}
 
-	/* get write protect progess */
+	/* get write protect progress */
 	memset(&attr242, 0, sizeof(struct smart_attr));
 	if (mtip_get_smart_attr(dd->port, 242, &attr242))
 		dev_warn(&dd->pdev->dev,
@@ -3148,7 +3148,7 @@ static int mtip_block_compat_ioctl(struct block_device *dev,
  * that each partition is also 4KB aligned. Non-aligned partitions adversely
  * affects performance.
  *
- * @disk Pointer to the gendisk strucutre.
+ * @disk Pointer to the gendisk structure.
  * @geo Pointer to a hd_geometry structure.
  *
  * return value
-- 
2.50.1

Re: [PATCH] block: mtip32xx: Fix typos in comments and log messages

[Philipp Stanner]

On Sun, 2025-10-12 at 11:40 -0700, Alok Tiwari wrote:
> This patch corrects several minor typos and spelling errors in mtip32xx.c
> - Fixing "ge" -> "get" in a warning message.
> - Correcting "kernrel" -> "kernel", "progess" -> "progress"
>   "strucutre" -> "structure" in comments.

btw. I think listing such examples in the commit message for a mere
typo fix patch is a bit overkill; but of course not harmful.

> 
> no functional impact.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Reviewed-by: Philipp Stanner <phasta@kernel.org>

> ---
>  drivers/block/mtip32xx/mtip32xx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 567192e371a8..df184a9f006f 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -1337,7 +1337,7 @@ static int mtip_get_smart_attr(struct mtip_port *port, unsigned int id,
>  	memset(port->smart_buf, 0, ATA_SECT_SIZE);
>  	rv = mtip_get_smart_data(port, port->smart_buf, port->smart_buf_dma);
>  	if (rv) {
> -		dev_warn(&port->dd->pdev->dev, "Failed to ge SMART data\n");
> +		dev_warn(&port->dd->pdev->dev, "Failed to get SMART data\n");

One could think of adding a full stop '.'

Although the kernel is quite inconsistent with these anyways.

>  		return rv;
>  	}
>  
> @@ -2127,7 +2127,7 @@ static int mtip_hw_submit_io(struct driver_data *dd, struct request *rq,
>  /*
>   * Sysfs status dump.
>   *
> - * @dev  Pointer to the device structure, passed by the kernrel.
> + * @dev  Pointer to the device structure, passed by the kernel.
>   * @attr Pointer to the device_attribute structure passed by the kernel.
>   * @buf  Pointer to the char buffer that will receive the stats info.
>   *
> @@ -2679,7 +2679,7 @@ static int mtip_hw_get_identify(struct driver_data *dd)
>  		}
>  	}
>  
> -	/* get write protect progess */
> +	/* get write protect progress */
>  	memset(&attr242, 0, sizeof(struct smart_attr));
>  	if (mtip_get_smart_attr(dd->port, 242, &attr242))
>  		dev_warn(&dd->pdev->dev,
> @@ -3148,7 +3148,7 @@ static int mtip_block_compat_ioctl(struct block_device *dev,
>   * that each partition is also 4KB aligned. Non-aligned partitions adversely
>   * affects performance.
>   *
> - * @disk Pointer to the gendisk strucutre.
> + * @disk Pointer to the gendisk structure.
>   * @geo Pointer to a hd_geometry structure.
>   *
>   * return value

Re: [PATCH] block: mtip32xx: Fix typos in comments and log messages

[Andy Shevchenko]

On Sun, Oct 12, 2025 at 11:40:03AM -0700, Alok Tiwari wrote:
> This patch corrects several minor typos and spelling errors in mtip32xx.c
> - Fixing "ge" -> "get" in a warning message.
> - Correcting "kernrel" -> "kernel", "progess" -> "progress"
>   "strucutre" -> "structure" in comments.
> 
> no functional impact.

I would go further and add another patch that fixes kernel-doc warnings
(Missing Return section). This one LGTM, though.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko