[PATCH] Bluetooth: Fix bogus __le16_to_cpu call

[PATCH] Bluetooth: Fix bogus __le16_to_cpu call

[Johan Hedberg]

From: Johan Hedberg <johan.hedberg@intel.com>

The type member of struct hci_rp_read_page_scan_type is u8 so no
byte order conversion is necessary for it. This patch removes a bogus
call to __le16_to_cpu on it.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
 net/bluetooth/hci_event.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 8a1f511..1385807 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -641,7 +641,7 @@ static void hci_cc_read_page_scan_type(struct hci_dev *hdev,
 	BT_DBG("%s status 0x%2.2x", hdev->name, rp->status);
 
 	if (test_bit(HCI_INIT, &hdev->flags) && !rp->status)
-		hdev->page_scan_type = __le16_to_cpu(rp->type);
+		hdev->page_scan_type = rp->type;
 }
 
 static void hci_cc_write_page_scan_type(struct hci_dev *hdev,
-- 
1.7.10.4

Re: [PATCH] Bluetooth: Fix bogus __le16_to_cpu call

[Johan Hedberg]

Hi,

On Tue, Mar 19, 2013, Johan Hedberg wrote:
> The type member of struct hci_rp_read_page_scan_type is u8 so no
> byte order conversion is necessary for it. This patch removes a bogus
> call to __le16_to_cpu on it.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
>  net/bluetooth/hci_event.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 8a1f511..1385807 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -641,7 +641,7 @@ static void hci_cc_read_page_scan_type(struct hci_dev *hdev,
>  	BT_DBG("%s status 0x%2.2x", hdev->name, rp->status);
>  
>  	if (test_bit(HCI_INIT, &hdev->flags) && !rp->status)
> -		hdev->page_scan_type = __le16_to_cpu(rp->type);
> +		hdev->page_scan_type = rp->type;
>  }
>  
>  static void hci_cc_write_page_scan_type(struct hci_dev *hdev,

Just ignore this one. I should have checked for new emails on
linux-bluetooth before creating it since this was already taken care of.

Johan