From: Johannes Thumshirn <jthumshirn@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: Compilation breakage
Date: Tue, 16 Jul 2019 15:40:56 +0200 [thread overview]
Message-ID: <20190716134055.GG16644@x250.microfocus.com> (raw)
In-Reply-To: <CAHp75Vdb6uJ6Fkw43UrgLv=4vVx5k_g-f=fZ5KNnETfWo9G+ng@mail.gmail.com>
On Tue, Jul 16, 2019 at 04:29:27PM +0300, Andy Shevchenko wrote:
> On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > The following commit broke compilation
> >
> > commit d5178578bcd461cc79118c7a139882350fe505aa
> > Author: Johannes Thumshirn <jthumshirn@suse.de>
> > Date: Mon Jun 3 16:58:57 2019 +0200
> >
> > btrfs: directly call into crypto framework for checksumming
> >
> > ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined!
> > ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined!
> >
> > Obviously if we call directly libcrc32c, we may not remove a dependency.
This should already be fixed (there where actually three patches fixing this
issue).
https://lore.kernel.org/linux-btrfs/1562593403-19545-1-git-send-email-linux@roeck-us.net/
https://lore.kernel.org/linux-btrfs/20190708125134.3741552-1-arnd@arndb.de/
and
https://lore.kernel.org/linux-btrfs/20190702143903.49264-1-yuehaibing@huawei.com/
David I thought you staged the one from yuehaibing.
Thanks (and sorry for the inconvenience),
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-07-16 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHp75VcjxDjCy3JhZHEFjBcNX_L60J8pWOQX=8_5BxyW3bN6ag@mail.gmail.com>
2019-07-16 13:29 ` Compilation breakage Andy Shevchenko
2019-07-16 13:40 ` Johannes Thumshirn [this message]
2019-07-17 14:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716134055.GG16644@x250.microfocus.com \
--to=jthumshirn@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox