* Re: Compilation breakage [not found] <CAHp75VcjxDjCy3JhZHEFjBcNX_L60J8pWOQX=8_5BxyW3bN6ag@mail.gmail.com> @ 2019-07-16 13:29 ` Andy Shevchenko 2019-07-16 13:40 ` Johannes Thumshirn 0 siblings, 1 reply; 3+ messages in thread From: Andy Shevchenko @ 2019-07-16 13:29 UTC (permalink / raw) To: Johannes Thumshirn, David Sterba; +Cc: linux-btrfs On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > The following commit broke compilation > > commit d5178578bcd461cc79118c7a139882350fe505aa > Author: Johannes Thumshirn <jthumshirn@suse.de> > Date: Mon Jun 3 16:58:57 2019 +0200 > > btrfs: directly call into crypto framework for checksumming > > ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined! > ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined! > > Obviously if we call directly libcrc32c, we may not remove a dependency. > > Moreover, module soft dependency works only on most, but all module > init tools (for example, busybox). > > > -- > With Best Regards, > Andy Shevchenko -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Compilation breakage 2019-07-16 13:29 ` Compilation breakage Andy Shevchenko @ 2019-07-16 13:40 ` Johannes Thumshirn 2019-07-17 14:25 ` David Sterba 0 siblings, 1 reply; 3+ messages in thread From: Johannes Thumshirn @ 2019-07-16 13:40 UTC (permalink / raw) To: Andy Shevchenko; +Cc: David Sterba, linux-btrfs On Tue, Jul 16, 2019 at 04:29:27PM +0300, Andy Shevchenko wrote: > On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > The following commit broke compilation > > > > commit d5178578bcd461cc79118c7a139882350fe505aa > > Author: Johannes Thumshirn <jthumshirn@suse.de> > > Date: Mon Jun 3 16:58:57 2019 +0200 > > > > btrfs: directly call into crypto framework for checksumming > > > > ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined! > > ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined! > > > > Obviously if we call directly libcrc32c, we may not remove a dependency. This should already be fixed (there where actually three patches fixing this issue). https://lore.kernel.org/linux-btrfs/1562593403-19545-1-git-send-email-linux@roeck-us.net/ https://lore.kernel.org/linux-btrfs/20190708125134.3741552-1-arnd@arndb.de/ and https://lore.kernel.org/linux-btrfs/20190702143903.49264-1-yuehaibing@huawei.com/ David I thought you staged the one from yuehaibing. Thanks (and sorry for the inconvenience), Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Compilation breakage 2019-07-16 13:40 ` Johannes Thumshirn @ 2019-07-17 14:25 ` David Sterba 0 siblings, 0 replies; 3+ messages in thread From: David Sterba @ 2019-07-17 14:25 UTC (permalink / raw) To: Johannes Thumshirn; +Cc: Andy Shevchenko, David Sterba, linux-btrfs On Tue, Jul 16, 2019 at 03:40:56PM +0200, Johannes Thumshirn wrote: > On Tue, Jul 16, 2019 at 04:29:27PM +0300, Andy Shevchenko wrote: > > On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote: > > > > > > The following commit broke compilation > > > > > > commit d5178578bcd461cc79118c7a139882350fe505aa > > > Author: Johannes Thumshirn <jthumshirn@suse.de> > > > Date: Mon Jun 3 16:58:57 2019 +0200 > > > > > > btrfs: directly call into crypto framework for checksumming > > > > > > ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined! > > > ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined! > > > > > > Obviously if we call directly libcrc32c, we may not remove a dependency. > > This should already be fixed (there where actually three patches fixing this > issue). > https://lore.kernel.org/linux-btrfs/1562593403-19545-1-git-send-email-linux@roeck-us.net/ > https://lore.kernel.org/linux-btrfs/20190708125134.3741552-1-arnd@arndb.de/ > and > https://lore.kernel.org/linux-btrfs/20190702143903.49264-1-yuehaibing@huawei.com/ > > David I thought you staged the one from yuehaibing. Yes, the patch is queued for the next pull. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-17 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAHp75VcjxDjCy3JhZHEFjBcNX_L60J8pWOQX=8_5BxyW3bN6ag@mail.gmail.com>
2019-07-16 13:29 ` Compilation breakage Andy Shevchenko
2019-07-16 13:40 ` Johannes Thumshirn
2019-07-17 14:25 ` David Sterba
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox