Re: Compilation breakage

Re: Compilation breakage

[Andy Shevchenko]

On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> The following commit broke compilation
>
> commit d5178578bcd461cc79118c7a139882350fe505aa
> Author: Johannes Thumshirn <jthumshirn@suse.de>
> Date:   Mon Jun 3 16:58:57 2019 +0200
>
>    btrfs: directly call into crypto framework for checksumming
>
> ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined!
> ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined!
>
> Obviously if we call directly libcrc32c, we may not remove a dependency.
>
> Moreover, module soft dependency works only on most, but all module
> init tools (for example, busybox).
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko

Re: Compilation breakage

[Johannes Thumshirn]

On Tue, Jul 16, 2019 at 04:29:27PM +0300, Andy Shevchenko wrote:
> On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > The following commit broke compilation
> >
> > commit d5178578bcd461cc79118c7a139882350fe505aa
> > Author: Johannes Thumshirn <jthumshirn@suse.de>
> > Date:   Mon Jun 3 16:58:57 2019 +0200
> >
> >    btrfs: directly call into crypto framework for checksumming
> >
> > ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined!
> > ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined!
> >
> > Obviously if we call directly libcrc32c, we may not remove a dependency.

This should already be fixed (there where actually three patches fixing this
issue).
https://lore.kernel.org/linux-btrfs/1562593403-19545-1-git-send-email-linux@roeck-us.net/
https://lore.kernel.org/linux-btrfs/20190708125134.3741552-1-arnd@arndb.de/
and
https://lore.kernel.org/linux-btrfs/20190702143903.49264-1-yuehaibing@huawei.com/

David I thought you staged the one from yuehaibing.

Thanks (and sorry for the inconvenience),
	Johannes
-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: Compilation breakage

[David Sterba]

On Tue, Jul 16, 2019 at 03:40:56PM +0200, Johannes Thumshirn wrote:
> On Tue, Jul 16, 2019 at 04:29:27PM +0300, Andy Shevchenko wrote:
> > On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > The following commit broke compilation
> > >
> > > commit d5178578bcd461cc79118c7a139882350fe505aa
> > > Author: Johannes Thumshirn <jthumshirn@suse.de>
> > > Date:   Mon Jun 3 16:58:57 2019 +0200
> > >
> > >    btrfs: directly call into crypto framework for checksumming
> > >
> > > ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined!
> > > ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined!
> > >
> > > Obviously if we call directly libcrc32c, we may not remove a dependency.
> 
> This should already be fixed (there where actually three patches fixing this
> issue).
> https://lore.kernel.org/linux-btrfs/1562593403-19545-1-git-send-email-linux@roeck-us.net/
> https://lore.kernel.org/linux-btrfs/20190708125134.3741552-1-arnd@arndb.de/
> and
> https://lore.kernel.org/linux-btrfs/20190702143903.49264-1-yuehaibing@huawei.com/
> 
> David I thought you staged the one from yuehaibing.

Yes, the patch is queued for the next pull.