[PATCH] btrfs: qgroup: Remove outdated TODO comments

[PATCH] btrfs: qgroup: Remove outdated TODO comments

[Sidong Yang]

These comments are too old and outdated. It seems that it doesn't help.
So we can remove those.

Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
 fs/btrfs/qgroup.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index bfd45d52b1f5..db527c277901 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -25,17 +25,6 @@
 #include "sysfs.h"
 #include "tree-mod-log.h"
 
-/* TODO XXX FIXME
- *  - subvol delete -> delete when ref goes to 0? delete limits also?
- *  - reorganize keys
- *  - compressed
- *  - sync
- *  - limit
- *  - caches for ulists
- *  - performance benchmarks
- *  - check all ioctl parameters
- */
-
 /*
  * Helpers to access qgroup reservation
  *
-- 
2.25.1

Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments

[David Sterba]

On Fri, Feb 11, 2022 at 01:48:29PM +0000, Sidong Yang wrote:
> These comments are too old and outdated. It seems that it doesn't help.
> So we can remove those.
> 
> Signed-off-by: Sidong Yang <realwakka@gmail.com>

Added to misc-next, thanks.

Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments

[Qu Wenruo]

On 2022/2/11 21:48, Sidong Yang wrote:
> These comments are too old and outdated. It seems that it doesn't help.
> So we can remove those.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
> ---
>   fs/btrfs/qgroup.c | 11 -----------
>   1 file changed, 11 deletions(-)
>
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index bfd45d52b1f5..db527c277901 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -25,17 +25,6 @@
>   #include "sysfs.h"
>   #include "tree-mod-log.h"
>
> -/* TODO XXX FIXME
> - *  - subvol delete -> delete when ref goes to 0? delete limits also?

This is still under concern AFAIK.

Currently if we delete a subvolume, its qgroup number will changed to 0
but not removed.

Thanks,
Qu

> - *  - reorganize keys
> - *  - compressed
> - *  - sync
> - *  - limit
> - *  - caches for ulists
> - *  - performance benchmarks
> - *  - check all ioctl parameters
> - */
> -
>   /*
>    * Helpers to access qgroup reservation
>    *

Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments

[Sidong Yang]

On Sat, Feb 12, 2022 at 08:13:29AM +0800, Qu Wenruo wrote:
> 
> 
> On 2022/2/11 21:48, Sidong Yang wrote:
> > These comments are too old and outdated. It seems that it doesn't help.
> > So we can remove those.
> > 
> > Signed-off-by: Sidong Yang <realwakka@gmail.com>
> > ---
> >   fs/btrfs/qgroup.c | 11 -----------
> >   1 file changed, 11 deletions(-)
> > 
> > diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> > index bfd45d52b1f5..db527c277901 100644
> > --- a/fs/btrfs/qgroup.c
> > +++ b/fs/btrfs/qgroup.c
> > @@ -25,17 +25,6 @@
> >   #include "sysfs.h"
> >   #include "tree-mod-log.h"
> > 
> > -/* TODO XXX FIXME
> > - *  - subvol delete -> delete when ref goes to 0? delete limits also?
> 
> This is still under concern AFAIK.
> 
> Currently if we delete a subvolume, its qgroup number will changed to 0
> but not removed.

This issue is in btrfs-progs github issue list (#366). It has detailed
description in there. So, I think it's okay to delete this.

Thanks,
Sidong
> 
> Thanks,
> Qu
> 
> > - *  - reorganize keys
> > - *  - compressed
> > - *  - sync
> > - *  - limit
> > - *  - caches for ulists
> > - *  - performance benchmarks
> > - *  - check all ioctl parameters
> > - */
> > -
> >   /*
> >    * Helpers to access qgroup reservation
> >    *

Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments

[Qu Wenruo]

On 2022/2/12 18:17, Sidong Yang wrote:
> On Sat, Feb 12, 2022 at 08:13:29AM +0800, Qu Wenruo wrote:
>>
>>
>> On 2022/2/11 21:48, Sidong Yang wrote:
>>> These comments are too old and outdated. It seems that it doesn't help.
>>> So we can remove those.
>>>
>>> Signed-off-by: Sidong Yang <realwakka@gmail.com>
>>> ---
>>>    fs/btrfs/qgroup.c | 11 -----------
>>>    1 file changed, 11 deletions(-)
>>>
>>> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
>>> index bfd45d52b1f5..db527c277901 100644
>>> --- a/fs/btrfs/qgroup.c
>>> +++ b/fs/btrfs/qgroup.c
>>> @@ -25,17 +25,6 @@
>>>    #include "sysfs.h"
>>>    #include "tree-mod-log.h"
>>>
>>> -/* TODO XXX FIXME
>>> - *  - subvol delete -> delete when ref goes to 0? delete limits also?
>>
>> This is still under concern AFAIK.
>>
>> Currently if we delete a subvolume, its qgroup number will changed to 0
>> but not removed.
>
> This issue is in btrfs-progs github issue list (#366). It has detailed
> description in there. So, I think it's okay to delete this.

Oh, we have already migrated to a modern solution.

Then it looks good to me.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
>
> Thanks,
> Sidong
>>
>> Thanks,
>> Qu
>>
>>> - *  - reorganize keys
>>> - *  - compressed
>>> - *  - sync
>>> - *  - limit
>>> - *  - caches for ulists
>>> - *  - performance benchmarks
>>> - *  - check all ioctl parameters
>>> - */
>>> -
>>>    /*
>>>     * Helpers to access qgroup reservation
>>>     *