* [PATCH] btrfs: qgroup: Remove outdated TODO comments
@ 2022-02-11 13:48 Sidong Yang
2022-02-11 16:34 ` David Sterba
2022-02-12 0:13 ` Qu Wenruo
0 siblings, 2 replies; 5+ messages in thread
From: Sidong Yang @ 2022-02-11 13:48 UTC (permalink / raw)
To: dsterba, linux-btrfs; +Cc: Sidong Yang
These comments are too old and outdated. It seems that it doesn't help.
So we can remove those.
Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
fs/btrfs/qgroup.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index bfd45d52b1f5..db527c277901 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -25,17 +25,6 @@
#include "sysfs.h"
#include "tree-mod-log.h"
-/* TODO XXX FIXME
- * - subvol delete -> delete when ref goes to 0? delete limits also?
- * - reorganize keys
- * - compressed
- * - sync
- * - limit
- * - caches for ulists
- * - performance benchmarks
- * - check all ioctl parameters
- */
-
/*
* Helpers to access qgroup reservation
*
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments
2022-02-11 13:48 [PATCH] btrfs: qgroup: Remove outdated TODO comments Sidong Yang
@ 2022-02-11 16:34 ` David Sterba
2022-02-12 0:13 ` Qu Wenruo
1 sibling, 0 replies; 5+ messages in thread
From: David Sterba @ 2022-02-11 16:34 UTC (permalink / raw)
To: Sidong Yang; +Cc: dsterba, linux-btrfs
On Fri, Feb 11, 2022 at 01:48:29PM +0000, Sidong Yang wrote:
> These comments are too old and outdated. It seems that it doesn't help.
> So we can remove those.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments
2022-02-11 13:48 [PATCH] btrfs: qgroup: Remove outdated TODO comments Sidong Yang
2022-02-11 16:34 ` David Sterba
@ 2022-02-12 0:13 ` Qu Wenruo
2022-02-12 10:17 ` Sidong Yang
1 sibling, 1 reply; 5+ messages in thread
From: Qu Wenruo @ 2022-02-12 0:13 UTC (permalink / raw)
To: Sidong Yang, dsterba, linux-btrfs
On 2022/2/11 21:48, Sidong Yang wrote:
> These comments are too old and outdated. It seems that it doesn't help.
> So we can remove those.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
> ---
> fs/btrfs/qgroup.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index bfd45d52b1f5..db527c277901 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -25,17 +25,6 @@
> #include "sysfs.h"
> #include "tree-mod-log.h"
>
> -/* TODO XXX FIXME
> - * - subvol delete -> delete when ref goes to 0? delete limits also?
This is still under concern AFAIK.
Currently if we delete a subvolume, its qgroup number will changed to 0
but not removed.
Thanks,
Qu
> - * - reorganize keys
> - * - compressed
> - * - sync
> - * - limit
> - * - caches for ulists
> - * - performance benchmarks
> - * - check all ioctl parameters
> - */
> -
> /*
> * Helpers to access qgroup reservation
> *
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments
2022-02-12 0:13 ` Qu Wenruo
@ 2022-02-12 10:17 ` Sidong Yang
2022-02-12 10:26 ` Qu Wenruo
0 siblings, 1 reply; 5+ messages in thread
From: Sidong Yang @ 2022-02-12 10:17 UTC (permalink / raw)
To: Qu Wenruo; +Cc: dsterba, linux-btrfs
On Sat, Feb 12, 2022 at 08:13:29AM +0800, Qu Wenruo wrote:
>
>
> On 2022/2/11 21:48, Sidong Yang wrote:
> > These comments are too old and outdated. It seems that it doesn't help.
> > So we can remove those.
> >
> > Signed-off-by: Sidong Yang <realwakka@gmail.com>
> > ---
> > fs/btrfs/qgroup.c | 11 -----------
> > 1 file changed, 11 deletions(-)
> >
> > diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> > index bfd45d52b1f5..db527c277901 100644
> > --- a/fs/btrfs/qgroup.c
> > +++ b/fs/btrfs/qgroup.c
> > @@ -25,17 +25,6 @@
> > #include "sysfs.h"
> > #include "tree-mod-log.h"
> >
> > -/* TODO XXX FIXME
> > - * - subvol delete -> delete when ref goes to 0? delete limits also?
>
> This is still under concern AFAIK.
>
> Currently if we delete a subvolume, its qgroup number will changed to 0
> but not removed.
This issue is in btrfs-progs github issue list (#366). It has detailed
description in there. So, I think it's okay to delete this.
Thanks,
Sidong
>
> Thanks,
> Qu
>
> > - * - reorganize keys
> > - * - compressed
> > - * - sync
> > - * - limit
> > - * - caches for ulists
> > - * - performance benchmarks
> > - * - check all ioctl parameters
> > - */
> > -
> > /*
> > * Helpers to access qgroup reservation
> > *
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments
2022-02-12 10:17 ` Sidong Yang
@ 2022-02-12 10:26 ` Qu Wenruo
0 siblings, 0 replies; 5+ messages in thread
From: Qu Wenruo @ 2022-02-12 10:26 UTC (permalink / raw)
To: Sidong Yang; +Cc: dsterba, linux-btrfs
On 2022/2/12 18:17, Sidong Yang wrote:
> On Sat, Feb 12, 2022 at 08:13:29AM +0800, Qu Wenruo wrote:
>>
>>
>> On 2022/2/11 21:48, Sidong Yang wrote:
>>> These comments are too old and outdated. It seems that it doesn't help.
>>> So we can remove those.
>>>
>>> Signed-off-by: Sidong Yang <realwakka@gmail.com>
>>> ---
>>> fs/btrfs/qgroup.c | 11 -----------
>>> 1 file changed, 11 deletions(-)
>>>
>>> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
>>> index bfd45d52b1f5..db527c277901 100644
>>> --- a/fs/btrfs/qgroup.c
>>> +++ b/fs/btrfs/qgroup.c
>>> @@ -25,17 +25,6 @@
>>> #include "sysfs.h"
>>> #include "tree-mod-log.h"
>>>
>>> -/* TODO XXX FIXME
>>> - * - subvol delete -> delete when ref goes to 0? delete limits also?
>>
>> This is still under concern AFAIK.
>>
>> Currently if we delete a subvolume, its qgroup number will changed to 0
>> but not removed.
>
> This issue is in btrfs-progs github issue list (#366). It has detailed
> description in there. So, I think it's okay to delete this.
Oh, we have already migrated to a modern solution.
Then it looks good to me.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
>
> Thanks,
> Sidong
>>
>> Thanks,
>> Qu
>>
>>> - * - reorganize keys
>>> - * - compressed
>>> - * - sync
>>> - * - limit
>>> - * - caches for ulists
>>> - * - performance benchmarks
>>> - * - check all ioctl parameters
>>> - */
>>> -
>>> /*
>>> * Helpers to access qgroup reservation
>>> *
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-12 10:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-11 13:48 [PATCH] btrfs: qgroup: Remove outdated TODO comments Sidong Yang
2022-02-11 16:34 ` David Sterba
2022-02-12 0:13 ` Qu Wenruo
2022-02-12 10:17 ` Sidong Yang
2022-02-12 10:26 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox