public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Samuel <chris@csamuel.org>
To: linux-btrfs@vger.kernel.org
Subject: Re: discard synchronous on most SSDs?
Date: Sun, 16 Mar 2014 09:48:42 +1100	[thread overview]
Message-ID: <5324D8CA.1080407@csamuel.org> (raw)
In-Reply-To: <pan$86f37$20eb1911$444fa726$8400b046@cox.net>

On 15/03/14 22:26, Duncan wrote:

> Either that or that feature bit simply indicates trim support, not NCQ
> trim support.

You're quite right, I outsmarted myself by noticing at the fact that the 
kernel tests for ATA_LOG_NCQ_SEND_RECV_DSM_TRIM and unsets that for 
drives that don't support NCQ DSM TRIM and then seeing DSM TRIM in the 
SATA 3.1 spec and inferred they were the same thing.

Looking closer at the kernel code that tests for what trim to use with 
ATA_LOG_NCQ_SEND_RECV_DSM_TRIM it falls back to ATA_DSM_TRIM if it can't 
do the NCQ version.

Mea culpa!

-- 
  Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

  reply	other threads:[~2014-03-15 22:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09  7:48 Massive BTRFS performance degradation KC
2014-03-09  8:17 ` Swâmi Petaramesh
2014-03-09 10:01   ` Martin Steigerwald
2014-03-09 10:23     ` Swâmi Petaramesh
2014-03-09 11:33       ` Hugo Mills
2014-03-09 11:54         ` Martin Steigerwald
2014-03-09 12:10         ` Swâmi Petaramesh
2014-03-09 17:14           ` boris
2014-03-14  2:11         ` discard synchronous on most SSDs? Marc MERLIN
2014-03-14  3:39           ` Chris Murphy
2014-03-14  5:17             ` Marc MERLIN
2014-03-14  7:33               ` Chris Samuel
2014-03-14 19:26                 ` Marc MERLIN
2014-03-14 19:57                   ` Martin K. Petersen
2014-03-14 20:46                     ` Holger Hoffstätte
2014-03-15  4:21                       ` Marc MERLIN
2014-03-15  9:38                         ` Holger Hoffstätte
2014-03-15  5:25                     ` Chris Samuel
2014-03-15  6:48                       ` Chris Samuel
2014-03-15 11:26                         ` Duncan
2014-03-15 22:48                           ` Chris Samuel [this message]
2014-03-16  6:06                           ` Marc MERLIN
2014-03-16 17:09                             ` Chris Murphy
2014-03-16 16:22                       ` Martin K. Petersen
2014-03-16 17:50                         ` Marc MERLIN
2014-03-15  4:06                 ` Chris Samuel
2014-03-16 16:07                   ` Martin K. Petersen
2014-03-14 12:07               ` Duncan
2014-03-14 21:44               ` Chris Murphy
2014-03-14  7:27             ` Chris Samuel
2014-03-09 17:36   ` Massive BTRFS performance degradation Austin S Hemmelgarn
2014-03-09 18:55     ` Tobias Holst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5324D8CA.1080407@csamuel.org \
    --to=chris@csamuel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox