public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: discard synchronous on most SSDs?
Date: Sat, 15 Mar 2014 09:38:01 +0000 (UTC)	[thread overview]
Message-ID: <pan.2014.03.15.09.38.15@googlemail.com> (raw)
In-Reply-To: 20140315042116.GK6143@merlins.org

On Fri, 14 Mar 2014 21:21:16 -0700, Marc MERLIN wrote:

> On Fri, Mar 14, 2014 at 08:46:09PM +0000, Holger Hoffstätte wrote:
>> On Fri, 14 Mar 2014 15:57:41 -0400, Martin K. Petersen wrote:
>> 
>> > So right now I'm afraid we don't have a good way for a user to
>> > determine whether a device supports queued trims or not.
>> 
>> Mount with discard, unpack kernel tree, sync, rm -rf tree.
>> If it takes several seconds, you have sync discard, no?
> 
> Mmmh, interesting point.
> 
> legolas:/usr/src# time rm -rf linux-3.14-rc5 real	0m1.584s user	
0m0.008s
> sys	0m1.524s
> 
> I remounted my FS with remount,nodiscard, and the time was the same.
> 
>> This changed somewhere around kernel 3.8.x; before that it used to be
>> acceptably fast. Since then I only do batch trims, daily (server) or
>> weekly (laptop).
> 
> I'm never really timed this before. Is it supposed to be faster than
> 1.5s on a fast SSD?

No, ~1s + noise is OK and seems normal, depending on filesystem and
phase of the moon. To contrast here is the output from my laptop,
which has an old but still-going-strong Intel G2 with ext4:

$smartctl -i /dev/sda | grep ATA
ATA Version is:   ATA/ATAPI-7 T13/1532D revision 1
SATA Version is:  SATA 2.6, 3.0 Gb/s

without dicard:
rm -rf linux-3.12.14  0.05s user 1.28s system 98% cpu 1.364 total

remounted with discard & after an initial manual fstrim:
rm -rf linux-3.12.14  1.90s user 0.02s system 2% cpu 1:07.45 total

I think these numbers speak for themselves. :)

It's really good to know that SATA 3.1 apparently fixed this.

cheers
Holger


  reply	other threads:[~2014-03-15  9:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09  7:48 Massive BTRFS performance degradation KC
2014-03-09  8:17 ` Swâmi Petaramesh
2014-03-09 10:01   ` Martin Steigerwald
2014-03-09 10:23     ` Swâmi Petaramesh
2014-03-09 11:33       ` Hugo Mills
2014-03-09 11:54         ` Martin Steigerwald
2014-03-09 12:10         ` Swâmi Petaramesh
2014-03-09 17:14           ` boris
2014-03-14  2:11         ` discard synchronous on most SSDs? Marc MERLIN
2014-03-14  3:39           ` Chris Murphy
2014-03-14  5:17             ` Marc MERLIN
2014-03-14  7:33               ` Chris Samuel
2014-03-14 19:26                 ` Marc MERLIN
2014-03-14 19:57                   ` Martin K. Petersen
2014-03-14 20:46                     ` Holger Hoffstätte
2014-03-15  4:21                       ` Marc MERLIN
2014-03-15  9:38                         ` Holger Hoffstätte [this message]
2014-03-15  5:25                     ` Chris Samuel
2014-03-15  6:48                       ` Chris Samuel
2014-03-15 11:26                         ` Duncan
2014-03-15 22:48                           ` Chris Samuel
2014-03-16  6:06                           ` Marc MERLIN
2014-03-16 17:09                             ` Chris Murphy
2014-03-16 16:22                       ` Martin K. Petersen
2014-03-16 17:50                         ` Marc MERLIN
2014-03-15  4:06                 ` Chris Samuel
2014-03-16 16:07                   ` Martin K. Petersen
2014-03-14 12:07               ` Duncan
2014-03-14 21:44               ` Chris Murphy
2014-03-14  7:27             ` Chris Samuel
2014-03-09 17:36   ` Massive BTRFS performance degradation Austin S Hemmelgarn
2014-03-09 18:55     ` Tobias Holst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2014.03.15.09.38.15@googlemail.com \
    --to=holger.hoffstaette@googlemail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox