Re: [PATCH v6 4/5] smb/client: use bsearch() to find target in smb2_error_map_table

[David Howells <dhowells@redhat.com>]

ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev> wrote:

> Your second suggestion looks good. Should we change it to the following code?
> If you are okay with these changes, I can send the next version.
> 
> ```
> __inline_bsearch((const void *)(unsigned long)smb2_status, ...);
> 
> static __always_inline int cmp_smb2_status(const void *_key, const void
> *_pivot)
> {
>         __le32 key = (unsigned long)_key;
>         const struct status_to_posix_error *pivot = _pivot;
> 
>         if (key < pivot->smb2_status)
>                 return -1;
>         if (key > pivot->smb2_status)
>                 return 1;
>         return 0;
> }
> ```

__le32 key = (unsigned long)_key;

Ummm....  u32 key?  I'm pretty certain it's sorted in cpu-endian order.

Also, check the assembly - it might not actually matter as everything is
inlined.  The compiler might well optimise away with the thing being passed
through _key and any dereference of that entirely.

David