Re: [PATCH v6 2/5] cifs: Autogenerate SMB2 error mapping table

[ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>]

Hi David,

The following modifications make the table sorted in little-endian 
order. If you are okay with the modifications, I can send the next version.


```
diff --git a/fs/smb/client/gen_smb2_mapping b/fs/smb/client/gen_smb2_mapping
index 98f32ec75316..b7d9e99a19ea 100644
--- a/fs/smb/client/gen_smb2_mapping
+++ b/fs/smb/client/gen_smb2_mapping
@@ -26,7 +26,9 @@ while (<IN_FILE>) {
      if 
(m!^#define\s*([A-Za-z0-9_]+)\s+cpu_to_le32[(]([0-9a-fA-Fx]+)[)]\s+//\s+([-A-Z0-9_]+)!) 
{
         my $status = $1;
         my $code = $2;
-       my $ncode = hex($2);
+       my $ncode_cpu = hex($2);
+       my $bytes_le = pack('V', $ncode_cpu);
+       my $ncode_le = unpack('V', $bytes_le);
         my $error = $3;
         my $s;

@@ -38,7 +40,7 @@ while (<IN_FILE>) {
         my %s = (
             status => $status,
             code   => $code,
-           ncode  => $ncode,
+           ncode  => $ncode_le,
             error  => $error
             );
         $statuses{$status} = \%s;
```

Thanks,
ChenXiaoSong <chenxiaosong@kylinos.cn>

On 12/25/25 10:10 AM, chenxiaosong.chenxiaosong@linux.dev wrote:
> From: David Howells <dhowells@redhat.com>
> 
> +#
> +# Read the file
> +#
> +open IN_FILE, "<$ARGV[0]" || die;
> +while (<IN_FILE>) {
> +    chomp;
> +
> +    if (m!^#define\s*([A-Za-z0-9_]+)\s+cpu_to_le32[(]([0-9a-fA-Fx]+)[)]\s+//\s+([-A-Z0-9_]+)!) {
> +	my $status = $1;
> +	my $code = $2;
> +	my $ncode = hex($2);
> +	my $error = $3;
> +	my $s;
> +
> +	next if ($status =~ /^STATUS_SEVERITY/);
> +
> +	die "Duplicate status $status"
> +	    if exists($statuses{$status});
> +
> +	my %s = (
> +	    status => $status,
> +	    code   => $code,
> +	    ncode  => $ncode,
> +	    error  => $error
> +	    );
> +	$statuses{$status} = \%s;
> +	push @list, \%s;
> +    }
> +}
> +close IN_FILE || die;
> +