From: chenxiaosong.chenxiaosong@linux.dev
To: smfrench@gmail.com, linkinjeon@kernel.org, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
bharathsm@microsoft.com, senozhatsky@chromium.org,
dhowells@redhat.com
Cc: linux-cifs@vger.kernel.org, ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: [PATCH v6 0/5] smb: improve search speed of SMB2 maperror
Date: Thu, 25 Dec 2025 10:10:30 +0800 [thread overview]
Message-ID: <20251225021035.656639-1-chenxiaosong.chenxiaosong@linux.dev> (raw)
From: ChenXiaoSong <chenxiaosong@kylinos.cn>
Sort `smb2_error_map_table` array at build time, thanks to David for his patches.
v5: https://lore.kernel.org/linux-cifs/20251224023145.608165-1-chenxiaosong.chenxiaosong@linux.dev/
v5->v6:
- The following changes are based on David's suggestions. Thanks to David for the review.
- Patch #03 #04 #05: replace `err_map_num` with `ARRAY_SIZE(smb2_error_map_table)`
- Patch #03: add `__init` to `smb2_init_maperror()`
- Patch #04: use `__inline_bsearch()` instead of `bsearch()`
add `__always_inline` to `cmp_smb2_status()`
v4: https://lore.kernel.org/linux-cifs/20251206151826.2932970-1-chenxiaosong.chenxiaosong@linux.dev/
The following patches from v4 have already been merged into the mainline:
- 01ab0d1640e3 smb/server: rename include guard in smb_common.h
- d8f52650b24d smb/client: update some SMB2 status strings
- d159702c9492 smb/client: add two elements to smb2_error_map_table array
- 523ecd976632 smb: rename to STATUS_SMB_NO_PREAUTH_INTEGRITY_HASH_OVERLAP
- bf80d1517dc8 smb/client: remove unused elements from smb2_error_map_table array
- 6c1eb31ecb97 smb/client: reduce loop count in map_smb2_to_linux_error() by half
When searching for the last element and printing error message,
the comparison count are shown in the table below:
+----------+--------+--------+
| | Before | After |
| |Patchset|Patchset|
+----------+--------+--------+
|Comparison| 3486 | 10 |
| Count | | |
+----------+--------+--------+
ChenXiaoSong (3):
smb/client: check whether smb2_error_map_table is sorted in ascending
order
smb/client: use bsearch() to find target in smb2_error_map_table
smb/client: introduce KUnit test to check search result of
smb2_error_map_table
David Howells (2):
cifs: Label SMB2 statuses with errors
cifs: Autogenerate SMB2 error mapping table
fs/smb/Kconfig | 17 +
fs/smb/client/Makefile | 14 +
fs/smb/client/cifsfs.c | 5 +
fs/smb/client/gen_smb2_mapping | 85 +
fs/smb/client/smb2maperror.c | 2464 +-------------------
fs/smb/client/smb2maperror_test.c | 48 +
fs/smb/client/smb2proto.h | 1 +
fs/smb/common/smb2status.h | 3488 ++++++++++++++---------------
8 files changed, 1972 insertions(+), 4150 deletions(-)
create mode 100644 fs/smb/client/gen_smb2_mapping
create mode 100644 fs/smb/client/smb2maperror_test.c
--
2.43.0
next reply other threads:[~2025-12-25 2:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 2:10 chenxiaosong.chenxiaosong [this message]
2025-12-25 2:10 ` [PATCH v6 1/5] cifs: Label SMB2 statuses with errors chenxiaosong.chenxiaosong
2025-12-25 2:10 ` [PATCH v6 2/5] cifs: Autogenerate SMB2 error mapping table chenxiaosong.chenxiaosong
2025-12-27 10:53 ` ChenXiaoSong
2025-12-27 12:00 ` David Howells
2025-12-27 15:03 ` ChenXiaoSong
2025-12-27 15:50 ` David Howells
2025-12-27 16:05 ` ChenXiaoSong
2025-12-30 9:42 ` ChenXiaoSong
2025-12-30 21:08 ` David Howells
2025-12-30 21:14 ` David Howells
2025-12-30 3:55 ` ChenXiaoSong
2025-12-30 9:07 ` David Howells
2025-12-25 2:10 ` [PATCH v6 3/5] smb/client: check whether smb2_error_map_table is sorted in ascending order chenxiaosong.chenxiaosong
2025-12-25 2:10 ` [PATCH v6 4/5] smb/client: use bsearch() to find target in smb2_error_map_table chenxiaosong.chenxiaosong
2025-12-26 11:58 ` David Howells
2025-12-26 12:06 ` David Howells
2025-12-26 15:28 ` ChenXiaoSong
2025-12-27 2:18 ` ChenXiaoSong
2025-12-27 8:56 ` David Howells
2025-12-27 9:29 ` ChenXiaoSong
2025-12-27 11:59 ` David Howells
2025-12-27 8:53 ` David Howells
2025-12-25 2:10 ` [PATCH v6 5/5] smb/client: introduce KUnit test to check search result of smb2_error_map_table chenxiaosong.chenxiaosong
2025-12-28 15:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251225021035.656639-1-chenxiaosong.chenxiaosong@linux.dev \
--to=chenxiaosong.chenxiaosong@linux.dev \
--cc=bharathsm@microsoft.com \
--cc=chenxiaosong@kylinos.cn \
--cc=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox