From: David Howells <dhowells@redhat.com>
To: ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>
Cc: dhowells@redhat.com, Steve French <smfrench@gmail.com>,
linkinjeon@kernel.org, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
bharathsm@microsoft.com, senozhatsky@chromium.org,
linux-cifs@vger.kernel.org
Subject: Re: [PATCH v6 2/5] cifs: Autogenerate SMB2 error mapping table
Date: Tue, 30 Dec 2025 21:14:45 +0000 [thread overview]
Message-ID: <1369034.1767129285@warthog.procyon.org.uk> (raw)
In-Reply-To: <00150dea-4a30-49e3-a1c2-cd6e6561e238@linux.dev>
ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev> wrote:
> David, what do you think of the modifications? Call le32_to_cpu() to get a
> cpu-endian value before comparison.
In fact, you could store the cpu-endian values in the table. It's only
accessed by this routine (and the kunit test). Either:
+ print(OUT_FILE "{ /*$code*/ le32_to_cpu($status), $error, \"$full_status\" },\n");
or:
+ print(OUT_FILE "{ $code, $error, \"$full_status\" },\n");
as $code is the hex status value. You don't really need to include $status -
except that that uses the enum symbol - as the corresponding status name(s)
are included in $full_status.
David
next prev parent reply other threads:[~2025-12-30 21:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 2:10 [PATCH v6 0/5] smb: improve search speed of SMB2 maperror chenxiaosong.chenxiaosong
2025-12-25 2:10 ` [PATCH v6 1/5] cifs: Label SMB2 statuses with errors chenxiaosong.chenxiaosong
2025-12-25 2:10 ` [PATCH v6 2/5] cifs: Autogenerate SMB2 error mapping table chenxiaosong.chenxiaosong
2025-12-27 10:53 ` ChenXiaoSong
2025-12-27 12:00 ` David Howells
2025-12-27 15:03 ` ChenXiaoSong
2025-12-27 15:50 ` David Howells
2025-12-27 16:05 ` ChenXiaoSong
2025-12-30 9:42 ` ChenXiaoSong
2025-12-30 21:08 ` David Howells
2025-12-30 21:14 ` David Howells [this message]
2025-12-30 3:55 ` ChenXiaoSong
2025-12-30 9:07 ` David Howells
2025-12-25 2:10 ` [PATCH v6 3/5] smb/client: check whether smb2_error_map_table is sorted in ascending order chenxiaosong.chenxiaosong
2025-12-25 2:10 ` [PATCH v6 4/5] smb/client: use bsearch() to find target in smb2_error_map_table chenxiaosong.chenxiaosong
2025-12-26 11:58 ` David Howells
2025-12-26 12:06 ` David Howells
2025-12-26 15:28 ` ChenXiaoSong
2025-12-27 2:18 ` ChenXiaoSong
2025-12-27 8:56 ` David Howells
2025-12-27 9:29 ` ChenXiaoSong
2025-12-27 11:59 ` David Howells
2025-12-27 8:53 ` David Howells
2025-12-25 2:10 ` [PATCH v6 5/5] smb/client: introduce KUnit test to check search result of smb2_error_map_table chenxiaosong.chenxiaosong
2025-12-28 15:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369034.1767129285@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bharathsm@microsoft.com \
--cc=chenxiaosong.chenxiaosong@linux.dev \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox