From: Maxime Ripard <maxime@cerno.tech>
To: Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tony Lindgren <tony@atomide.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Yassine Oudjana <y.oudjana@protonmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH 17/22] clk: Switch from __clk_determine_rate to clk_core_round_rate_nolock
Date: Fri, 8 Apr 2022 11:10:32 +0200 [thread overview]
Message-ID: <20220408091037.2041955-18-maxime@cerno.tech> (raw)
In-Reply-To: <20220408091037.2041955-1-maxime@cerno.tech>
clk_mux_determine_rate_flags() will call into __clk_determine_rate()
with a clk_hw pointer, while it has access to the clk_core pointer
already.
This leads to back and forth between clk_hw and clk_core, while
__clk_determine_rate will only call clk_core_round_rate_nolock() with
the clk_core pointer it retrieved from the clk_hw.
Let's simplify things a bit by calling into clk_core_round_rate_nolock
directly.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/clk/clk.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ccb6e9686fb8..448ead0da1a5 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -543,6 +543,9 @@ static bool mux_is_better_rate(unsigned long rate, unsigned long now,
return now <= rate && now > best;
}
+static int clk_core_round_rate_nolock(struct clk_core *core,
+ struct clk_rate_request *req);
+
int clk_mux_determine_rate_flags(struct clk_hw *hw,
struct clk_rate_request *req,
unsigned long flags)
@@ -556,8 +559,12 @@ int clk_mux_determine_rate_flags(struct clk_hw *hw,
if (core->flags & CLK_SET_RATE_NO_REPARENT) {
parent = core->parent;
if (core->flags & CLK_SET_RATE_PARENT) {
- ret = __clk_determine_rate(parent ? parent->hw : NULL,
- &parent_req);
+ if (!parent) {
+ req->rate = 0;
+ return 0;
+ }
+
+ ret = clk_core_round_rate_nolock(parent, &parent_req);
if (ret)
return ret;
@@ -580,7 +587,7 @@ int clk_mux_determine_rate_flags(struct clk_hw *hw,
if (core->flags & CLK_SET_RATE_PARENT) {
parent_req = *req;
- ret = __clk_determine_rate(parent->hw, &parent_req);
+ ret = clk_core_round_rate_nolock(parent, &parent_req);
if (ret)
continue;
} else {
--
2.35.1
next prev parent reply other threads:[~2022-04-08 9:14 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 9:10 [PATCH 00/22] clk: More clock rate fixes and tests Maxime Ripard
2022-04-08 9:10 ` [PATCH 01/22] clk: Drop the rate range on clk_put() Maxime Ripard
2022-04-08 9:10 ` [PATCH 02/22] clk: tests: Add test suites description Maxime Ripard
2022-04-23 4:06 ` Stephen Boyd
2022-04-08 9:10 ` [PATCH 03/22] clk: tests: Add reference to the orphan mux bug report Maxime Ripard
2022-04-08 9:10 ` [PATCH 04/22] clk: tests: Add tests for uncached clock Maxime Ripard
2022-04-08 9:10 ` [PATCH 05/22] clk: tests: Add tests for single parent mux Maxime Ripard
2022-04-08 9:10 ` [PATCH 06/22] clk: tests: Add tests for mux with multiple parents Maxime Ripard
2022-04-08 9:10 ` [PATCH 07/22] clk: tests: Add some tests for orphan " Maxime Ripard
2022-04-08 9:10 ` [PATCH 08/22] clk: Take into account uncached clocks in clk_set_rate_range() Maxime Ripard
2022-04-08 9:10 ` [PATCH 09/22] clk: Fix clk_get_parent() documentation Maxime Ripard
2022-04-08 9:10 ` [PATCH 10/22] clk: Set req_rate on reparenting Maxime Ripard
2022-04-08 9:10 ` [PATCH 11/22] clk: Skip set_rate_range if our clock is orphan Maxime Ripard
2022-04-08 9:10 ` [PATCH 12/22] clk: Add our request boundaries in clk_core_init_rate_req Maxime Ripard
2022-04-08 9:10 ` [PATCH 13/22] clk: Change clk_core_init_rate_req prototype Maxime Ripard
2022-04-08 9:10 ` [PATCH 14/22] clk: Introduce clk_hw_init_rate_request() Maxime Ripard
2022-04-23 3:46 ` Stephen Boyd
2022-04-23 7:17 ` Maxime Ripard
2022-04-08 9:10 ` [PATCH 15/22] clk: Add missing clk_core_init_rate_req calls Maxime Ripard
2022-04-23 3:51 ` Stephen Boyd
2022-04-23 7:32 ` Maxime Ripard
2022-04-08 9:10 ` [PATCH 16/22] clk: Remove redundant clk_core_init_rate_req() call Maxime Ripard
2022-04-23 4:02 ` Stephen Boyd
2022-04-23 7:44 ` Maxime Ripard
2022-04-08 9:10 ` Maxime Ripard [this message]
2022-04-08 9:10 ` [PATCH 18/22] clk: Introduce clk_core_has_parent() Maxime Ripard
2022-04-08 9:10 ` [PATCH 19/22] clk: Stop forwarding clk_rate_requests to the parent Maxime Ripard
2022-04-08 9:10 ` [PATCH 20/22] clk: Zero the clk_rate_request structure Maxime Ripard
2022-04-08 9:10 ` [PATCH 21/22] clk: Test the clock pointer in clk_hw_get_name() Maxime Ripard
2022-04-08 9:10 ` [PATCH 22/22] clk: Prevent a clock without a rate to register Maxime Ripard
2022-04-08 9:18 ` Jerome Brunet
2022-04-08 10:41 ` Maxime Ripard
2022-04-08 11:24 ` Jerome Brunet
2022-04-08 12:55 ` Maxime Ripard
2022-04-08 14:48 ` Jerome Brunet
2022-04-08 15:36 ` Maxime Ripard
2022-04-11 7:40 ` Neil Armstrong
2022-04-12 12:56 ` Maxime Ripard
2022-04-11 8:20 ` Jerome Brunet
2022-04-23 4:42 ` Stephen Boyd
2022-04-23 9:17 ` Maxime Ripard
2022-04-29 2:08 ` Stephen Boyd
2022-04-29 15:45 ` Maxime Ripard
2022-04-08 12:17 ` Marek Szyprowski
2022-04-08 12:25 ` Maxime Ripard
2022-04-08 13:46 ` Marek Szyprowski
2022-04-23 4:12 ` Stephen Boyd
2022-04-23 7:49 ` Maxime Ripard
2022-04-10 12:06 ` [PATCH 00/22] clk: More clock rate fixes and tests Yassine Oudjana
2022-04-11 11:39 ` Maxime Ripard
2022-04-11 6:25 ` (EXT) " Alexander Stein
2022-04-11 7:24 ` Alexander Stein
2022-04-11 11:54 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408091037.2041955-18-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=alexander.stein@ew.tq-group.com \
--cc=jbrunet@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=naresh.kamboju@linaro.org \
--cc=narmstrong@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox