* [PATCH RESEND v2 0/2] update for versal net platform @ 2023-11-29 11:29 Jay Buddhabhatti 2023-11-29 11:29 ` [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate Jay Buddhabhatti 2023-11-29 11:29 ` [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic Jay Buddhabhatti 0 siblings, 2 replies; 6+ messages in thread From: Jay Buddhabhatti @ 2023-11-29 11:29 UTC (permalink / raw) To: mturquette, sboyd, michal.simek, shubhrajyoti.datta Cc: linux-clk, linux-arm-kernel, linux-kernel, Jay Buddhabhatti Update clock driver to support for Versal NET platforms. Versal Net is a new AMD/Xilinx SoC. V1 link: https://lore.kernel.org/lkml/20231016113002.15929-1-jay.buddhabhatti@amd.com/ V1->V2: - Updated logic to use fls() to get max width of divider - Added fixes tag in patch #1 Jay Buddhabhatti (2): drivers: clk: zynqmp: calculate closest mux rate drivers: clk: zynqmp: update divider round rate logic drivers/clk/zynqmp/clk-mux-zynqmp.c | 2 +- drivers/clk/zynqmp/divider.c | 66 +++-------------------------- 2 files changed, 6 insertions(+), 62 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate 2023-11-29 11:29 [PATCH RESEND v2 0/2] update for versal net platform Jay Buddhabhatti @ 2023-11-29 11:29 ` Jay Buddhabhatti 2023-12-17 1:21 ` Stephen Boyd 2023-11-29 11:29 ` [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic Jay Buddhabhatti 1 sibling, 1 reply; 6+ messages in thread From: Jay Buddhabhatti @ 2023-11-29 11:29 UTC (permalink / raw) To: mturquette, sboyd, michal.simek, shubhrajyoti.datta Cc: linux-clk, linux-arm-kernel, linux-kernel, Jay Buddhabhatti Currently zynqmp clock driver is not calculating closest mux rate and because of that Linux is not setting proper frequency for CPU and not able to set given frequency for dynamic frequency scaling. E.g., In current logic initial acpu clock parent and frequency as below apll1 0 0 0 2199999978 0 0 50000 Y acpu0_mux 0 0 0 2199999978 0 0 50000 Y acpu0_idiv1 0 0 0 2199999978 0 0 50000 Y acpu0 0 0 0 2199999978 0 0 50000 Y After changing acpu frequency to 549999994 Hz using CPU freq scaling its selecting incorrect parent which is not closest frequency. rpll_to_xpd 0 0 0 1599999984 0 0 50000 Y acpu0_mux 0 0 0 1599999984 0 0 50000 Y acpu0_div1 0 0 0 533333328 0 0 50000 Y acpu0 0 0 0 533333328 0 0 50000 Y Parent should remain same since 549999994 = 2199999978 / 4. So use __clk_mux_determine_rate_closest() generic function to calculate closest rate for mux clock. After this change its selecting correct parent and correct clock rate. apll1 0 0 0 2199999978 0 0 50000 Y acpu0_mux 0 0 0 2199999978 0 0 50000 Y acpu0_div1 0 0 0 549999995 0 0 50000 Y acpu0 0 0 0 549999995 0 0 50000 Y Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com> --- drivers/clk/zynqmp/clk-mux-zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/zynqmp/clk-mux-zynqmp.c b/drivers/clk/zynqmp/clk-mux-zynqmp.c index 60359333f26d..9b5d3050b742 100644 --- a/drivers/clk/zynqmp/clk-mux-zynqmp.c +++ b/drivers/clk/zynqmp/clk-mux-zynqmp.c @@ -89,7 +89,7 @@ static int zynqmp_clk_mux_set_parent(struct clk_hw *hw, u8 index) static const struct clk_ops zynqmp_clk_mux_ops = { .get_parent = zynqmp_clk_mux_get_parent, .set_parent = zynqmp_clk_mux_set_parent, - .determine_rate = __clk_mux_determine_rate, + .determine_rate = __clk_mux_determine_rate_closest, }; static const struct clk_ops zynqmp_clk_mux_ro_ops = { -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate 2023-11-29 11:29 ` [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate Jay Buddhabhatti @ 2023-12-17 1:21 ` Stephen Boyd 0 siblings, 0 replies; 6+ messages in thread From: Stephen Boyd @ 2023-12-17 1:21 UTC (permalink / raw) To: Jay Buddhabhatti, michal.simek, mturquette, shubhrajyoti.datta Cc: linux-clk, linux-arm-kernel, linux-kernel, Jay Buddhabhatti Quoting Jay Buddhabhatti (2023-11-29 03:29:15) > Currently zynqmp clock driver is not calculating closest mux rate and > because of that Linux is not setting proper frequency for CPU and > not able to set given frequency for dynamic frequency scaling. > > E.g., In current logic initial acpu clock parent and frequency as below > apll1 0 0 0 2199999978 0 0 50000 Y > acpu0_mux 0 0 0 2199999978 0 0 50000 Y > acpu0_idiv1 0 0 0 2199999978 0 0 50000 Y > acpu0 0 0 0 2199999978 0 0 50000 Y > > After changing acpu frequency to 549999994 Hz using CPU freq scaling its > selecting incorrect parent which is not closest frequency. > rpll_to_xpd 0 0 0 1599999984 0 0 50000 Y > acpu0_mux 0 0 0 1599999984 0 0 50000 Y > acpu0_div1 0 0 0 533333328 0 0 50000 Y > acpu0 0 0 0 533333328 0 0 50000 Y > > Parent should remain same since 549999994 = 2199999978 / 4. > > So use __clk_mux_determine_rate_closest() generic function to calculate > closest rate for mux clock. After this change its selecting correct > parent and correct clock rate. > apll1 0 0 0 2199999978 0 0 50000 Y > acpu0_mux 0 0 0 2199999978 0 0 50000 Y > acpu0_div1 0 0 0 549999995 0 0 50000 Y > acpu0 0 0 0 549999995 0 0 50000 Y > > Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") > Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com> > --- Applied to clk-next ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic 2023-11-29 11:29 [PATCH RESEND v2 0/2] update for versal net platform Jay Buddhabhatti 2023-11-29 11:29 ` [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate Jay Buddhabhatti @ 2023-11-29 11:29 ` Jay Buddhabhatti 2023-12-17 1:21 ` Stephen Boyd 1 sibling, 1 reply; 6+ messages in thread From: Jay Buddhabhatti @ 2023-11-29 11:29 UTC (permalink / raw) To: mturquette, sboyd, michal.simek, shubhrajyoti.datta Cc: linux-clk, linux-arm-kernel, linux-kernel, Jay Buddhabhatti Currently zynqmp divider round rate is considering single parent and calculating rate and parent rate accordingly. But if divider clock flag is set to SET_RATE_PARENT then its not trying to traverse through all parent rate and not selecting best parent rate from that. So use common divider_round_rate() which is traversing through all clock parents and its rate and calculating proper parent rate. Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com> --- drivers/clk/zynqmp/divider.c | 66 +++--------------------------------- 1 file changed, 5 insertions(+), 61 deletions(-) diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c index 33a3b2a22659..5a00487ae408 100644 --- a/drivers/clk/zynqmp/divider.c +++ b/drivers/clk/zynqmp/divider.c @@ -110,52 +110,6 @@ static unsigned long zynqmp_clk_divider_recalc_rate(struct clk_hw *hw, return DIV_ROUND_UP_ULL(parent_rate, value); } -static void zynqmp_get_divider2_val(struct clk_hw *hw, - unsigned long rate, - struct zynqmp_clk_divider *divider, - u32 *bestdiv) -{ - int div1; - int div2; - long error = LONG_MAX; - unsigned long div1_prate; - struct clk_hw *div1_parent_hw; - struct zynqmp_clk_divider *pdivider; - struct clk_hw *div2_parent_hw = clk_hw_get_parent(hw); - - if (!div2_parent_hw) - return; - - pdivider = to_zynqmp_clk_divider(div2_parent_hw); - if (!pdivider) - return; - - div1_parent_hw = clk_hw_get_parent(div2_parent_hw); - if (!div1_parent_hw) - return; - - div1_prate = clk_hw_get_rate(div1_parent_hw); - *bestdiv = 1; - for (div1 = 1; div1 <= pdivider->max_div;) { - for (div2 = 1; div2 <= divider->max_div;) { - long new_error = ((div1_prate / div1) / div2) - rate; - - if (abs(new_error) < abs(error)) { - *bestdiv = div2; - error = new_error; - } - if (divider->flags & CLK_DIVIDER_POWER_OF_TWO) - div2 = div2 << 1; - else - div2++; - } - if (pdivider->flags & CLK_DIVIDER_POWER_OF_TWO) - div1 = div1 << 1; - else - div1++; - } -} - /** * zynqmp_clk_divider_round_rate() - Round rate of divider clock * @hw: handle between common and hardware-specific interfaces @@ -174,6 +128,7 @@ static long zynqmp_clk_divider_round_rate(struct clk_hw *hw, u32 div_type = divider->div_type; u32 bestdiv; int ret; + u8 width; /* if read only, just return current value */ if (divider->flags & CLK_DIVIDER_READ_ONLY) { @@ -193,23 +148,12 @@ static long zynqmp_clk_divider_round_rate(struct clk_hw *hw, return DIV_ROUND_UP_ULL((u64)*prate, bestdiv); } - bestdiv = zynqmp_divider_get_val(*prate, rate, divider->flags); - - /* - * In case of two divisors, compute best divider values and return - * divider2 value based on compute value. div1 will be automatically - * set to optimum based on required total divider value. - */ - if (div_type == TYPE_DIV2 && - (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT)) { - zynqmp_get_divider2_val(hw, rate, divider, &bestdiv); - } + width = fls(divider->max_div); - if ((clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) && divider->is_frac) - bestdiv = rate % *prate ? 1 : bestdiv; + rate = divider_round_rate(hw, rate, prate, NULL, width, divider->flags); - bestdiv = min_t(u32, bestdiv, divider->max_div); - *prate = rate * bestdiv; + if (divider->is_frac && (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) && (rate % *prate)) + *prate = rate; return rate; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic 2023-11-29 11:29 ` [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic Jay Buddhabhatti @ 2023-12-17 1:21 ` Stephen Boyd 0 siblings, 0 replies; 6+ messages in thread From: Stephen Boyd @ 2023-12-17 1:21 UTC (permalink / raw) To: Jay Buddhabhatti, michal.simek, mturquette, shubhrajyoti.datta Cc: linux-clk, linux-arm-kernel, linux-kernel, Jay Buddhabhatti Quoting Jay Buddhabhatti (2023-11-29 03:29:16) > Currently zynqmp divider round rate is considering single parent and > calculating rate and parent rate accordingly. But if divider clock flag > is set to SET_RATE_PARENT then its not trying to traverse through all > parent rate and not selecting best parent rate from that. So use common > divider_round_rate() which is traversing through all clock parents and > its rate and calculating proper parent rate. > > Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") > Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com> > --- Applied to clk-next ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND v2 0/2] update for versal net platform @ 2023-11-09 12:05 Jay Buddhabhatti 2023-11-09 12:05 ` [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic Jay Buddhabhatti 0 siblings, 1 reply; 6+ messages in thread From: Jay Buddhabhatti @ 2023-11-09 12:05 UTC (permalink / raw) To: mturquette, sboyd, michal.simek, olof, shubhrajyoti.datta Cc: linux-clk, linux-arm-kernel, linux-kernel, Jay Buddhabhatti Update clock driver to support for Versal NET platforms. Versal Net is a new AMD/Xilinx SoC. V1 link: https://lore.kernel.org/lkml/20231016113002.15929-1-jay.buddhabhatti@amd.com/ V1->V2: - Updated logic to use fls() to get max width of divider - Added fixes tag in patch #1 Jay Buddhabhatti (2): drivers: clk: zynqmp: calculate closest mux rate drivers: clk: zynqmp: update divider round rate logic drivers/clk/zynqmp/clk-mux-zynqmp.c | 2 +- drivers/clk/zynqmp/divider.c | 66 +++-------------------------- 2 files changed, 6 insertions(+), 62 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic 2023-11-09 12:05 [PATCH RESEND v2 0/2] update for versal net platform Jay Buddhabhatti @ 2023-11-09 12:05 ` Jay Buddhabhatti 0 siblings, 0 replies; 6+ messages in thread From: Jay Buddhabhatti @ 2023-11-09 12:05 UTC (permalink / raw) To: mturquette, sboyd, michal.simek, olof, shubhrajyoti.datta Cc: linux-clk, linux-arm-kernel, linux-kernel, Jay Buddhabhatti Currently zynqmp divider round rate is considering single parent and calculating rate and parent rate accordingly. But if divider clock flag is set to SET_RATE_PARENT then its not trying to traverse through all parent rate and not selecting best parent rate from that. So use common divider_round_rate() which is traversing through all clock parents and its rate and calculating proper parent rate. Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com> --- drivers/clk/zynqmp/divider.c | 66 +++--------------------------------- 1 file changed, 5 insertions(+), 61 deletions(-) diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c index 33a3b2a22659..5a00487ae408 100644 --- a/drivers/clk/zynqmp/divider.c +++ b/drivers/clk/zynqmp/divider.c @@ -110,52 +110,6 @@ static unsigned long zynqmp_clk_divider_recalc_rate(struct clk_hw *hw, return DIV_ROUND_UP_ULL(parent_rate, value); } -static void zynqmp_get_divider2_val(struct clk_hw *hw, - unsigned long rate, - struct zynqmp_clk_divider *divider, - u32 *bestdiv) -{ - int div1; - int div2; - long error = LONG_MAX; - unsigned long div1_prate; - struct clk_hw *div1_parent_hw; - struct zynqmp_clk_divider *pdivider; - struct clk_hw *div2_parent_hw = clk_hw_get_parent(hw); - - if (!div2_parent_hw) - return; - - pdivider = to_zynqmp_clk_divider(div2_parent_hw); - if (!pdivider) - return; - - div1_parent_hw = clk_hw_get_parent(div2_parent_hw); - if (!div1_parent_hw) - return; - - div1_prate = clk_hw_get_rate(div1_parent_hw); - *bestdiv = 1; - for (div1 = 1; div1 <= pdivider->max_div;) { - for (div2 = 1; div2 <= divider->max_div;) { - long new_error = ((div1_prate / div1) / div2) - rate; - - if (abs(new_error) < abs(error)) { - *bestdiv = div2; - error = new_error; - } - if (divider->flags & CLK_DIVIDER_POWER_OF_TWO) - div2 = div2 << 1; - else - div2++; - } - if (pdivider->flags & CLK_DIVIDER_POWER_OF_TWO) - div1 = div1 << 1; - else - div1++; - } -} - /** * zynqmp_clk_divider_round_rate() - Round rate of divider clock * @hw: handle between common and hardware-specific interfaces @@ -174,6 +128,7 @@ static long zynqmp_clk_divider_round_rate(struct clk_hw *hw, u32 div_type = divider->div_type; u32 bestdiv; int ret; + u8 width; /* if read only, just return current value */ if (divider->flags & CLK_DIVIDER_READ_ONLY) { @@ -193,23 +148,12 @@ static long zynqmp_clk_divider_round_rate(struct clk_hw *hw, return DIV_ROUND_UP_ULL((u64)*prate, bestdiv); } - bestdiv = zynqmp_divider_get_val(*prate, rate, divider->flags); - - /* - * In case of two divisors, compute best divider values and return - * divider2 value based on compute value. div1 will be automatically - * set to optimum based on required total divider value. - */ - if (div_type == TYPE_DIV2 && - (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT)) { - zynqmp_get_divider2_val(hw, rate, divider, &bestdiv); - } + width = fls(divider->max_div); - if ((clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) && divider->is_frac) - bestdiv = rate % *prate ? 1 : bestdiv; + rate = divider_round_rate(hw, rate, prate, NULL, width, divider->flags); - bestdiv = min_t(u32, bestdiv, divider->max_div); - *prate = rate * bestdiv; + if (divider->is_frac && (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) && (rate % *prate)) + *prate = rate; return rate; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-17 1:21 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-11-29 11:29 [PATCH RESEND v2 0/2] update for versal net platform Jay Buddhabhatti 2023-11-29 11:29 ` [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate Jay Buddhabhatti 2023-12-17 1:21 ` Stephen Boyd 2023-11-29 11:29 ` [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic Jay Buddhabhatti 2023-12-17 1:21 ` Stephen Boyd -- strict thread matches above, loose matches on Subject: below -- 2023-11-09 12:05 [PATCH RESEND v2 0/2] update for versal net platform Jay Buddhabhatti 2023-11-09 12:05 ` [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic Jay Buddhabhatti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox