Re: [PATCH v3 02/18] dt-bindings: clock: qcom: Update sc8280xp camcc bindings

[Jagadeesh Kona <quic_jkona@quicinc.com>]

On 3/28/2025 1:37 PM, Krzysztof Kozlowski wrote:
> On Thu, Mar 27, 2025 at 03:22:22PM +0530, Jagadeesh Kona wrote:
>> Move SC8280XP camcc bindings from SM8450 to SA8775P camcc.
>> SC8280XP camcc only requires the MMCX power domain, unlike
>> SM8450 camcc which will now support both MMCX and MXC power
>> domains.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml | 2 ++
>>  Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml  | 2 --
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
>> index 81623f59d11d73839e5c551411a52427e2f28415..127c369dd452608e5e7a52c7297b6b343d1c1bf8 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
>> @@ -17,12 +17,14 @@ description: |
>>    See also:
>>      include/dt-bindings/clock/qcom,qcs8300-camcc.h
>>      include/dt-bindings/clock/qcom,sa8775p-camcc.h
>> +    include/dt-bindings/clock/qcom,sc8280xp-camcc.h
>>  
>>  properties:
>>    compatible:
>>      enum:
>>        - qcom,qcs8300-camcc
>>        - qcom,sa8775p-camcc
>> +      - qcom,sc8280xp-camcc
> 
> That's not equivalent. You miss required-opps.
> 

Yes, I will check and fix it in the next series.

Thanks,
Jagadeesh

> Best regards,
> Krzysztof
>