From: Marek Vasut <marex@denx.de>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: linux-clk@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Michael Walle <michael@walle.cc>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Rob Herring <robh@kernel.org>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Stephen Boyd <sboyd@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
devicetree@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 4/4] clk: fsl-sai: Add MCLK generation support
Date: Mon, 30 Dec 2024 01:47:16 +0100 [thread overview]
Message-ID: <842e5043-13d4-4e9a-b306-7319c187b5e8@denx.de> (raw)
In-Reply-To: <20241230012836.GC28662@localhost.localdomain>
On 12/30/24 2:28 AM, Peng Fan wrote:
[...]
>> static int fsl_sai_clk_probe(struct platform_device *pdev)
>> {
>> struct device *dev = &pdev->dev;
>> const struct fsl_sai_data *data = device_get_match_data(dev);
>> - struct fsl_sai_clk *sai_clk;
>> struct clk_parent_data pdata = { .index = 0 };
>> + struct fsl_sai_clk *sai_clk;
>> + struct clk *clk_bus;
>> void __iomem *base;
>> struct clk_hw *hw;
>>
>> @@ -47,39 +65,74 @@ static int fsl_sai_clk_probe(struct platform_device *pdev)
>> if (IS_ERR(base))
>> return PTR_ERR(base);
>>
>> + clk_bus = devm_clk_get_enabled(dev, "bus");
>> + if (IS_ERR(clk_bus))
>> + return PTR_ERR(clk_bus);
>> +
>
> This only applies to i.MX?
I think so ... what am I missing , some Vybrid / Layerscape detail ?
next prev parent reply other threads:[~2024-12-30 0:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 16:22 [PATCH v2 1/4] dt-bindings: clock: fsl-sai: Document i.MX8M support Marek Vasut
2024-12-26 16:22 ` [PATCH v2 2/4] clk: fsl-sai: Add i.MX8M support with 8 byte register offset Marek Vasut
2024-12-30 1:24 ` Peng Fan
2024-12-26 16:22 ` [PATCH v2 3/4] dt-bindings: clock: fsl-sai: Document clock-cells = <1> support Marek Vasut
2024-12-27 17:50 ` Conor Dooley
2024-12-26 16:22 ` [PATCH v2 4/4] clk: fsl-sai: Add MCLK generation support Marek Vasut
2024-12-30 1:28 ` Peng Fan
2024-12-30 0:47 ` Marek Vasut [this message]
2024-12-30 7:51 ` Michael Walle
2024-12-30 22:18 ` Marek Vasut
2025-01-02 9:58 ` Michael Walle
2025-01-02 13:34 ` Marek Vasut
2025-01-07 8:52 ` Michael Walle
2024-12-27 17:51 ` [PATCH v2 1/4] dt-bindings: clock: fsl-sai: Document i.MX8M support Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=842e5043-13d4-4e9a-b306-7319c187b5e8@denx.de \
--to=marex@denx.de \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mturquette@baylibre.com \
--cc=nicoleotsuka@gmail.com \
--cc=peng.fan@oss.nxp.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox