public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <michael@walle.cc>
To: "Marek Vasut" <marex@denx.de>, <linux-clk@vger.kernel.org>
Cc: "Conor Dooley" <conor+dt@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Nicolin Chen" <nicoleotsuka@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Shengjiu Wang" <shengjiu.wang@gmail.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Takashi Iwai" <tiwai@suse.com>, "Xiubo Li" <Xiubo.Lee@gmail.com>,
	<devicetree@vger.kernel.org>, <linux-sound@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] clk: fsl-sai: Add MCLK generation support
Date: Thu, 02 Jan 2025 10:58:59 +0100	[thread overview]
Message-ID: <D6RHZ8B051X5.3NA8EAPRI62XS@walle.cc> (raw)
In-Reply-To: <36665ab9-16de-4f77-a55f-b7942dc0c1bf@denx.de>

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

Hi,

> > ..Which is the
> > normal use case for this pin. This driver was created because the
> > LS1028A doesn't have a MCLK pin, so we've "misused" the BCLK pin,
> > with the restriction that only integer dividers are possible.
>
> I have a system that is wired a bit unfortunately, I need to source 
> codec clock, where the codec is the clock consumer and needs to be able 
> to control the clock (SGTL5000). SAI MCLK is the only way I can get them 
> out of the pin I need, hence this patch.

Which is also the default case, no?

> > Also I'd expect that the imx
> > SoCs already supports the MCLK for audio applications. Isn't that
> > the case?
>
> That does not work if the MCLK has to be enabled/disabled by the MCLK 
> clock consumer .

Why's that?

Don't get me wrong. I don't have anything against this patch, I'm
just confused, why that isn't already working with the current MCLK
driver as this seems to be the usual requirements.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

  reply	other threads:[~2025-01-02  9:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 16:22 [PATCH v2 1/4] dt-bindings: clock: fsl-sai: Document i.MX8M support Marek Vasut
2024-12-26 16:22 ` [PATCH v2 2/4] clk: fsl-sai: Add i.MX8M support with 8 byte register offset Marek Vasut
2024-12-30  1:24   ` Peng Fan
2024-12-26 16:22 ` [PATCH v2 3/4] dt-bindings: clock: fsl-sai: Document clock-cells = <1> support Marek Vasut
2024-12-27 17:50   ` Conor Dooley
2024-12-26 16:22 ` [PATCH v2 4/4] clk: fsl-sai: Add MCLK generation support Marek Vasut
2024-12-30  1:28   ` Peng Fan
2024-12-30  0:47     ` Marek Vasut
2024-12-30  7:51   ` Michael Walle
2024-12-30 22:18     ` Marek Vasut
2025-01-02  9:58       ` Michael Walle [this message]
2025-01-02 13:34         ` Marek Vasut
2025-01-07  8:52           ` Michael Walle
2024-12-27 17:51 ` [PATCH v2 1/4] dt-bindings: clock: fsl-sai: Document i.MX8M support Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D6RHZ8B051X5.3NA8EAPRI62XS@walle.cc \
    --to=michael@walle.cc \
    --cc=Xiubo.Lee@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mturquette@baylibre.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox