Re: [PATCH 04/11] PCI/IDE: Selective Stream IDE enumeration

[Dan Williams <dan.j.williams@intel.com>]

Alexey Kardashevskiy wrote:
> On 21/2/25 05:07, Dan Williams wrote:
> > Alexey Kardashevskiy wrote:
> >> On 6/12/24 09:23, Dan Williams wrote:
> >>> Link encryption is a new PCIe capability defined by "PCIe 6.2 section
> >>> 6.33 Integrity & Data Encryption (IDE)". While it is a standalone port
> >>> and endpoint capability, it is also a building block for device security
> >>> defined by "PCIe 6.2 section 11 TEE Device Interface Security Protocol
> >>> (TDISP)". That protocol coordinates device security setup between the
> >>> platform TSM (TEE Security Manager) and device DSM (Device Security
> >>> Manager). While the platform TSM can allocate resources like stream-ids
> >>> and manage keys, it still requires system software to manage the IDE
> >>> capability register block.
> >>>
> >>> Add register definitions and basic enumeration for a "selective-stream"
> >>> IDE capability, a follow on change will select the new CONFIG_PCI_IDE
> >>> symbol. Note that while the IDE specifications defines both a
> >>> point-to-point "Link" stream and a root-port-to-endpoint "Selective"
> >>> stream, only "Selective" is considered for now for platform TSM
> >>> coordination.
> >>>
> >>> Co-developed-by: Alexey Kardashevskiy <aik@amd.com>
> >>> Signed-off-by: Alexey Kardashevskiy <aik@amd.com>
> >>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> >>> ---
[..]
> > 
> > Whoops, was moving too fast, fixed.
> 
> just double checking - fixed 0x000fff00 too, right?

In fact I have dropped error prone mask definitions and "getter" macros
altogether after other comments from Yilun and Jonathan.

I noticed that back in v6.9 Paolo had the good sense to do this:

    3c7a8e190bc5 uapi: introduce uapi-friendly macros for GENMASK

...so now all the IDE defines that need a mask are using __GENMASK in
v2.