Re: [PATCH v13 00/22] Type2 device basic support

[Alejandro Lucero Palau <alucerop@amd.com>]

Hi Allison,


I forgot to fix the problem you reported in v12.


I rebuild everything patch by patch in each new version ... but your 
comments on the cover letter, which I agree it is the right place to 
complain, correlates with none, and I just missed it.


Apologies. I'll fix it in v14 ...


On 4/14/25 22:21, Alison Schofield wrote:
> On Mon, Apr 14, 2025 at 04:13:14PM +0100, alejandro.lucero-palau@amd.com wrote:
>> From: Alejandro Lucero <alucerop@amd.com>
>
> Not able to make the cxl test module.
>
> test/mem.c: In function ‘cxl_mock_mem_probe’:
> linux/include/linux/stddef.h:8:14: warning: passing argument 3 of ‘cxl_memdev_state_create’ makes integer from pointer without a cast [-Wint-conversion]
>      8 | #define NULL ((void *)0)
>        |              ^~~~~~~~~~~
>        |              |
>        |              void *
> test/mem.c:1720:58: note: in expansion of macro ‘NULL’
>   1720 |         mds = cxl_memdev_state_create(dev, pdev->id + 1, NULL);
>        |                                                          ^~~~
> In file included from test/mem.c:14:
> linux/drivers/cxl/cxlmem.h:742:54: note: expected ‘u16’ {aka ‘short unsigned int’} but argument is of type ‘void *’
>    742 |                                                  u16 dvsec);
>        |                                                  ~~~~^~~~~
> test/mem.c:1721:15: error: too few arguments to function ‘cxl_memdev_state_create’
>   1721 |         mds = cxl_memdev_state_create(dev);
>        |               ^~~~~~~~~~~~~~~~~~~~~~~
> linux/drivers/cxl/cxlmem.h:741:26: note: declared here
>    741 | struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev, u64 serial,
>        |                          ^~~~~~~~~~~~~~~~~~~~~~~
>
>
> snip