Re: [PATCH v13 05/22] cxl: add function for type2 cxl regs setup

[Alejandro Lucero Palau <alucerop@amd.com>]

On 4/15/25 14:21, Jonathan Cameron wrote:
> On Mon, 14 Apr 2025 16:13:19 +0100
> alejandro.lucero-palau@amd.com wrote:
>
>> From: Alejandro Lucero <alucerop@amd.com>
>>
>> Create a new function for a type2 device initialising
>> cxl_dev_state struct regarding cxl regs setup and mapping.
>>
>> Export the capabilities found for checking them against the
>> expected ones by the driver.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
>> Reviewed-by: Ben Cheatham <benjamin.cheatham@amd.com>
>> ---
> One trivial thing inline.
>
>>   drivers/cxl/core/pci.c | 52 ++++++++++++++++++++++++++++++++++++++++++
>>   include/cxl/cxl.h      |  4 ++++
>>   2 files changed, 56 insertions(+)
>>
>>   int cxl_pci_get_bandwidth(struct pci_dev *pdev, struct access_coordinate *c)
>>   {
>>   	int speed, bw;
>> diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h
>> index afad8a86c2bc..729544538673 100644
>> --- a/include/cxl/cxl.h
>> +++ b/include/cxl/cxl.h
>> @@ -231,4 +231,8 @@ struct cxl_dev_state *_cxl_dev_state_create(struct device *dev,
>>   struct pci_dev;
>>   int cxl_check_caps(struct pci_dev *pdev, unsigned long *expected,
>>   		   unsigned long *found);
>> +
>> +struct cxl_memdev_state;
> Why have this here?  only cxl_dev_state is used.


Right. Some leftover from previous versions.

Removing it.

Thanks


>> +int cxl_pci_accel_setup_regs(struct pci_dev *pdev, struct cxl_dev_state *cxlmds,
>> +			     unsigned long *caps);
>>   #endif /* __CXL_CXL_H__ */