From: Ben Widawsky <ben.widawsky@intel.com>
To: linux-cxl@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-pci@vger.kernel.org
Cc: patches@lists.linux.dev, Bjorn Helgaas <helgaas@kernel.org>,
Ben Widawsky <ben.widawsky@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: [PATCH 12/13] cxl/region: Record host bridge target list
Date: Thu, 6 Jan 2022 16:37:55 -0800 [thread overview]
Message-ID: <20220107003756.806582-13-ben.widawsky@intel.com> (raw)
In-Reply-To: <20220107003756.806582-1-ben.widawsky@intel.com>
Part of host bridge verification in the CXL Type 3 Memory Device
Software Guide calculates the host bridge interleave target list (6th
step in the flow chart). With host bridge verification already done, it
is trivial to store away the configuration information.
TODO: Needs support for switches (7th step in the flow chart).
Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
---
drivers/cxl/region.c | 41 +++++++++++++++++++++++++++++++----------
1 file changed, 31 insertions(+), 10 deletions(-)
diff --git a/drivers/cxl/region.c b/drivers/cxl/region.c
index eafd95419895..3120b65b0bc5 100644
--- a/drivers/cxl/region.c
+++ b/drivers/cxl/region.c
@@ -385,6 +385,7 @@ static bool region_hb_rp_config_valid(struct cxl_region *region,
}
for (i = 0; i < hb_count; i++) {
+ struct cxl_decoder *cxld;
int idx, position_mask;
struct cxl_dport *rp;
struct cxl_port *hb;
@@ -422,10 +423,8 @@ static bool region_hb_rp_config_valid(struct cxl_region *region,
if (get_rp(ep) != rp)
continue;
- if (port_grouping == -1) {
+ if (port_grouping == -1)
port_grouping = idx & position_mask;
- continue;
- }
/*
* Do all devices in the region connected to this CXL
@@ -436,10 +435,32 @@ static bool region_hb_rp_config_valid(struct cxl_region *region,
"One or more devices are not connected to the correct Host Bridge Root Port\n");
return false;
}
+
+ if (!state_update)
+ continue;
+
+ if (dev_WARN_ONCE(&cxld->dev,
+ port_grouping >= cxld->nr_targets,
+ "Invalid port grouping %d/%d\n",
+ port_grouping, cxld->nr_targets))
+ return false;
+
+ cxld->interleave_ways++;
+ cxld->target[port_grouping] = get_rp(ep);
}
}
- if (state_update)
+
+ if (state_update) {
+ /* IG doesn't change across host bridges */
+ cxld->interleave_granularity = region_ig(region);
+
+ cxld->decoder_range = (struct range) {
+ .start = region->res->start,
+ .end = region->res->end
+ };
+
list_add_tail(&cxld->region_link, ®ion->staged_list);
+ }
}
return true;
@@ -464,7 +485,7 @@ static bool rootd_contains(const struct cxl_region *region,
return true;
}
-static bool rootd_valid(const struct cxl_region *region,
+static bool rootd_valid(struct cxl_region *region,
const struct cxl_decoder *rootd,
bool state_update)
{
@@ -489,20 +510,20 @@ static bool rootd_valid(const struct cxl_region *region,
}
struct rootd_context {
- const struct cxl_region *region;
- struct cxl_port *hbs[CXL_DECODER_MAX_INTERLEAVE];
+ struct cxl_region *region;
+ const struct cxl_port *hbs[CXL_DECODER_MAX_INTERLEAVE];
int count;
};
static int rootd_match(struct device *dev, void *data)
{
struct rootd_context *ctx = (struct rootd_context *)data;
- const struct cxl_region *region = ctx->region;
+ struct cxl_region *region = ctx->region;
if (!is_root_decoder(dev))
return 0;
- return !!rootd_valid(region, to_cxl_decoder(dev), false);
+ return rootd_valid(region, to_cxl_decoder(dev), false);
}
/*
@@ -516,7 +537,7 @@ static struct cxl_decoder *find_rootd(const struct cxl_region *region,
struct rootd_context ctx;
struct device *ret;
- ctx.region = region;
+ ctx.region = (struct cxl_region *)region;
ret = device_find_child((struct device *)&root->dev, &ctx, rootd_match);
if (ret)
--
2.34.1
next prev parent reply other threads:[~2022-01-07 0:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 0:37 [PATCH 00/13] CXL Region driver Ben Widawsky
2022-01-07 0:37 ` [PATCH 01/13] cxl/core: Rename find_cxl_port Ben Widawsky
2022-01-07 0:37 ` [PATCH 02/13] cxl/core: Track port depth Ben Widawsky
2022-01-07 0:37 ` [PATCH 03/13] cxl/region: Add region creation ABI Ben Widawsky
2022-01-07 0:37 ` [PATCH 04/13] cxl/region: Introduce concept of region configuration Ben Widawsky
2022-01-07 0:37 ` [PATCH 05/13] cxl/mem: Cache port created by the mem dev Ben Widawsky
2022-01-07 0:37 ` [PATCH 06/13] cxl/region: Introduce a cxl_region driver Ben Widawsky
2022-01-07 0:37 ` [PATCH 07/13] cxl/acpi: Handle address space allocation Ben Widawsky
2022-01-07 0:37 ` [PATCH 08/13] cxl/region: Address " Ben Widawsky
2022-01-07 0:37 ` [PATCH 09/13] cxl/region: Implement XHB verification Ben Widawsky
2022-01-07 10:07 ` Jonathan Cameron
2022-01-07 11:55 ` Jonathan Cameron
2022-01-11 22:47 ` Ben Widawsky
2022-01-07 10:30 ` Jonathan Cameron
2022-01-07 10:38 ` Jonathan Cameron
2022-01-07 16:32 ` Ben Widawsky
2022-01-11 21:32 ` Ben Widawsky
2022-01-07 0:37 ` [PATCH 10/13] cxl/region: HB port config verification Ben Widawsky
2022-01-07 0:37 ` [PATCH 11/13] cxl/region: Add infrastructure for decoder programming Ben Widawsky
2022-01-07 0:37 ` Ben Widawsky [this message]
2022-01-07 18:14 ` [PATCH 12/13] cxl/region: Record host bridge target list Jonathan Cameron
2022-01-07 19:20 ` Dan Williams
2022-01-07 0:37 ` [PATCH 13/13] cxl: Program decoders for regions Ben Widawsky
2022-01-07 16:18 ` Jonathan Cameron
2022-01-07 16:33 ` Ben Widawsky
2022-01-07 17:22 ` Jonathan Cameron
2022-01-11 0:05 ` Ben Widawsky
2022-01-12 14:53 ` Jonathan Cameron
2022-01-12 16:54 ` Ben Widawsky
2022-01-15 18:54 ` [PATCH 00/13] CXL Region driver Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107003756.806582-13-ben.widawsky@intel.com \
--to=ben.widawsky@intel.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=helgaas@kernel.org \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox