Re: [PATCH 1/5] cxl/mem : Read Dynamic capacity configuration from the device

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

#> > > +int cxl_dev_dynamic_capacity_identify(struct cxl_memdev_state *mds)
> > > +{
> > > +	struct cxl_dev_state *cxlds = &mds->cxlds;
> > > +	struct device *dev = cxlds->dev;
> > > +	struct cxl_mbox_dynamic_capacity *dc;  
> > 
> > Calling it dc is confusing.  I'd make it clear this is the mailbox
> > response. config_resp or dc_config_res.  
> 
> How about dc_resp?

That works for me as well.

...

> > 
> > 
> > But fun corner.... Mailbox is allowed to be smaller than that (256 bytes min
> > I think) so need to handle multiple reads with different start regions.  
> 
> Oh bother.  :-/
> 
> What are the chances a device is going to only support 256B and DC?  I think
> you are correct though.  I'll add a loop to handle this possibility.
> 
> Anyway I've adjusted the algorithm...  Hopefully it will just loop 1 time.
> 
> > Which reminds me that we need to add support for running out of space
> > in the mailbox to qemu... So far we've just made sure everything fitted :)  
> 
> Might be nice to test stuff.
>

Hmm. I'll try not to forget about it this time, unlike the previous 10 times
I've thought we should fix that :)