Re: [PATCH 3/5] cxl/mem : Expose dynamic capacity configuration to userspace

[Ira Weiny <ira.weiny@intel.com>]

Dave Jiang wrote:
> 
> 
> On 6/15/23 19:47, Ira Weiny wrote:
> > Alison Schofield wrote:
> >> On Wed, Jun 14, 2023 at 12:16:30PM -0700, Ira Weiny wrote:
> >>> From: Navneet Singh <navneet.singh@intel.com>
> >>>

[snip]

> > 
> > Writing the documentation it seems like 'dc_region_count' should just be
> > 'region_count'.  Because the 'dc' is redundant with the directory.
> > However, dcY_size has a redundant 'dc' but Y_size (ie 0_size) seems
> > odd.[*]
> > 
> > Thoughts on the 'dc' prefix for these?
> > 
> > [*] example listing with 2 DC regions supported.
> > 
> > $ ll mem1/dc/
> > total 0
> > -r--r--r-- 1 root root 4096 Jun 15 19:26 dc0_size
> > -r--r--r-- 1 root root 4096 Jun 15 19:26 dc1_size
> > -r--r--r-- 1 root root 4096 Jun 15 19:26 dc_regions_count
> > 
> >>
> >> A bit of my ignorance here, but when I keep seeing the word
> >> 'regions' below, it makes me wonder whether these attributes
> >> are in the right place?
> > 
> > There is a difference between 'DC region' and CXL 'Linux' region.  It has
> > taken me some time to get used to the terminology.  So I think this is
> > correct.
> 
> I think you answered your own question above here. If dc_region is 
> different than CXL regions, then you'll have to keep the dc_ prefix to 
> distinguish between the two. Unless you call it something different.

But it sits in the 'dc' directory.

memX/dc/dc_regions_count
memX/dc/dc0_size
...

So it feels like the dc is redundant.  But it is probably ok as it is.

Ira