Re: [PATCH 2/5] cxl/region: Add dynamic capacity cxl region support.

[Ira Weiny <ira.weiny@intel.com>]

Alison Schofield wrote:
> On Wed, Jun 14, 2023 at 12:16:29PM -0700, Ira Weiny wrote:
> > From: Navneet Singh <navneet.singh@intel.com>
> > 
> > CXL devices optionally support dynamic capacity. CXL Regions must be
> > created to access this capacity.
> > 
> > Add sysfs entries to create dynamic capacity cxl regions. Provide a new
> > Dynamic Capacity decoder mode which targets dynamic capacity on devices
> > which are added to that region.
> 
> This is a lot in one patch, especially where it weaves in and out of
> existing code. I'm wondering if this can be introduced in smaller
> pieces (patches). An introductory patch explaining the DC DPA 
> allocations might be a useful chunk to pull forward. 

The patch is < 800 lines long.  And would be closer to 700 lines if there
were not 8 different 'modes' for the various DC regions.

It is also very self contained in that it implements the region creation
for DC DPAs fully.  And I know that Dan prefers patches larger if they are
all part of the same functionality.

Dan?

Ira