Re: [PATCH v2 1/3] cxl/region: Refactor address translation funcs for testing

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Fri, 29 Aug 2025 00:21:25 -0700
Alison Schofield <alison.schofield@intel.com> wrote:

> In preparation for adding a test module that exercises the address
> translation calculations, extract the core calculations into stand-
> alone functions that operate on base parameters without dependencies
> on struct cxl_region.
> 
> Mark the new functions as static outside of test builds by adding
> and using a new __mock_export label.

For the __mock_exports magic, I assume that can be applied in existing
cases as well.  Perhaps better to introduce it for them first?
That would give a nice clear example of what changes.

> 
> This refactoring enables unit testing of the address translation logic
> with controlled inputs, while maintaining identical functionality in
> the existing code paths.
> 
> The moved code has only one change. In the new cxl_calculate_position()
> eiw_to_ways(eiw, &ways) replaces the prior usage of p->interleave_ways,
> since the new function cannot depend upon struct cxl_region_params.
> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>

Otherwise LGTM
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>