Re: [PATCH v2 1/3] cxl/region: Refactor address translation funcs for testing

[Alison Schofield <alison.schofield@intel.com>]

On Thu, Sep 04, 2025 at 03:05:00PM -0700, Dave Jiang wrote:
> 

snip

> > +	bits_lower = hpa_offset & GENMASK_ULL(eig + 7, 0);
> > +	if (eiw < 8) {
> > +		temp = hpa_offset &= ~((u64)GENMASK(eig + eiw + 8 - 1, 0));
> 
> Should this use GENMASK_ULL() instead of casting to u64?

Yes. Will do in next rev.

> > +
snip

> > +	for (int i = 0; i < p->nr_targets; i++) {
> > +		cxled = p->targets[i];
> > +		if (cxlmd == cxled_to_memdev(cxled))
> > +			break;
> > +	}
> > +	if (!cxled || cxlmd != cxled_to_memdev(cxled))
> > +		return ULLONG_MAX;
> 
> Maybe:
> 
> 	for (int i = 0; i < p->nr_targets; i++) {
> 		if (cxlmd == cxled_to_memdev(p->targets[i])) {
> 			cxled = p->targets[i];
> 			break;
> 		}
> 	}
> 
> 	if (!cxled)
> 		return ULLONG_MAX;

Nice - avoids avoids the redundant check by only assigning cxled when a match
is found.  Will use in next rev.

Thanks for the review!

> 
> DJ