Re: [PATCH v2 1/3] cxl/region: Refactor address translation funcs for testing

[Alison Schofield <alison.schofield@intel.com>]

On Tue, Sep 09, 2025 at 05:10:05PM +0100, Jonathan Cameron wrote:
> On Fri, 29 Aug 2025 00:21:25 -0700
> Alison Schofield <alison.schofield@intel.com> wrote:
> 
> > In preparation for adding a test module that exercises the address
> > translation calculations, extract the core calculations into stand-
> > alone functions that operate on base parameters without dependencies
> > on struct cxl_region.
> > 
> > Mark the new functions as static outside of test builds by adding
> > and using a new __mock_export label.
> 
> For the __mock_exports magic, I assume that can be applied in existing
> cases as well.  Perhaps better to introduce it for them first?
> That would give a nice clear example of what changes.

I came upon this new-ish helper and intend to replace the __mock_exports
magic with it in the next revision of this set.

707f853d7fa3 ("module: Provide EXPORT_SYMBOL_GPL_FOR_MODULES() helper")

I think the existing cxl_num_decoders_committed can use the helper too,
and if that works out I'll present it first as an example of using the
new helper as you suggest.

Thanks for the review!

>