From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-sound@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Srinivas Kandagatla" <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v7 1/7] ASoC: qcom: qdsp6: add topology-driven Audio IF support
Date: Tue, 4 Aug 2026 19:46:58 +0200 [thread overview]
Message-ID: <03f5d925-3d54-4634-bbf7-c2b29dfc7f07@intel.com> (raw)
In-Reply-To: <20260804070307.117119-2-prasad.kumpatla@oss.qualcomm.com>
On 8/4/2026 9:03 AM, Prasad Kumpatla wrote:
> Add topology parsing and media-format programming for Audio IF source and
> sink modules.
...
> include/uapi/sound/snd_ar_tokens.h | 93 ++++++++++++++++++++++++++
Meh, looks like QCOM took a "bad" example from Intel's past drivers and
put the header directly within uapi/sound/ without any meaningful
prefix. Even moving the header into vendor-specific subfolder e.g.:
uapi/sound/qcom/ would be a good start. For "better" examples take a
look at headers exposed for newer drivers: sound/intel and sound/sof.
I'd suggest to move away from snd_ar_tokens.h (the name is as ambiguous
is at can be) and start new header family within 'qcom' subfolder.
At the same time I'll prepare a patch and remove the remaining "bad"
examples so people don't propagate them.
Kind regards,
Czarek
next prev parent reply other threads:[~2026-08-04 17:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 7:03 [PATCH v7 0/7] ASoC: qcom: add AudioReach TDM backend support Prasad Kumpatla
2026-08-04 7:03 ` [PATCH v7 1/7] ASoC: qcom: qdsp6: add topology-driven Audio IF support Prasad Kumpatla
2026-08-04 7:16 ` sashiko-bot
2026-08-04 17:46 ` Cezary Rojewski [this message]
2026-08-04 17:50 ` Mark Brown
2026-08-04 17:58 ` Cezary Rojewski
2026-08-04 7:03 ` [PATCH v7 2/7] ASoC: qcom: q6apm-lpass-dais: add TDM DAI operations Prasad Kumpatla
2026-08-04 7:03 ` [PATCH v7 3/7] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks Prasad Kumpatla
2026-08-04 7:08 ` sashiko-bot
2026-08-04 20:16 ` Rob Herring
2026-08-05 4:40 ` Prasad Kumpatla
2026-08-05 6:10 ` Krzysztof Kozlowski
2026-08-05 6:29 ` Prasad Kumpatla
2026-08-05 6:33 ` Krzysztof Kozlowski
2026-08-05 6:36 ` Krzysztof Kozlowski
2026-08-05 6:50 ` Prasad Kumpatla
2026-08-04 7:03 ` [PATCH v7 4/7] ASoC: qcom: q6prm: add Audio IF clock IDs Prasad Kumpatla
2026-08-04 7:11 ` sashiko-bot
2026-08-04 7:03 ` [PATCH v7 5/7] dt-bindings: sound: qcom,sm8250: allow TDM slot properties Prasad Kumpatla
2026-08-04 7:17 ` sashiko-bot
2026-08-04 7:03 ` [PATCH v7 6/7] ASoC: qcom: common: add DAI-node TDM slot helpers Prasad Kumpatla
2026-08-04 7:18 ` sashiko-bot
2026-08-04 7:03 ` [PATCH v7 7/7] ASoC: qcom: sc8280xp: add TDM hw_params support Prasad Kumpatla
2026-08-04 7:23 ` sashiko-bot
2026-08-04 16:32 ` [PATCH v7 0/7] ASoC: qcom: add AudioReach TDM backend support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03f5d925-3d54-4634-bbf7-c2b29dfc7f07@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox