Re: [PATCH v7 3/7] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added dt-binding macros use the misspelled prefix `LAPSS_` instead of `LPASS_`.
--

--- Patch [3]: [PATCH v7 3/7] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks ---
commit fc46e0e8ad5b4e05db5d3982d7d3f2cb53429499
Author: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>

dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks

This commit adds the LPASS Audio IF clock IDs used by newer backend
interfaces. The bit clocks are requested through q6prm by platforms
using Audio IF module backends.

> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> index ca84952c38841..2e879a3c09aef 100644
> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
[ ... ]
> @@ -237,6 +237,35 @@
>  /* Clock ID for RX CORE MCLK2 2X  MCLK */
>  #define LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK	70
>  
> +#define LAPSS_CLK_ID_QAIF_IF0_IBIT		71

[Severity: Low]
This isn't a bug, but there appears to be a typo in the prefix. Should these
new macros be named LPASS_CLK_ID_ instead of LAPSS_CLK_ID_ to match the
subsystem name and the existing entries? 

Since device tree bindings form a stable ABI, correcting this spelling before
it is merged might prevent needing backward compatibility aliases later.

> +#define LAPSS_CLK_ID_QAIF_IF0_EBIT		72
> +#define LAPSS_CLK_ID_QAIF_IF1_IBIT		73
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804070307.117119-1-prasad.kumpatla@oss.qualcomm.com?part=3