Re: [PATCH v7 5/7] dt-bindings: sound: qcom,sm8250: allow TDM slot properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Meaningful code and commit message mismatch: missing TDM slot parsing implementation in QCOM machine drivers.
--

--- Patch [5]: [PATCH v7 5/7] dt-bindings: sound: qcom,sm8250: allow TDM slot properties ---
commit 068c68db6ac28d3b45bf5901b4f8efe15a3d6ae6
Author: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>

dt-bindings: sound: qcom,sm8250: allow TDM slot properties

This commit updates the qcom,sm8250 device tree binding to permit standard
TDM slot properties in the CPU and codec child nodes.

> The QCOM machine driver parses these child nodes to configure TDM slots
> on the active CPU and codec DAIs.

[Severity: Medium]
Is this description accurate regarding the machine driver's current behavior?

Looking at sm8250_platform_probe() in sound/soc/qcom/sm8250.c, it calls
qcom_snd_parse_of() which parses the DAI links, but neither function appears
to utilize snd_soc_of_parse_tdm_slot() or any manual logic to extract the
TDM slot properties.

If the machine driver currently lacks the implementation to parse these
properties, will the TDM slot configuration specified in the device tree be
silently ignored? Is there perhaps a missing patch in this series that adds
the required parsing logic to the machine driver?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804070307.117119-1-prasad.kumpatla@oss.qualcomm.com?part=5